mirror of
https://github.com/Respect/Validation.git
synced 2026-03-16 23:35:45 +01:00
2aa5e39c54After changes in the key-related rules, the KeySet rule became unusable. Besides, when evaluating an input, it wasn't reporting every single failure because it would not validate the items in the array if they had missing or extra keys. This commit will make several improvements to the rule. It will create some not(keyExists($key)) rules for the extra keys, which makes the error reporting much better. A limit of 10 additional keys will show up when asserting an input with extra keys. I put that limit in place to prevent the creation of too many rules.
61 lines
2 KiB
PHP
61 lines
2 KiB
PHP
<?php
|
|
|
|
/*
|
|
* Copyright (c) Alexandre Gomes Gaigalas <alganet@gmail.com>
|
|
* SPDX-License-Identifier: MIT
|
|
*/
|
|
|
|
declare(strict_types=1);
|
|
|
|
namespace Respect\Validation\Rules;
|
|
|
|
use PHPUnit\Framework\Attributes\CoversClass;
|
|
use PHPUnit\Framework\Attributes\Group;
|
|
use PHPUnit\Framework\Attributes\Test;
|
|
use Respect\Validation\Exceptions\InvalidRuleConstructorException;
|
|
use Respect\Validation\Test\Rules\Stub;
|
|
use Respect\Validation\Test\RuleTestCase;
|
|
|
|
#[Group('rule')]
|
|
#[CoversClass(KeySet::class)]
|
|
final class KeySetTest extends RuleTestCase
|
|
{
|
|
#[Test]
|
|
public function nonKeyRelatedRuleShouldNotBeAllowed(): void
|
|
{
|
|
$this->expectException(InvalidRuleConstructorException::class);
|
|
$this->expectExceptionMessage('You must provide only key-related rules');
|
|
|
|
new KeySet(new Equals('foo'));
|
|
}
|
|
|
|
/** @return iterable<string, array{KeySet, mixed}> */
|
|
public static function providerForValidInput(): iterable
|
|
{
|
|
yield 'correct keys, with passing rule' => [new KeySet(new Key('foo', Stub::pass(1))), ['foo' => 'bar']];
|
|
}
|
|
|
|
/** @return iterable<string, array{KeySet, mixed}> */
|
|
public static function providerForInvalidInput(): iterable
|
|
{
|
|
yield 'not an array' => [new KeySet(new KeyExists('foo')), null];
|
|
yield 'missing keys' => [new KeySet(new KeyExists('foo')), []];
|
|
yield 'extra keys, missing keys' => [
|
|
new KeySet(new KeyExists('foo')),
|
|
['baz' => 'qux'],
|
|
];
|
|
yield 'extra keys, failed rule' => [
|
|
new KeySet(new Key('foo', Stub::pass(1))),
|
|
['foo' => 'bar', 'baz' => 'qux'],
|
|
];
|
|
yield 'missing key, failed rule' => [
|
|
new KeySet(new Key('foo', Stub::fail(1)), new KeyExists('bar')),
|
|
['foo' => 'bar', 'baz' => 'qux'],
|
|
];
|
|
yield 'extra keys, with failing rule' => [
|
|
new KeySet(new Key('foo', Stub::fail(1))),
|
|
['foo' => 'bar', 'baz' => 'qux'],
|
|
];
|
|
yield 'correct keys, with failing rule' => [new KeySet(new Key('foo', Stub::fail(1))), ['foo' => 'bar']];
|
|
}
|
|
}
|