mirror of
https://github.com/Respect/Validation.git
synced 2026-03-18 08:09:51 +01:00
2b59e3df49Currently, we convert the properties of a rule into parameters and pass them to the exceptions. That complicates things for a few reasons: 1. The exception knows too much: there's a lot of information in an object, and the exception would only need a few parameters to work correctly. 2. Any variable change becomes a backward compatibility break: if we change the name of the variable type in a rule, even if it's a private one, we may need to change the template, which is a backward compatibility break. 3. The factory is bloated because of introspection tricks: it reads the properties from the class, even from the parent, and then passes it to the exception. Of course, that means we introduce another method to `Validatable`, but in most cases, extending `AbstractRule` is enough to create a new rule. Signed-off-by: Henrique Moody <henriquemoody@gmail.com>
76 lines
1.8 KiB
PHP
76 lines
1.8 KiB
PHP
<?php
|
|
|
|
/*
|
|
* Copyright (c) Alexandre Gomes Gaigalas <alganet@gmail.com>
|
|
* SPDX-License-Identifier: MIT
|
|
*/
|
|
|
|
declare(strict_types=1);
|
|
|
|
namespace Respect\Validation\Rules;
|
|
|
|
use DateTime;
|
|
use DateTimeImmutable;
|
|
use PHPUnit\Framework\Attributes\CoversClass;
|
|
use PHPUnit\Framework\Attributes\DataProvider;
|
|
use PHPUnit\Framework\Attributes\Group;
|
|
use PHPUnit\Framework\Attributes\Test;
|
|
use Respect\Validation\Exceptions\ComponentException;
|
|
use Respect\Validation\Test\RuleTestCase;
|
|
|
|
#[Group('rule')]
|
|
#[CoversClass(Time::class)]
|
|
final class TimeTest extends RuleTestCase
|
|
{
|
|
#[Test]
|
|
#[DataProvider('invalidFormatsProvider')]
|
|
public function shouldThrowAnExceptionWhenFormatIsNotValid(string $format): void
|
|
{
|
|
$this->expectException(ComponentException::class);
|
|
|
|
new Time($format);
|
|
}
|
|
|
|
/**
|
|
* @return mixed[][]
|
|
*/
|
|
public static function invalidFormatsProvider(): array
|
|
{
|
|
return [
|
|
['Y-m-d H:i:s'],
|
|
['M g:i A'],
|
|
];
|
|
}
|
|
|
|
/**
|
|
* @return array<array{Time, mixed}>
|
|
*/
|
|
public static function providerForValidInput(): array
|
|
{
|
|
return [
|
|
[new Time(), '00:00:00'],
|
|
[new Time(), '23:20:59'],
|
|
[new Time('H:i'), '23:59'],
|
|
[new Time('g:i A'), '8:13 AM'],
|
|
[new Time('His'), 232059],
|
|
[new Time('H:i:s.u'), '08:16:01.000000'],
|
|
[new Time('ga'), '3am'],
|
|
];
|
|
}
|
|
|
|
/**
|
|
* @return array<array{Time, mixed}>
|
|
*/
|
|
public static function providerForInvalidInput(): array
|
|
{
|
|
return [
|
|
[new Time(), '00:00:60'],
|
|
[new Time(), '00:60:00'],
|
|
[new Time(), '24:00:00'],
|
|
[new Time(), '00:00'],
|
|
[new Time(), new DateTime()],
|
|
[new Time(), new DateTimeImmutable()],
|
|
[new Time(), ''],
|
|
];
|
|
}
|
|
}
|