mirror of
https://github.com/Respect/Validation.git
synced 2026-03-14 22:35:45 +01:00
33927e26d1The array_reduce in isVisible() used `true` as its initial value with an `||` reducer, meaning it always returned `true` when siblings existed regardless of their actual visibility. This caused unnecessary nesting in full messages by showing single-child wrapper nodes that should have been collapsed. Replace array_reduce with a foreach loop starting from `false`, which also enables early return on the first visible sibling.
57 lines
2 KiB
PHP
57 lines
2 KiB
PHP
<?php
|
|
|
|
/*
|
|
* SPDX-License-Identifier: MIT
|
|
* SPDX-FileCopyrightText: (c) Respect Project Contributors
|
|
* SPDX-FileContributor: Alexandre Gomes Gaigalas <alganet@gmail.com>
|
|
* SPDX-FileContributor: Henrique Moody <henriquemoody@gmail.com>
|
|
* SPDX-FileContributor: Jonathan Stewmon <jstewmon@rmn.com>
|
|
*/
|
|
|
|
declare(strict_types=1);
|
|
|
|
test('https://github.com/Respect/Validation/issues/796', catchAll(
|
|
fn() => v::named('the given data', v::init()
|
|
->key(
|
|
'mysql',
|
|
v::init()
|
|
->key('host', v::stringType())
|
|
->key('user', v::stringType())
|
|
->key('password', v::stringType())
|
|
->key('schema', v::stringType()),
|
|
)
|
|
->key(
|
|
'postgresql',
|
|
v::init()
|
|
->key('host', v::stringType())
|
|
->key('user', v::stringType())
|
|
->key('password', v::stringType())
|
|
->key('schema', v::stringType()),
|
|
))
|
|
->assert([
|
|
'mysql' => [
|
|
'host' => 42,
|
|
'user' => 'user',
|
|
'password' => 'password',
|
|
'schema' => 'schema',
|
|
],
|
|
'postgresql' => [
|
|
'host' => 'host',
|
|
'user' => 42,
|
|
'password' => 'password',
|
|
'schema' => 'schema',
|
|
],
|
|
]),
|
|
fn(string $message, string $fullMessage, array $messages) => expect()
|
|
->and($message)->toBe('`.mysql.host` (<- the given data) must be a string')
|
|
->and($fullMessage)->toBe(<<<'FULL_MESSAGE'
|
|
- the given data must pass all the rules
|
|
- `.mysql.host` must be a string
|
|
- `.postgresql.user` must be a string
|
|
FULL_MESSAGE)
|
|
->and($messages)->toBe([
|
|
'__root__' => 'the given data must pass all the rules',
|
|
'mysql' => '`.mysql.host` must be a string',
|
|
'postgresql' => '`.postgresql.user` must be a string',
|
|
]),
|
|
));
|