respect-validation/tests/feature/Issues/Issue1376Test.php
Henrique Moody b5ad7aa47a
Make Validator immutable
Mutable objects can be challenging to work with in larger codebases
because different parts of a system may modify the same instance, making
it difficult to trace where and when changes occurred. This becomes
especially problematic when debugging unexpected behaviour.

By making `Validator` immutable, we ensure that adding rules via
`with()` returns a new instance rather than mutating the original, and
we use the `with()` method inside `__call()`, making every call to a
rule into a clone of the current `Validator`.

This provides several benefits:

1. Predictability: A `Validator` instance will always behave the same
   way throughout its lifetime, regardless of what other parts of the
   codebase do.

2. Safe dependency injection: Users can now confidently inject a base
   `Validator` from a DI container, knowing that any modifications made
   elsewhere will not affect their instance.

3. Easier debugging: Since validators cannot be mutated after creation,
   there's no need to track down where an unexpected rule was added.

4. Reusability: Users can create an initial `Validator` with some base
   rules and reuse it by just adding new rules to the chain without
   affecting the base `Validator`.
2026-01-02 15:45:23 +01:00

35 lines
1.4 KiB
PHP

<?php
/*
* Copyright (c) Alexandre Gomes Gaigalas <alganet@gmail.com>
* SPDX-License-Identifier: MIT
*/
declare(strict_types=1);
test('https://github.com/Respect/Validation/issues/1376', catchAll(
fn() => v::init()
->property('title', v::lengthBetween(2, 3)->stringType())
->property('description', v::stringType())
->property('author', v::intType()->lengthBetween(1, 2))
->property('user', v::intVal()->lengthBetween(1, 2))
->assert((object) ['author' => 'foo']),
fn(string $message, string $fullMessage, array $messages) => expect()
->and($message)->toBe('`.title` must be present')
->and($fullMessage)->toBe(<<<'FULL_MESSAGE'
- `stdClass { +$author="foo" }` must pass all the rules
- `.title` must be present
- `.description` must be present
- `.author` must pass all the rules
- `.author` must be an integer
- The length of `.author` must be between 1 and 2
- `.user` must be present
FULL_MESSAGE)
->and($messages)->toBe([
'__root__' => '`stdClass { +$author="foo" }` must pass all the rules',
'title' => '`.title` must be present',
'description' => '`.description` must be present',
'author' => 'The length of `.author` must be between 1 and 2',
'user' => '`.user` must be present',
]),
));