respect-validation/library/Message/StandardFormatter.php
Henrique Moody 82cb05b197
Handle siblings when creating messages
The way we display messages could have been better, and it took me a
while to realise that to make it better, I would need to handle the
siblings of a result before deciding whether we should render it.

Another issue was that rules like Key and Property had to create a
"dumb" parent just so we would display the messages correctly, and in
some cases, that wasn't even enough.

This commit introduces quite a few changes to how the library works,
making the messages much more straightforward.
2024-12-13 02:34:27 +01:00

244 lines
7.3 KiB
PHP

<?php
/*
* Copyright (c) Alexandre Gomes Gaigalas <alganet@gmail.com>
* SPDX-License-Identifier: MIT
*/
declare(strict_types=1);
namespace Respect\Validation\Message;
use Respect\Validation\Exceptions\ComponentException;
use Respect\Validation\Result;
use function array_filter;
use function array_key_exists;
use function array_reduce;
use function array_values;
use function count;
use function current;
use function is_array;
use function is_string;
use function Respect\Stringifier\stringify;
use function rtrim;
use function sprintf;
use function str_repeat;
use const PHP_EOL;
final class StandardFormatter implements Formatter
{
public function __construct(
private readonly Renderer $renderer = new StandardRenderer(),
) {
}
/**
* @param array<string, mixed> $templates
*/
public function main(Result $result, array $templates, Translator $translator): string
{
$selectedTemplates = $this->selectTemplates($result, $templates);
if (!$this->isFinalTemplate($result, $selectedTemplates)) {
foreach ($this->extractDeduplicatedChildren($result) as $child) {
return $this->main($child, $selectedTemplates, $translator);
}
}
return $this->renderer->render($this->getTemplated($result, $selectedTemplates), $translator);
}
/**
* @param array<string, mixed> $templates
*/
public function full(
Result $result,
array $templates,
Translator $translator,
int $depth = 0,
Result ...$siblings
): string {
$selectedTemplates = $this->selectTemplates($result, $templates);
$isFinalTemplate = $this->isFinalTemplate($result, $selectedTemplates);
$rendered = '';
if ($this->isAlwaysVisible($result, ...$siblings) || $isFinalTemplate) {
$indentation = str_repeat(' ', $depth * 2);
$rendered .= sprintf(
'%s- %s' . PHP_EOL,
$indentation,
$this->renderer->render($this->getTemplated($result, $selectedTemplates), $translator),
);
$depth++;
}
if (!$isFinalTemplate) {
$results = $this->extractDeduplicatedChildren($result);
foreach ($results as $child) {
$rendered .= $this->full(
$child,
$selectedTemplates,
$translator,
$depth,
...array_filter($results, static fn (Result $sibling) => $sibling !== $child)
);
$rendered .= PHP_EOL;
}
}
return rtrim($rendered, PHP_EOL);
}
/**
* @param array<string, mixed> $templates
*
* @return array<string, mixed>
*/
public function array(Result $result, array $templates, Translator $translator): array
{
$selectedTemplates = $this->selectTemplates($result, $templates);
$deduplicatedChildren = $this->extractDeduplicatedChildren($result);
if (count($deduplicatedChildren) === 0 || $this->isFinalTemplate($result, $selectedTemplates)) {
return [
$result->id => $this->renderer->render($this->getTemplated($result, $selectedTemplates), $translator),
];
}
$messages = [];
foreach ($deduplicatedChildren as $child) {
$messages[$child->id] = $this->array(
$child,
$this->selectTemplates($child, $selectedTemplates),
$translator
);
if (count($messages[$child->id]) !== 1) {
continue;
}
$messages[$child->id] = current($messages[$child->id]);
}
if (count($messages) > 1) {
$self = [
'__root__' => $this->renderer->render($this->getTemplated($result, $selectedTemplates), $translator),
];
return $self + $messages;
}
return $messages;
}
private function isAlwaysVisible(Result $result, Result ...$siblings): bool
{
if ($result->isValid) {
return false;
}
if ($result->hasCustomTemplate()) {
return true;
}
$childrenAlwaysVisible = array_filter(
$result->children,
fn (Result $child) => $this->isAlwaysVisible($child, ...array_filter(
$result->children,
static fn (Result $sibling) => $sibling !== $child
))
);
if (count($childrenAlwaysVisible) !== 1) {
return true;
}
if (count($siblings) === 0) {
return false;
}
return array_reduce(
$siblings,
fn (bool $carry, Result $currentSibling) => $carry || $this->isAlwaysVisible(
$currentSibling,
...array_filter($siblings, static fn (Result $sibling) => $sibling !== $currentSibling)
),
true
);
}
/** @param array<string, mixed> $templates */
private function getTemplated(Result $result, array $templates): Result
{
if ($result->hasCustomTemplate()) {
return $result;
}
if (!isset($templates[$result->id]) && isset($templates['__root__'])) {
return $result->withTemplate($templates['__root__']);
}
if (!isset($templates[$result->id])) {
return $result;
}
$template = $templates[$result->id];
if (is_string($template)) {
return $result->withTemplate($template);
}
throw new ComponentException(
sprintf('Template for "%s" must be a string, %s given', $result->id, stringify($template))
);
}
/**
* @param array<string, mixed> $templates
*/
private function isFinalTemplate(Result $result, array $templates): bool
{
if (isset($templates[$result->id]) && is_string($templates[$result->id])) {
return true;
}
if (count($templates) !== 1) {
return false;
}
return isset($templates['__root__']) || isset($templates[$result->id]);
}
/**
* @param array<string, mixed> $templates
*
* @return array<string, mixed>
*/
private function selectTemplates(Result $message, array $templates): array
{
if (isset($templates[$message->id]) && is_array($templates[$message->id])) {
return $templates[$message->id];
}
return $templates;
}
/** @return array<Result> */
private function extractDeduplicatedChildren(Result $result): array
{
/** @var array<string, Result> $deduplicatedResults */
$deduplicatedResults = [];
$duplicateCounters = [];
foreach ($result->children as $child) {
$id = $child->id;
if (isset($duplicateCounters[$id])) {
$id .= '.' . ++$duplicateCounters[$id];
} elseif (array_key_exists($id, $deduplicatedResults)) {
$deduplicatedResults[$id . '.1'] = $deduplicatedResults[$id]?->withId($id . '.1');
unset($deduplicatedResults[$id]);
$duplicateCounters[$id] = 2;
$id .= '.2';
}
$deduplicatedResults[$id] = $child->isValid ? null : $child->withId($id);
}
return array_values(array_filter($deduplicatedResults));
}
}