respect-validation/tests/unit/Rules/DigitTest.php
Henrique Moody 9283c8ecd9
Do not accept whitespace by default in "Digit" rule
The "Digit" rule is meant to validate digits. However, by default, it
also considers any whitespace character (spaces, new lines, tabs, etc)
as valid.

Since the rule also accepts a list of characters to ignore during the
validation it seemed logical to me to leave the responsibility of
allowing whitespace characters on the hands of the one who uses the
rule.

The messages of the exception are not really consistent, this commit
will also fix that.

It's also clear that the "AbstractCtypeRule" is an unnecessary overhead
since it is only a proxy for "AbstractFilterRule". That one can and
should even be removed after this commit is applied especially because
this commit will also remove the method "filterWhiteSpaceOption" which
is the only substantial difference between "AbstractCtypeRule" and
"AbstractFilterRule".

This commit will also apply our guidelines to the "Digit" rule since we
want to do that to all the rules we have.

Signed-off-by: Henrique Moody <henriquemoody@gmail.com>
2018-09-12 10:00:17 +02:00

99 lines
2.9 KiB
PHP

<?php
/*
* This file is part of Respect/Validation.
*
* (c) Alexandre Gomes Gaigalas <alexandre@gaigalas.net>
*
* For the full copyright and license information, please view the "LICENSE.md"
* file that was distributed with this source code.
*/
declare(strict_types=1);
namespace Respect\Validation\Rules;
use Respect\Validation\Test\RuleTestCase;
use stdClass;
/**
* @group rule
*
* @covers \Respect\Validation\Rules\Digit
*
* @author Alexandre Gomes Gaigalas <alexandre@gaigalas.net>
* @author Gabriel Caruso <carusogabriel34@gmail.com>
* @author Henrique Moody <henriquemoody@gmail.com>
* @author Nick Lombard <github@jigsoft.co.za>
* @author Pascal Borreli <pascal@borreli.com>
*/
final class DigitTest extends RuleTestCase
{
/**
* @test
*
* @expectedException \Respect\Validation\Exceptions\ComponentException
*
* @dataProvider providerForInvalidParams
*
* @param mixed $additional
*/
public function invalidConstructorParamsShouldThrowComponentExceptionUponInstantiation($additional): void
{
new Digit($additional);
}
public function providerForInvalidParams(): array
{
return [
[new stdClass()],
[[]],
[0x2],
];
}
/**
* @throws \Respect\Validation\Exceptions\ComponentException
*
* @return array
*/
public function providerForValidInput(): array
{
return [
'positive integer' => [new Digit(), 165],
'positive string-integer' => [new Digit(), '01650'],
'positive string-integer with one exception' => [new Digit('-'), '16-50'],
'positive string-integer with multiple exceptions' => [new Digit('.-'), '16-5.0'],
'only exceptions' => [new Digit('!@#$%^&*(){}'), '!@#$%^&*(){}'],
'float' => [new Digit(), 1.0],
'boolean true' => [new Digit(), true],
'octal' => [new Digit(), 01],
'string-octal' => [new Digit(), '01'],
];
}
/**
* {@inheritdoc}
*
* @throws \Respect\Validation\Exceptions\ComponentException
*/
public function providerForInvalidInput(): array
{
return [
'empty' => [new Digit(), ''],
'with spaces' => [new Digit(), '16 50'],
'with tabs' => [new Digit(), "1\t1"],
'with newlines' => [new Digit(), "1\n1"],
'null' => [new Digit(), null],
'with non-numeric' => [new Digit(), '16-50'],
'alphabetic' => [new Digit(), 'a'],
'alphanumeric' => [new Digit(), 'a1'],
'negative integer' => [new Digit(), -12],
'negative string-integer' => [new Digit(), '-12'],
'float-string' => [new Digit(), '1.0'],
'negative float' => [new Digit(), -1.1],
'negative string-float' => [new Digit(), '-1.1'],
'boolean false' => [new Digit(), false],
];
}
}