mirror of
https://github.com/Respect/Validation.git
synced 2026-03-16 15:25:45 +01:00
a372a0b90bI've moved almost all the code for placeholder replacement and parameter modifiers into an external library called Respect\StringFormatter. This approach allows us to evolve the template capabilities without making major changes to the Validation's code. This commit will introduce another dependency, `respect/string-formatter`, and will upgrade the version of `respect/string-formatter`, which simplifies our internal API greatly. While making this change, I also updated how we generate exceptions. Instead of rendering the full message and the array of messages, we delegate that creation to the `ResultQuery`, which improves performance because we don’t need to render those big messages unless the user actually needs them.
83 lines
2.6 KiB
PHP
83 lines
2.6 KiB
PHP
<?php
|
|
|
|
/*
|
|
* SPDX-License-Identifier: MIT
|
|
* SPDX-FileCopyrightText: (c) Respect Project Contributors
|
|
* SPDX-FileContributor: Henrique Moody <henriquemoody@gmail.com>
|
|
*/
|
|
|
|
declare(strict_types=1);
|
|
|
|
use Respect\Validation\Exceptions\ValidationException;
|
|
use Respect\Validation\ResultQuery;
|
|
use Respect\Validation\Test\Builders\ResultBuilder;
|
|
use Respect\Validation\Test\Message\TestingArrayFormatter;
|
|
use Respect\Validation\Test\Message\TestingMessageRenderer;
|
|
use Respect\Validation\Test\Message\TestingStringFormatter;
|
|
use Respect\Validation\Test\Stubs\MyValidator;
|
|
|
|
$resultQuery = new ResultQuery(
|
|
(new ResultBuilder())->build(),
|
|
new TestingMessageRenderer(),
|
|
new TestingStringFormatter(),
|
|
new TestingStringFormatter(),
|
|
new TestingArrayFormatter(),
|
|
[],
|
|
);
|
|
|
|
test('Should overwrite file and line in the Validator class', function (): void {
|
|
try {
|
|
v::intType()->assert('string');
|
|
} catch (ValidationException $e) {
|
|
expect($e->getFile())->toBe(__FILE__);
|
|
expect($e->getLine())->toBe(__LINE__ - 3);
|
|
}
|
|
});
|
|
|
|
test('Should overwrite file and line in ValidationException', function (): void {
|
|
try {
|
|
MyValidator::assertIntType('string');
|
|
} catch (ValidationException $e) {
|
|
expect($e->getFile())->toBe(__FILE__);
|
|
expect($e->getLine())->toBe(__LINE__ - 3);
|
|
}
|
|
});
|
|
|
|
test('Should not overwrite file and line when created manually', function () use ($resultQuery): void {
|
|
try {
|
|
throw new ValidationException('message', $resultQuery);
|
|
} catch (ValidationException $e) {
|
|
expect($e->getFile())->toBe(__FILE__);
|
|
expect($e->getLine())->toBe(__LINE__ - 3);
|
|
}
|
|
});
|
|
|
|
|
|
test('Should not overwrite file and line when file cannot be ever traced', function () use ($resultQuery): void {
|
|
try {
|
|
throw new ValidationException('message', $resultQuery, '/tmp/unknown');
|
|
} catch (ValidationException $e) {
|
|
expect($e->getFile())->toBe(__FILE__);
|
|
expect($e->getLine())->toBe(__LINE__ - 3);
|
|
}
|
|
});
|
|
|
|
|
|
test('Should go not overwrite file and line when it runs out of choices', function () use ($resultQuery): void {
|
|
try {
|
|
$trace = array_unique(
|
|
array_filter(
|
|
array_map(
|
|
fn($trace) => $trace['file'] ?? null,
|
|
debug_backtrace(DEBUG_BACKTRACE_IGNORE_ARGS),
|
|
),
|
|
),
|
|
);
|
|
$trace[] = __FILE__;
|
|
|
|
throw new ValidationException('message', $resultQuery, ...$trace);
|
|
} catch (ValidationException $e) {
|
|
expect($e->getFile())->toBe(__FILE__);
|
|
expect($e->getLine())->toBe(__LINE__ - 3);
|
|
}
|
|
});
|