mirror of
https://github.com/Respect/Validation.git
synced 2026-03-17 15:50:03 +01:00
e4f2c8154aCreating a specific exception for each rule adds a painful overhead. If you want to make a custom message for your rule, you will need to create an exception and then register that exception namespace to be able to use it—all that is just for customizing the message of your rule. Having different namespaces also implies that you need to fetch the exception of the rule from another directory to change it. As Uncle Bob said, "Classes that change together belong together. Classes that are not reused together should not be grouped." This commit will drastically change this library, moving all the templates from the exceptions to the rules. Consequently, the Factory becomes much simpler, and the library gets a bit smaller, too. Signed-off-by: Henrique Moody <henriquemoody@gmail.com>
69 lines
2.2 KiB
PHP
69 lines
2.2 KiB
PHP
<?php
|
|
|
|
/*
|
|
* Copyright (c) Alexandre Gomes Gaigalas <alganet@gmail.com>
|
|
* SPDX-License-Identifier: MIT
|
|
*/
|
|
|
|
declare(strict_types=1);
|
|
|
|
namespace Respect\Validation\Exceptions;
|
|
|
|
use PHPUnit\Framework\Attributes\CoversClass;
|
|
use PHPUnit\Framework\Attributes\Group;
|
|
use PHPUnit\Framework\Attributes\Test;
|
|
use Respect\Validation\Message\Formatter;
|
|
use Respect\Validation\Message\Stringifier\KeepOriginalStringName;
|
|
use Respect\Validation\Test\TestCase;
|
|
use Respect\Validation\Validatable;
|
|
|
|
#[Group('core')]
|
|
#[CoversClass(NestedValidationException::class)]
|
|
final class NestedValidationExceptionTest extends TestCase
|
|
{
|
|
#[Test]
|
|
public function getChildrenShouldReturnExceptionAddedByAddRelated(): void
|
|
{
|
|
$composite = $this->createNestedValidationException();
|
|
$node = $this->createValidationException();
|
|
$composite->addChild($node);
|
|
self::assertCount(1, $composite->getChildren());
|
|
self::assertContainsOnly(ValidationException::class, $composite->getChildren());
|
|
}
|
|
|
|
#[Test]
|
|
public function addingTheSameInstanceShouldAddJustOneSingleReference(): void
|
|
{
|
|
$composite = $this->createNestedValidationException();
|
|
$node = $this->createValidationException();
|
|
$composite->addChild($node);
|
|
$composite->addChild($node);
|
|
$composite->addChild($node);
|
|
self::assertCount(1, $composite->getChildren());
|
|
self::assertContainsOnly(ValidationException::class, $composite->getChildren());
|
|
}
|
|
|
|
public function createNestedValidationException(): NestedValidationException
|
|
{
|
|
return new NestedValidationException(
|
|
input: 'input',
|
|
id: 'id',
|
|
params: [],
|
|
template: Validatable::TEMPLATE_STANDARD,
|
|
templates: [],
|
|
formatter: new Formatter('strval', new KeepOriginalStringName())
|
|
);
|
|
}
|
|
|
|
public function createValidationException(): ValidationException
|
|
{
|
|
return new ValidationException(
|
|
input: 'input',
|
|
id: 'id',
|
|
params: [],
|
|
template: Validatable::TEMPLATE_STANDARD,
|
|
templates: [],
|
|
formatter: new Formatter('strval', new KeepOriginalStringName())
|
|
);
|
|
}
|
|
}
|