respect-validation/tests/unit/Message/StandardFormatter/ResultCreator.php
Henrique Moody 82e0722443
Split the Formatter into different formatters
I've noticed that the `StandardFormatter` was quite bloated, which made
it difficult to maintain. Understanding what each method was doing was
quite complicated. Besides, the name "Standard" doesn't mean anything,
because it doesn't say what the implementation does.

I split the `Formatter` into two different interfaces: `StringFormatter`
and `ArrayFormatter`, and I moved some code around:

*  `StandardFormatter::main()` -> `FirstResultStringFormatter`
* `StandardFormatter::full()` -> `NestedListStringFormatter`
* `StandardFormatter::array()` -> `NestedArrayFormatter`

That opens up new ways of handling error messages, potentially
introducing features like `JsonStringFormatter` or `FlatArrayFormatter`
in the future.

While working on this, I removed a significant amount of unnecessary
code, which also improved my overall understanding of those formatters.

I'm not very happy with all the methods in `ValidatorDefaults`, but I
will refactor that later.
2025-12-19 16:20:28 +01:00

124 lines
5.1 KiB
PHP

<?php
/*
* Copyright (c) Alexandre Gomes Gaigalas <alganet@gmail.com>
* SPDX-License-Identifier: MIT
*/
declare(strict_types=1);
namespace Respect\Validation\Message\StandardFormatter;
use Respect\Validation\Result;
use Respect\Validation\Test\Builders\ResultBuilder;
trait ResultCreator
{
private static function singleLevelChildrenMessage(): Result
{
return (new ResultBuilder())->id('parent')->template('__parent_original__')
->children(
(new ResultBuilder())->id('1st')->template('__1st_original__')->build(),
(new ResultBuilder())->id('2nd')->template('__2nd_original__')->build(),
(new ResultBuilder())->id('3rd')->template('__3rd_original__')->build(),
)
->build();
}
private static function multiLevelChildrenWithSingleNestedChildMessage(): Result
{
return (new ResultBuilder())->id('parent')->template('__parent_original__')
->children(
(new ResultBuilder())->id('1st')->template('__1st_original__')->build(),
(new ResultBuilder())->id('2nd')->template('__2nd_original__')
->children(
(new ResultBuilder())->id('2nd_1st')->template('__2nd_1st_original__')->build(),
)
->build(),
(new ResultBuilder())->id('3rd')->template('__3rd_original__')->build(),
)
->build();
}
private static function multiLevelChildrenWithMultiNestedChildrenMessage(): Result
{
return (new ResultBuilder())->id('parent')->template('__parent_original__')
->children(
(new ResultBuilder())->id('1st')->template('__1st_original__')->build(),
(new ResultBuilder())
->id('2nd')
->template('__2nd_original__')
->children(
(new ResultBuilder())->id('2nd_1st')->template('__2nd_1st_original__')->build(),
(new ResultBuilder())->id('2nd_2nd')->template('__2nd_2nd_original__')->build(),
)
->build(),
(new ResultBuilder())->id('3rd')->template('__3rd_original__')->build(),
)
->build();
}
private static function singleLevelChildrenWithSameId(): Result
{
return (new ResultBuilder())->id('parent')->template('__parent_original__')
->children(
(new ResultBuilder())->id('child')->template('__1st_original__')->build(),
(new ResultBuilder())->id('child')->template('__2nd_original__')->build(),
(new ResultBuilder())->id('child')->template('__3rd_original__')->build(),
(new ResultBuilder())->id('child')->template('__4th_original__')->build(),
)
->build();
}
private static function multiLevelChildrenWithSiblingsThatHaveOnlyOneChild(): Result
{
return (new ResultBuilder())->id('parent')->template('__parent_original__')
->children(
(new ResultBuilder())->id('1st')
->template('__1st_original__')
->children(
(new ResultBuilder())
->id('1st_1st')
->template('__1st_1st_original__')
->build(),
(new ResultBuilder())
->id('1st_2nd')
->template('__1st_2nd_original__')
->build(),
)
->build(),
(new ResultBuilder())
->id('2nd')
->template('__2nd_original__')
->children(
(new ResultBuilder())->id('2nd_1st')->template('__2nd_1st_original__')->build(),
)
->build(),
)
->build();
}
private static function multiLevelChildrenWithSiblingsThatHaveMoreThanOneChild(): Result
{
return (new ResultBuilder())->id('parent')->template('__parent_original__')
->children(
(new ResultBuilder())->id('1st')
->template('__1st_original__')
->children(
(new ResultBuilder())->id('1st_1st')->template('__1st_1st_original__')->build(),
(new ResultBuilder())->id('1st_2nd')->template('__1st_2nd_original__')->build(),
)
->build(),
(new ResultBuilder())
->id('2nd')
->template('__2nd_original__')
->children(
(new ResultBuilder())->id('2nd_1st')->template('__2nd_1st_original__')->build(),
(new ResultBuilder())->id('2nd_2nd')->template('__2nd_2nd_original__')->build(),
)
->build(),
(new ResultBuilder())->id('3nd')->template('__3rd_original__')->build(),
)
->build();
}
}