mirror of
https://github.com/Respect/Validation.git
synced 2024-06-26 17:20:16 +02:00
a647a4737b
Currently, the Key rule has a third parameter that allows the validation of the wrapped rule to be optional, meaning that the validation will only happen if the key exists. That parameter makes the rule harder to understand at times. I'm splitting the Key rule into Key, KeyExists, and KeyOptional. That way, it becomes apparent when someone wants only to validate whether a key exists or if they're going to validate the value of the key only when it exists. I deliberately didn't create an abstract class because those rules are different enough not to have an abstraction. In fact, I can see myself deleting the "AbstractRelated" in the upcoming changes. With these changes, the KeySet rule will not accept validating if the key exists or validating the value only if the key exists. I should refactor that soon, and I will likely need to create a common interface for Key, KeyExists, and KeyOptional. Signed-off-by: Henrique Moody <henriquemoody@gmail.com>
36 lines
1.2 KiB
PHP
36 lines
1.2 KiB
PHP
<?php
|
|
|
|
/*
|
|
* Copyright (c) Alexandre Gomes Gaigalas <alganet@gmail.com>
|
|
* SPDX-License-Identifier: MIT
|
|
*/
|
|
|
|
declare(strict_types=1);
|
|
|
|
namespace Respect\Validation\Rules;
|
|
|
|
use PHPUnit\Framework\Attributes\CoversClass;
|
|
use PHPUnit\Framework\Attributes\Group;
|
|
use Respect\Validation\Test\Rules\Stub;
|
|
use Respect\Validation\Test\RuleTestCase;
|
|
|
|
#[Group('rule')]
|
|
#[CoversClass(KeySet::class)]
|
|
final class KeySetTest extends RuleTestCase
|
|
{
|
|
/** @return iterable<string, array{KeySet, mixed}> */
|
|
public static function providerForValidInput(): iterable
|
|
{
|
|
yield 'correct keys, with passing rule' => [new KeySet(new Key('foo', Stub::pass(1))), ['foo' => 'bar']];
|
|
}
|
|
|
|
/** @return iterable<string, array{KeySet, mixed}> */
|
|
public static function providerForInvalidInput(): iterable
|
|
{
|
|
yield 'not array' => [new KeySet(new Key('foo', Stub::daze())), null];
|
|
yield 'missing keys' => [new KeySet(new Key('foo', Stub::daze())), []];
|
|
yield 'extra keys' => [new KeySet(new Key('foo', Stub::daze())), ['foo' => 'bar', 'baz' => 'qux']];
|
|
yield 'correct keys, with failing rule' => [new KeySet(new Key('foo', Stub::fail(1))), ['foo' => 'bar']];
|
|
}
|
|
}
|