respect-validation/library/Message/StandardFormatter.php
Henrique Moody 238f2d506a
Update validation engine
There are a few "problems" with the current engine:

- Allowing each rule to execute assert() and check() means duplication
  in some cases.

- Because we use exceptions to assert/check, we can only invert a
  validation (with Not) if there are errors. That means that we have
  limited granularity control.

- There is a lot of logic in the exceptions. That means that even after
  it throws an exception, something could still happen. We're stable on
  that front, but I want to simplify them. Besides, debugging exception
  code is painful because the stack trace does not go beyond the
  exception.

Apart from that, there are many limitations with templating, and working
that out in the current implementation makes it much harder.

These changes will improve the library in many aspects, but they will
also change the behavior and break backward compatibility. However,
that's a price I'm willing to pay for the improvements we'll have.

Signed-off-by: Henrique Moody <henriquemoody@gmail.com>
2024-02-22 16:54:44 +01:00

182 lines
5.5 KiB
PHP

<?php
/*
* Copyright (c) Alexandre Gomes Gaigalas <alganet@gmail.com>
* SPDX-License-Identifier: MIT
*/
declare(strict_types=1);
namespace Respect\Validation\Message;
use Respect\Validation\Exceptions\ComponentException;
use Respect\Validation\Result;
use function array_filter;
use function array_key_exists;
use function array_values;
use function count;
use function current;
use function is_array;
use function is_string;
use function Respect\Stringifier\stringify;
use function rtrim;
use function sprintf;
use function str_repeat;
use const PHP_EOL;
final class StandardFormatter implements Formatter
{
public function __construct(
private readonly Renderer $renderer,
) {
}
/**
* @param array<string, mixed> $templates
*/
public function main(Result $result, array $templates): string
{
$selectedTemplates = $this->selectTemplates($result, $templates);
if (!$this->isFinalTemplate($result, $selectedTemplates)) {
foreach ($this->extractDeduplicatedChildren($result) as $child) {
return $this->main($child, $selectedTemplates);
}
}
return $this->renderer->render($this->getTemplated($result, $selectedTemplates));
}
/**
* @param array<string, mixed> $templates
*/
public function full(Result $result, array $templates, int $depth = 0): string
{
$selectedTemplates = $this->selectTemplates($result, $templates);
$isFinalTemplate = $this->isFinalTemplate($result, $selectedTemplates);
$rendered = '';
if ($result->isAlwaysVisible() || $isFinalTemplate) {
$indentation = str_repeat(' ', $depth * 2);
$rendered .= sprintf(
'%s- %s' . PHP_EOL,
$indentation,
$this->renderer->render($this->getTemplated($result, $selectedTemplates)),
);
$depth++;
}
if (!$isFinalTemplate) {
foreach ($this->extractDeduplicatedChildren($result) as $child) {
$rendered .= $this->full($child, $selectedTemplates, $depth);
$rendered .= PHP_EOL;
}
}
return rtrim($rendered, PHP_EOL);
}
/**
* @param array<string, mixed> $templates
*
* @return array<string, mixed>
*/
public function array(Result $result, array $templates): array
{
$selectedTemplates = $this->selectTemplates($result, $templates);
$deduplicatedChildren = $this->extractDeduplicatedChildren($result);
if (count($deduplicatedChildren) === 0 || $this->isFinalTemplate($result, $selectedTemplates)) {
return [$result->id => $this->renderer->render($this->getTemplated($result, $selectedTemplates))];
}
$messages = [];
foreach ($deduplicatedChildren as $child) {
$messages[$child->id] = $this->array($child, $this->selectTemplates($child, $selectedTemplates));
if (count($messages[$child->id]) !== 1) {
continue;
}
$messages[$child->id] = current($messages[$child->id]);
}
return $messages;
}
/** @param array<string, mixed> $templates */
private function getTemplated(Result $result, array $templates): Result
{
if ($result->hasCustomTemplate()) {
return $result;
}
if (!isset($templates[$result->id]) && isset($templates['__self__'])) {
return $result->withTemplate($templates['__self__']);
}
if (!isset($templates[$result->id])) {
return $result;
}
$template = $templates[$result->id];
if (is_string($template)) {
return $result->withTemplate($template);
}
throw new ComponentException(
sprintf('Template for "%s" must be a string, %s given', $result->id, stringify($template))
);
}
/**
* @param array<string, mixed> $templates
*/
private function isFinalTemplate(Result $result, array $templates): bool
{
if (isset($templates[$result->id]) && is_string($templates[$result->id])) {
return true;
}
if (count($templates) !== 1) {
return false;
}
return isset($templates['__self__']) || isset($templates[$result->id]);
}
/**
* @param array<string, mixed> $templates
*
* @return array<string, mixed>
*/
private function selectTemplates(Result $message, array $templates): array
{
if (isset($templates[$message->id]) && is_array($templates[$message->id])) {
return $templates[$message->id];
}
return $templates;
}
/** @return array<Result> */
private function extractDeduplicatedChildren(Result $result): array
{
/** @var array<string, Result> $deduplicatedResults */
$deduplicatedResults = [];
$duplicateCounters = [];
foreach ($result->children as $child) {
$id = $child->id;
if (isset($duplicateCounters[$id])) {
$id .= '.' . ++$duplicateCounters[$id];
} elseif (array_key_exists($id, $deduplicatedResults)) {
$deduplicatedResults[$id . '.1'] = $deduplicatedResults[$id]?->withId($id . '.1');
unset($deduplicatedResults[$id]);
$duplicateCounters[$id] = 2;
$id .= '.2';
}
$deduplicatedResults[$id] = $child->isValid ? null : $child->withId($id);
}
return array_values(array_filter($deduplicatedResults));
}
}