respect-validation/tests/unit/Rules/KeySetTest.php
Henrique Moody e4f2c8154a
Use PHP attributes to define templates
Creating a specific exception for each rule adds a painful overhead. If
you want to make a custom message for your rule, you will need to create
an exception and then register that exception namespace to be able to
use it—all that is just for customizing the message of your rule.

Having different namespaces also implies that you need to fetch the
exception of the rule from another directory to change it. As Uncle Bob
said, "Classes that change together belong together. Classes that are
not reused together should not be grouped."

This commit will drastically change this library, moving all the
templates from the exceptions to the rules. Consequently, the Factory
becomes much simpler, and the library gets a bit smaller, too.

Signed-off-by: Henrique Moody <henriquemoody@gmail.com>
2024-01-29 23:43:57 +01:00

206 lines
5.3 KiB
PHP

<?php
/*
* Copyright (c) Alexandre Gomes Gaigalas <alganet@gmail.com>
* SPDX-License-Identifier: MIT
*/
declare(strict_types=1);
namespace Respect\Validation\Rules;
use PHPUnit\Framework\Attributes\CoversClass;
use PHPUnit\Framework\Attributes\DataProvider;
use PHPUnit\Framework\Attributes\Group;
use PHPUnit\Framework\Attributes\Test;
use Respect\Validation\Exceptions\ComponentException;
use Respect\Validation\Exceptions\ValidationException;
use Respect\Validation\Test\TestCase;
use stdClass;
use function Respect\Stringifier\stringify;
use function sprintf;
#[Group('rule')]
#[CoversClass(KeySet::class)]
final class KeySetTest extends TestCase
{
#[Test]
public function shouldNotAcceptAllOfWithMoreThanOneKeyRule(): void
{
$key1 = new Key('foo', new AlwaysValid(), false);
$key2 = new Key('bar', new AlwaysValid(), false);
$allOf = new AllOf($key1, $key2);
$this->expectException(ComponentException::class);
$this->expectExceptionMessage('KeySet rule accepts only Key rules');
new KeySet($allOf);
}
#[Test]
public function shouldNotAcceptAllOfWithNonKeyRule(): void
{
$alwaysValid = new AlwaysValid();
$allOf = new AllOf($alwaysValid);
$this->expectException(ComponentException::class);
$this->expectExceptionMessage('KeySet rule accepts only Key rules');
new KeySet($allOf);
}
#[Test]
public function shouldNotAcceptNonKeyRule(): void
{
$alwaysValid = new AlwaysValid();
$this->expectException(ComponentException::class);
$this->expectExceptionMessage('KeySet rule accepts only Key rules');
new KeySet($alwaysValid);
}
#[Test]
public function shouldValidateKeysWhenThereAreMissingRequiredKeys(): void
{
$input = [
'foo' => 42,
];
$key1 = new Key('foo', new AlwaysValid(), true);
$key2 = new Key('bar', new AlwaysValid(), true);
$keySet = new KeySet($key1, $key2);
self::assertFalse($keySet->validate($input));
}
#[Test]
public function shouldValidateKeysWhenThereAreMissingNonRequiredKeys(): void
{
$input = [
'foo' => 42,
];
$key1 = new Key('foo', new AlwaysValid(), true);
$key2 = new Key('bar', new AlwaysValid(), false);
$keySet = new KeySet($key1, $key2);
self::assertTrue($keySet->validate($input));
}
#[Test]
public function shouldValidateKeysWhenThereAreMoreKeys(): void
{
$input = [
'foo' => 42,
'bar' => 'String',
'baz' => false,
];
$key1 = new Key('foo', new AlwaysValid(), false);
$key2 = new Key('bar', new AlwaysValid(), false);
$keySet = new KeySet($key1, $key2);
self::assertFalse($keySet->validate($input));
}
#[Test]
public function shouldValidateKeysWhenEmpty(): void
{
$input = [];
$key1 = new Key('foo', new AlwaysValid(), true);
$key2 = new Key('bar', new AlwaysValid(), true);
$keySet = new KeySet($key1, $key2);
self::assertFalse($keySet->validate($input));
}
#[Test]
public function shouldCheckKeys(): void
{
$input = [];
$key1 = new Key('foo', new AlwaysValid(), true);
$key2 = new Key('bar', new AlwaysValid(), true);
$keySet = new KeySet($key1, $key2);
$this->expectException(ValidationException::class);
$this->expectExceptionMessage(sprintf('Must have keys %s', stringify(['foo', 'bar'])));
$keySet->check($input);
}
#[Test]
public function shouldAssertKeys(): void
{
$input = [];
$key1 = new Key('foo', new AlwaysValid(), true);
$key2 = new Key('bar', new AlwaysValid(), true);
$keySet = new KeySet($key1, $key2);
$this->expectException(ValidationException::class);
$this->expectExceptionMessage(sprintf('Must have keys %s', stringify(['foo', 'bar'])));
$keySet->assert($input);
}
#[Test]
public function shouldWarnOfExtraKeysWithMessage(): void
{
$input = ['foo' => 123, 'bar' => 456];
$key1 = new Key('foo', new AlwaysValid(), true);
$keySet = new KeySet($key1);
$this->expectException(ValidationException::class);
$this->expectExceptionMessage(sprintf('Must not have keys %s', stringify(['bar'])));
$keySet->assert($input);
}
#[Test]
public function cannotBeNegated(): void
{
$key1 = new Key('foo', new AlwaysValid(), true);
$this->expectException(ComponentException::class);
$this->expectExceptionMessage('"Respect\Validation\Rules\KeySet" can not be wrapped in Not()');
new Not(new KeySet($key1));
}
#[Test]
#[DataProvider('providerForInvalidArguments')]
public function shouldThrowExceptionInCaseArgumentIsAnythingOtherThanArray(mixed $input): void
{
$keySet = new KeySet(new Key('name'));
$this->expectException(ValidationException::class);
$this->expectExceptionMessage(sprintf('Must have keys %s', stringify(['name'])));
$keySet->assert($input);
}
/**
* @return mixed[][]
*/
public static function providerForInvalidArguments(): array
{
return [
[''],
[null],
[0],
[new stdClass()],
];
}
}