mirror of
https://github.com/Respect/Validation.git
synced 2026-03-14 22:35:45 +01:00
ec16b3d2df
This is a mid-size refactor that affects several validators. Most prominently, the ones that had an `$identical` parameter to deal with case sensitiveness. This parameter was confusing, effectively making validators such as `Contains` behave very differently for arrays versus strings. In arrays, `$identical` meant "the same type", while it in strings it meant "case sensitive". That parameter was removed, and the default behavior is now to always compare **case sensitive** and strict typing. A document explaining how to combine other validators in order to achieve case _insensitive_ comparisons was added. Additionally, the `Call` validator was refactored back to be suitable to take on the task of being a fast, quick composable validator. With the introduction of `Circuit`, we can shift the responsibility of dealing with possible mismatches to the user. This kind of type handling is demonstrated in how I refactored `Tld` to account for the type mismatch without setting error handlers.
51 lines
1.6 KiB
PHP
51 lines
1.6 KiB
PHP
<?php
|
|
|
|
/*
|
|
* SPDX-License-Identifier: MIT
|
|
* SPDX-FileCopyrightText: (c) Respect Project Contributors
|
|
* SPDX-FileContributor: Alexandre Gomes Gaigalas <alganet@gmail.com>
|
|
* SPDX-FileContributor: Gabriel Caruso <carusogabriel34@gmail.com>
|
|
* SPDX-FileContributor: Henrique Moody <henriquemoody@gmail.com>
|
|
* SPDX-FileContributor: Nick Lombard <github@jigsoft.co.za>
|
|
* SPDX-FileContributor: Pathum Harshana De Silva <pathumhdes@gmail.com>
|
|
*/
|
|
|
|
declare(strict_types=1);
|
|
|
|
namespace Respect\Validation\Validators;
|
|
|
|
use PHPUnit\Framework\Attributes\CoversClass;
|
|
use PHPUnit\Framework\Attributes\Group;
|
|
use PHPUnit\Framework\Attributes\Test;
|
|
use Respect\Validation\Test\RuleTestCase;
|
|
use TypeError;
|
|
|
|
#[Group('validator')]
|
|
#[CoversClass(Call::class)]
|
|
final class CallTest extends RuleTestCase
|
|
{
|
|
/** @return iterable<string, array{Call, mixed}> */
|
|
public static function providerForValidInput(): iterable
|
|
{
|
|
return [
|
|
'callback true' => [new Call('strtolower', new Equals('abc')), 'ABC'],
|
|
];
|
|
}
|
|
|
|
/** @return iterable<string, array{Call, mixed}> */
|
|
public static function providerForInvalidInput(): iterable
|
|
{
|
|
return [
|
|
'callback false' => [new Call('strtolower', new Equals('abc')), 'DEF'],
|
|
];
|
|
}
|
|
|
|
#[Test]
|
|
public function shouldLetErrorsEmittedByTheChosenProvidedCallbackToBubbleUp(): void
|
|
{
|
|
$this->expectException(TypeError::class);
|
|
$this->expectExceptionMessage('strtolower(): Argument #1 ($string) must be of type string, int given');
|
|
$validator = new Call('strtolower', new Equals('abc'));
|
|
$validator->evaluate(123);
|
|
}
|
|
}
|