deblan-mirror/splitsh-lite
1
0
Fork 0
mirror of https://github.com/splitsh/lite.git synced 2024-06-01 05:12:28 +02:00
Code Issues Packages Projects Releases Wiki Activity

fix errors found by github.com/dominikh/go-tools/...

Browse source 
lite/splitter/result.go:76:15: should use time.Since instead of time.Now().Sub (S1012)
lite/splitter/state.go:433:25: should omit comparison to bool constant, can be simplified to !copyCommit (S1002)
lite/splitter/utils.go:13:25: should use raw string (`...`) with regexp.MustCompile to avoid having to escape twice (S1007)
lite/splitter/cache.go:90:17: func (*cache).reverse is unused (U1000)
This commit is contained in:
Joschka Tillmanns 2018-03-08 10:25:31 +01:00
parent cb9c28b8c3
commit 9d643aa621
4 changed files with 3 additions and 19 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

16
splitter/cache.go
View file

@ -86,22 +86,6 @@ func (c *cache) getHead() *git.Oid {
return oid
}
// which is newest or oldest
func (c *cache) reverse(rev *git.Oid, which string) *git.Oid {
var oid *git.Oid
c.db.View(func(tx *bolt.Tx) error {
result := tx.Bucket(c.key).Get(append(rev[0:20], []byte("/"+which)...))
if result == nil && which == "newest" {
result = tx.Bucket(c.key).Get(append(rev[0:20], []byte("/oldest")...))
}
if result != nil {
oid = git.NewOidFromBytes(result)
}
return nil
})
return oid
}
func (c *cache) get(rev *git.Oid) *git.Oid {
var oid *git.Oid
c.db.View(func(tx *bolt.Tx) error {

2
splitter/result.go
View file

@ -73,7 +73,7 @@ func (r *Result) incTraversed() {
func (r *Result) end(start time.Time) {
r.mu.Lock()
r.duration = time.Now().Sub(start)
r.duration = time.Since(start)
r.mu.Unlock()
}

2
splitter/state.go
View file

@ -430,7 +430,7 @@ func (s *state) copyOrSkip(rev *git.Commit, tree *git.Tree, newParents []*git.Oi
revWalk.Free()
}
if nil != identical && copyCommit == false {
if nil != identical && !copyCommit {
return identical, false, nil
}

2
splitter/utils.go
View file

@ -10,7 +10,7 @@ import (
"github.com/libgit2/git2go"
)
var messageNormalizer = regexp.MustCompile("\\s*\\r?\\n")
var messageNormalizer = regexp.MustCompile(`\s*\r?\n`)
// GitDirectory returns the .git directory for a given directory
func GitDirectory(path string) string {