From 21c6abdd1d9e7ab09612250857ea418beb2885ec Mon Sep 17 00:00:00 2001 From: John Sullivan Date: Mon, 18 Oct 2021 23:20:11 -0700 Subject: [PATCH] Clarify description of prefetchMaxSearchSize. (#4338) This is a comments only change that fixes two problems: 1. The previous comment described it as limiting request size, but it instead limits the response size. 2. Previously it was unclear _why_ this size was significant. It wasn't obvious to me that the entire response would be stored in memory. --- defaults/config.js | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/defaults/config.js b/defaults/config.js index 390f732d..691d5e65 100644 --- a/defaults/config.js +++ b/defaults/config.js @@ -152,8 +152,9 @@ module.exports = { // ### prefetchMaxSearchSize // - // This value sets the maximum request size made to find the Open Graph tags - // for link previews. For some sites like YouTube this can easily exceed 300 + // This value sets the maximum response size allowed when finding the Open + // Graph tags for link previews. The entire response is temporarily stored + // in memory and for some sites like YouTube this can easily exceed 300 // kilobytes. // // This value is set to `50` kilobytes by default.