From 64cc4927b34dad2dea7f3e9cf614eb3e331aa66b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?J=C3=A9r=C3=A9mie=20Astori?= Date: Sun, 17 Sep 2017 21:50:41 -0400 Subject: [PATCH] Make sure we never ship with JS alerts by accident --- .eslintrc.yml | 1 + client/js/lounge.js | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/.eslintrc.yml b/.eslintrc.yml index eb14e6de..5d79006a 100644 --- a/.eslintrc.yml +++ b/.eslintrc.yml @@ -26,6 +26,7 @@ rules: key-spacing: [2, {beforeColon: false, afterColon: true}] keyword-spacing: [2, {before: true, after: true}] linebreak-style: [2, unix] + no-alert: 2 no-catch-shadow: 2 no-confusing-arrow: 2 no-control-regex: 0 diff --git a/client/js/lounge.js b/client/js/lounge.js index f69a6e12..3aa7ebc9 100644 --- a/client/js/lounge.js +++ b/client/js/lounge.js @@ -418,7 +418,7 @@ $(function() { if (chan.hasClass("lobby")) { cmd = "/quit"; var server = chan.find(".name").html(); - if (!confirm("Disconnect from " + server + "?")) { + if (!confirm("Disconnect from " + server + "?")) { // eslint-disable-line no-alert return false; } }