Rename uploadCanvas to a more appropriate removeImageMetadata

Including backwards compatibility

client/components/Windows/Settings.vue

@@ -242,15 +242,14 @@
 				<div>
 					<label class="opt">
 						<input
-							:checked="$store.state.settings.uploadCanvas"
+							:checked="$store.state.settings.removeImageMetadata"
 							type="checkbox"
-							name="uploadCanvas"
+							name="removeImageMetadata"
 						/>
 						Attempt to remove metadata from images before uploading
 						<span
 							class="tooltipped tooltipped-n tooltipped-no-delay"
-							aria-label="This option renders the image into a canvas element to remove metadata from the image.
+							aria-label="This option will removes metadata from images and animated wepb files. This may break the images orientation."
-This may break orientation if your browser does not support that."
 						>
 							<button class="extra-help" />
 						</span>

client/js/settings.js

@@ -98,7 +98,7 @@ export const config = normalizeConfig({
 	media: {
 		default: true,
 	},
-	uploadCanvas: {
+	removeImageMetadata: {
 		default: true,
 	},
 	userStyles: {

client/js/store-settings.js

@@ -86,6 +86,15 @@ function loadFromLocalStorage() {
 		storedSettings.highlights = storedSettings.highlights.join(", ");
 	}
 
+	// Convert deprecated uploadCanvas to removeImageMetadata
+	if (
+		storedSettings.uploadCanvas !== undefined &&
+		storedSettings.removeImageMetadata === undefined
+	) {
+		storedSettings.removeImageMetadata = storedSettings.uploadCanvas;
+		delete storedSettings.uploadCanvas;
+	}
+
 	return storedSettings;
 }
 

src/client.js

@@ -102,6 +102,11 @@ function Client(manager, name, config = {}) {
 		delete client.config.awayMessage;
 	}
 
+	if (client.config.uploadCanvas) {
+		client.config.clientSettings.removeImageMetadata = client.config.uploadCanvas;
+		delete client.config.uploadCanvas;
+	}
+
 	if (client.config.clientSettings.awayMessage) {
 		client.awayMessage = client.config.clientSettings.awayMessage;
 	}