From 2451f222e845c6ade8fba3d5d88aab89a722ac64 Mon Sep 17 00:00:00 2001 From: Pavel Djundik Date: Fri, 24 Jan 2020 11:32:28 +0200 Subject: [PATCH 1/2] Bind esc key handler once Fixes #3690 --- client/components/App.vue | 5 +++++ client/components/ContextMenu.vue | 7 ++----- client/components/ImageViewer.vue | 6 ++---- 3 files changed, 9 insertions(+), 9 deletions(-) diff --git a/client/components/App.vue b/client/components/App.vue index cd378127..3133101f 100644 --- a/client/components/App.vue +++ b/client/components/App.vue @@ -44,6 +44,7 @@ export default { this.prepareOpenStates(); }, mounted() { + Mousetrap.bind("esc", this.escapeKey); Mousetrap.bind("alt+u", this.toggleUserList); Mousetrap.bind("alt+s", this.toggleSidebar); @@ -64,6 +65,7 @@ export default { this.dayChangeTimeout = setTimeout(emitDayChange, this.msUntilNextDay()); }, beforeDestroy() { + Mousetrap.unbind("esc", this.escapeKey); Mousetrap.unbind("alt+u", this.toggleUserList); Mousetrap.unbind("alt+s", this.toggleSidebar); @@ -71,6 +73,9 @@ export default { clearTimeout(this.dayChangeTimeout); }, methods: { + escapeKey() { + this.$root.$emit("escapekey"); + }, toggleSidebar(e) { // Do not handle this keybind in the chat input because // it can be used to type letters with umlauts diff --git a/client/components/ContextMenu.vue b/client/components/ContextMenu.vue index 75b484f2..f060bb0d 100644 --- a/client/components/ContextMenu.vue +++ b/client/components/ContextMenu.vue @@ -38,7 +38,6 @@