From cebc6d069fa609de918881854414768fadc87fed Mon Sep 17 00:00:00 2001
From: Reto Brunner <reto@labrat.space>
Date: Sat, 27 Aug 2022 11:03:49 +0200
Subject: [PATCH] sqlite: error if sqlite isn't enabled but search() is called

When we assert that something can't possibly happen, we better
error out rather than jugging on with no error ;)
---
 server/plugins/messageStorage/sqlite.ts | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/server/plugins/messageStorage/sqlite.ts b/server/plugins/messageStorage/sqlite.ts
index f2a3b526..568d5256 100644
--- a/server/plugins/messageStorage/sqlite.ts
+++ b/server/plugins/messageStorage/sqlite.ts
@@ -213,10 +213,12 @@ class SqliteMessageStorage implements ISqliteMessageStorage {
 		}) as Promise<Message[]>;
 	}
 
-	search(query: SearchQuery): Promise<SearchResponse | []> {
+	search(query: SearchQuery): Promise<SearchResponse> {
 		if (!this.isEnabled) {
 			// this should never be hit as messageProvider is checked in client.search()
-			return Promise.resolve([]);
+			return Promise.reject(
+				"search called but sqlite provider not enabled. This is a programming error"
+			);
 		}
 
 		// Using the '@' character to escape '%' and '_' in patterns.