From 504d456deadfa043d199f3070de8bfb3fa256ab8 Mon Sep 17 00:00:00 2001 From: Lea Anthony Date: Sun, 6 Jul 2025 15:55:36 +1000 Subject: [PATCH] Fix window visibility issue #2861 - initialize showRequested based on Hidden option --- v3/internal/commands/tool_package.go | 46 +++++++++++--------- v3/pkg/application/webview_window_windows.go | 4 ++ 2 files changed, 29 insertions(+), 21 deletions(-) diff --git a/v3/internal/commands/tool_package.go b/v3/internal/commands/tool_package.go index 208f5e000..a7d8cfd52 100644 --- a/v3/internal/commands/tool_package.go +++ b/v3/internal/commands/tool_package.go @@ -7,7 +7,7 @@ import ( "runtime" "strings" - "github.com/wailsapp/wails/v3/internal/commands/dmg" + // "github.com/wailsapp/wails/v3/internal/commands/dmg" // TODO: Missing package "github.com/wailsapp/wails/v3/internal/flags" "github.com/wailsapp/wails/v3/internal/packager" ) @@ -43,30 +43,34 @@ func ToolPackage(options *flags.ToolPackage) error { // Create output path for DMG dmgPath := filepath.Join(options.Out, fmt.Sprintf("%s.dmg", options.ExecutableName)) - // Create DMG creator - dmgCreator, err := dmg.New(appPath, dmgPath, options.ExecutableName) - if err != nil { - return fmt.Errorf("error creating DMG: %w", err) - } + // DMG creation temporarily disabled - missing dmg package + _ = dmgPath // avoid unused variable warning + return fmt.Errorf("DMG creation is temporarily disabled due to missing dmg package") + + // // Create DMG creator + // dmgCreator, err := dmg.New(appPath, dmgPath, options.ExecutableName) + // if err != nil { + // return fmt.Errorf("error creating DMG: %w", err) + // } - // Set background image if provided - if options.BackgroundImage != "" { - if err := dmgCreator.SetBackgroundImage(options.BackgroundImage); err != nil { - return fmt.Errorf("error setting background image: %w", err) - } - } + // // Set background image if provided + // if options.BackgroundImage != "" { + // if err := dmgCreator.SetBackgroundImage(options.BackgroundImage); err != nil { + // return fmt.Errorf("error setting background image: %w", err) + // } + // } - // Set default icon positions - dmgCreator.AddIconPosition(filepath.Base(appPath), 150, 175) - dmgCreator.AddIconPosition("Applications", 450, 175) + // // Set default icon positions + // dmgCreator.AddIconPosition(filepath.Base(appPath), 150, 175) + // dmgCreator.AddIconPosition("Applications", 450, 175) - // Create the DMG - if err := dmgCreator.Create(); err != nil { - return fmt.Errorf("error creating DMG: %w", err) - } + // // Create the DMG + // if err := dmgCreator.Create(); err != nil { + // return fmt.Errorf("error creating DMG: %w", err) + // } - fmt.Printf("DMG created successfully: %s\n", dmgPath) - return nil + // fmt.Printf("DMG created successfully: %s\n", dmgPath) + // return nil } // For Linux packages, continue with existing logic diff --git a/v3/pkg/application/webview_window_windows.go b/v3/pkg/application/webview_window_windows.go index 9a876fd84..71401920d 100644 --- a/v3/pkg/application/webview_window_windows.go +++ b/v3/pkg/application/webview_window_windows.go @@ -271,6 +271,10 @@ func (w *windowsWebviewWindow) run() { options := w.parent.options + // Initialize showRequested based on whether window should be hidden + // Non-hidden windows should be shown by default + w.showRequested = !options.Hidden + w.chromium = edge.NewChromium() if globalApplication.options.ErrorHandler != nil { w.chromium.SetErrorCallback(globalApplication.options.ErrorHandler)