From 6fcf2d6210604ea7a526dbcd2c6dc3f83b46c7c2 Mon Sep 17 00:00:00 2001 From: Lea Anthony Date: Mon, 9 Feb 2026 21:41:54 +1100 Subject: [PATCH] docs: fix issues from PR review comments MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit - menus.mdx: add Update() call after adding items to context menu snippet - application.mdx: fix Emit() signature — remove fabricated bool return - events-reference.mdx: fix files-dropped JS example to account for variadic wrapping (event.data[0] is the files array) - bridge.mdx: fix progress event example — use variadic args directly and destructure event.data array in JS Co-Authored-By: Claude Opus 4.6 --- docs/src/content/docs/concepts/bridge.mdx | 9 ++++----- docs/src/content/docs/guides/events-reference.mdx | 5 ++++- docs/src/content/docs/guides/menus.mdx | 6 ++++++ docs/src/content/docs/reference/application.mdx | 4 +--- 4 files changed, 15 insertions(+), 9 deletions(-) diff --git a/docs/src/content/docs/concepts/bridge.mdx b/docs/src/content/docs/concepts/bridge.mdx index 69a2c1f0b..0773dc374 100644 --- a/docs/src/content/docs/concepts/bridge.mdx +++ b/docs/src/content/docs/concepts/bridge.mdx @@ -538,10 +538,7 @@ func ProcessLargeFile(path string) error { for scanner.Scan() { lineNum++ // Emit progress events - app.Event.Emit("file-progress", map[string]interface{}{ - "line": lineNum, - "text": scanner.Text(), - }) + app.Event.Emit("file-progress", lineNum, scanner.Text()) } return scanner.Err() @@ -553,8 +550,10 @@ import { Events } from '@wailsio/runtime' import { ProcessLargeFile } from './bindings/FileService' // Listen for progress +// event.data is an array of the variadic args: [lineNum, text] Events.On('file-progress', (event) => { - console.log(`Line ${event.data.line}: ${event.data.text}`) + const [line, text] = event.data + console.log(`Line ${line}: ${text}`) }) // Start processing diff --git a/docs/src/content/docs/guides/events-reference.mdx b/docs/src/content/docs/guides/events-reference.mdx index b1d76778e..d0081d9db 100644 --- a/docs/src/content/docs/guides/events-reference.mdx +++ b/docs/src/content/docs/guides/events-reference.mdx @@ -214,7 +214,10 @@ Then listen in JavaScript: import { Events } from '@wailsio/runtime'; Events.On('files-dropped', (event) => { - event.data.forEach(file => { + // EmitEvent is variadic, so event.data is a []any wrapping the args. + // The files array is the first element. + const files = event.data[0]; + files.forEach(file => { console.log('File dropped:', file); handleFileUpload(file); }); diff --git a/docs/src/content/docs/guides/menus.mdx b/docs/src/content/docs/guides/menus.mdx index 9969acb5d..01097fe9e 100644 --- a/docs/src/content/docs/guides/menus.mdx +++ b/docs/src/content/docs/guides/menus.mdx @@ -436,6 +436,12 @@ When creating a custom context menu, you provide a unique identifier (name) that ```go // Create a context menu with identifier "imageMenu" contextMenu := application.NewContextMenu("imageMenu") + +// Add items and call Update() to apply changes +contextMenu.Add("Cut") +contextMenu.Add("Copy") +contextMenu.Add("Paste") +contextMenu.Update() ``` The name parameter ("imageMenu" in this example) serves as a unique identifier that will be used to: diff --git a/docs/src/content/docs/reference/application.mdx b/docs/src/content/docs/reference/application.mdx index bf3443d41..25257a45d 100644 --- a/docs/src/content/docs/reference/application.mdx +++ b/docs/src/content/docs/reference/application.mdx @@ -347,11 +347,9 @@ app.RegisterService(application.NewService(&MyService{})) Emits a custom event. ```go -func (em *EventManager) Emit(name string, data ...any) bool +func (em *EventManager) Emit(name string, data ...any) ``` -**Returns:** `true` if the event was cancelled by a hook. - **Example:** ```go