From a9c031155a4b524e5309c539c1e28d2f033faa82 Mon Sep 17 00:00:00 2001 From: yulesxoxo <189644144+yulesxoxo@users.noreply.github.com> Date: Wed, 16 Apr 2025 15:22:05 +0200 Subject: [PATCH 1/2] fix: correct Windows filename in generate:icons task --- v3/cmd/wails3/README.md | 12 ++++++------ .../file-association/build/Taskfile.common.yml | 2 +- 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/v3/cmd/wails3/README.md b/v3/cmd/wails3/README.md index 91ecdafeb..8924153dd 100644 --- a/v3/cmd/wails3/README.md +++ b/v3/cmd/wails3/README.md @@ -21,13 +21,13 @@ It can be used to generate many things including: The `icon` command generates icons for your project. -| Flag | Type | Description | Default | -|--------------------|--------|------------------------------------------------------|-----------------------| -| `-example` | bool | Generates example icon file (appicon.png) | | -| `-input` | string | The input image file | | +| Flag | Type | Description | Default | +|--------------------|--------|------------------------------------------------------|----------------------| +| `-example` | bool | Generates example icon file (appicon.png) | | +| `-input` | string | The input image file | | | `-sizes` | string | The sizes to generate in .ico file (comma separated) | "256,128,64,48,32,16" | -| `-windowsFilename` | string | The output filename for the Windows icon | icons.ico | -| `-macFilename` | string | The output filename for the Mac icon bundle | icons.icns | +| `-windowsFilename` | string | The output filename for the Windows icon | icon.ico | +| `-macFilename` | string | The output filename for the Mac icon bundle | icons.icns | ```bash wails3 generate icon -input myicon.png -sizes "32,64,128" -windowsFilename myicon.ico -macFilename myicon.icns diff --git a/v3/examples/file-association/build/Taskfile.common.yml b/v3/examples/file-association/build/Taskfile.common.yml index 2b8a4d26d..650c8ea83 100644 --- a/v3/examples/file-association/build/Taskfile.common.yml +++ b/v3/examples/file-association/build/Taskfile.common.yml @@ -56,7 +56,7 @@ tasks: - "appicon.png" generates: - "icons.icns" - - "icons.ico" + - "icon.ico" cmds: - wails3 generate icons -input appicon.png From b3cd25cb4abf9dceabc151ad01dcdc86294ecc0a Mon Sep 17 00:00:00 2001 From: yulesxoxo <189644144+yulesxoxo@users.noreply.github.com> Date: Wed, 16 Apr 2025 15:27:05 +0200 Subject: [PATCH 2/2] feat: update changelog --- docs/src/content/docs/changelog.mdx | 1 + 1 file changed, 1 insertion(+) diff --git a/docs/src/content/docs/changelog.mdx b/docs/src/content/docs/changelog.mdx index 681e3715f..4b399a8db 100644 --- a/docs/src/content/docs/changelog.mdx +++ b/docs/src/content/docs/changelog.mdx @@ -115,6 +115,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 - Fixed icon generation paths by [@robin-samuel](https://github.com/robin-samuel) in [#4125](https://github.com/wailsapp/wails/pull/4125) - Fixed Dialogs runtime function returning escaped paths on Windows by [TheGB0077](https://github.com/TheGB0077) in [#4188](https://github.com/wailsapp/wails/pull/4188) - Fixed Webview2 detection path in HKCU by [@leaanthony](https://github.com/leaanthony). +- Fixed Windows icon generation task file name by [@yulesxoxo](https://github.com/yulesxoxo) in [#4219](https://github.com/wailsapp/wails/pull/4219). ### Changed