From 77b8132591e68567f11788483d184d5bdddc4ff4 Mon Sep 17 00:00:00 2001 From: Etesam Date: Fri, 27 Sep 2024 01:26:33 -0400 Subject: [PATCH] Updated `Id` type to `ID` for `Screen` (#3779) * :label: Updated `Id` type to `ID` for `Screen` * :memo: Updated changelog --- mkdocs-website/docs/en/changelog.md | 3 ++- .../runtime/desktop/@wailsio/runtime/src/screens.js | 9 +++------ .../runtime/desktop/@wailsio/runtime/types/screens.d.ts | 2 +- 3 files changed, 6 insertions(+), 8 deletions(-) diff --git a/mkdocs-website/docs/en/changelog.md b/mkdocs-website/docs/en/changelog.md index 99231f19c..77ef63f2e 100644 --- a/mkdocs-website/docs/en/changelog.md +++ b/mkdocs-website/docs/en/changelog.md @@ -20,12 +20,13 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 ### Changed - Taskfile refactor by [leaanthony](https://github.com/leaanthony) in [#3748](https://github.com/wailsapp/wails/pull/3748) - Upgrade to `go-webview2` v1.0.16 by [leaanthony](https://github.com/leaanthony) +- Fixed `Screen` type to include `ID` not `Id` by [etesam913](https://github.com/etesam913) in [#3778](https://github.com/wailsapp/wails/pull/3778) ## v3.0.0-alpha.7 - 2024-09-18 ### Added - [windows] New DIP system for Enhanced High DPI Monitor Support by [mmghv](https://github.com/mmghv) in [#3665](https://github.com/wailsapp/wails/pull/3665) -- [windows] Window class name option by [windom](https://github.com/windom/) in [#3682](https://github.com/wailsapp/wails/pull/3682) +- [windows] Window class name option by [windom](https://github.com/windom/) in [#3682](https://github.com/wailsapp/wails/pull/3682) - Services have been expanded to provide plugin functionality. By [atterpac](https://github.com/atterpac) and [leaanthony](https://github.com/leaanthony) in [#3570](https://github.com/wailsapp/wails/pull/3570) ### Changed diff --git a/v3/internal/runtime/desktop/@wailsio/runtime/src/screens.js b/v3/internal/runtime/desktop/@wailsio/runtime/src/screens.js index 43a5dc50b..97fc2af02 100644 --- a/v3/internal/runtime/desktop/@wailsio/runtime/src/screens.js +++ b/v3/internal/runtime/desktop/@wailsio/runtime/src/screens.js @@ -16,7 +16,6 @@ The electron alternative for Go * @property {number} Height - The height. */ - /** * @typedef {Object} Rect * @property {number} X - The X coordinate of the origin. @@ -25,10 +24,9 @@ The electron alternative for Go * @property {number} Height - The height of the rectangle. */ - /** * @typedef {Object} Screen - * @property {string} Id - Unique identifier for the screen. + * @property {string} ID - Unique identifier for the screen. * @property {string} Name - Human readable name of the screen. * @property {number} ScaleFactor - The scale factor of the screen (DPI/96). 1 = standard DPI, 2 = HiDPI (Retina), etc. * @property {number} X - The X coordinate of the screen. @@ -42,9 +40,8 @@ The electron alternative for Go * @property {number} Rotation - The rotation of the screen. */ - -import {newRuntimeCallerWithID, objectNames} from "./runtime"; -const call = newRuntimeCallerWithID(objectNames.Screens, ''); +import { newRuntimeCallerWithID, objectNames } from "./runtime"; +const call = newRuntimeCallerWithID(objectNames.Screens, ""); const getAll = 0; const getPrimary = 1; diff --git a/v3/internal/runtime/desktop/@wailsio/runtime/types/screens.d.ts b/v3/internal/runtime/desktop/@wailsio/runtime/types/screens.d.ts index 2dcba940f..7409875db 100644 --- a/v3/internal/runtime/desktop/@wailsio/runtime/types/screens.d.ts +++ b/v3/internal/runtime/desktop/@wailsio/runtime/types/screens.d.ts @@ -46,7 +46,7 @@ export type Screen = { /** * - Unique identifier for the screen. */ - Id: string; + ID: string; /** * - Human readable name of the screen. */