From 0466bc69366291332743cb7ae2bf01a82361f32d Mon Sep 17 00:00:00 2001 From: Michael <80940180+michael-freling@users.noreply.github.com> Date: Sun, 1 Dec 2024 13:47:24 -0800 Subject: [PATCH 1/2] [v3 alpha] Fix deadlock of linux dialog for multiple selections --- v3/pkg/application/linux_cgo.go | 1 + 1 file changed, 1 insertion(+) diff --git a/v3/pkg/application/linux_cgo.go b/v3/pkg/application/linux_cgo.go index ac9465b9d..4966769f7 100644 --- a/v3/pkg/application/linux_cgo.go +++ b/v3/pkg/application/linux_cgo.go @@ -1678,6 +1678,7 @@ func runChooserDialog(window pointer, allowMultiple, createFolders, showHidden b count++ } } + close(selections) }() }) C.gtk_widget_destroy((*C.GtkWidget)(unsafe.Pointer(fc))) From 7b4befb0b185b757495645334610538a3c315faf Mon Sep 17 00:00:00 2001 From: Michael <80940180+michael-freling@users.noreply.github.com> Date: Sun, 1 Dec 2024 14:40:51 -0800 Subject: [PATCH 2/2] [v3-alpha] Update a changelog --- mkdocs-website/docs/en/changelog.md | 1 + 1 file changed, 1 insertion(+) diff --git a/mkdocs-website/docs/en/changelog.md b/mkdocs-website/docs/en/changelog.md index c0913a9de..4cbc82f43 100644 --- a/mkdocs-website/docs/en/changelog.md +++ b/mkdocs-website/docs/en/changelog.md @@ -46,6 +46,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 - Systray dialog now defaults to the application icon if available (Windows) by [@leaanthony](https://github.com/leaanthony) ### Fixed +- Fixed deadlock in Linux dialog for multiple selections caused by unclosed channel variable by @michael-freling in [#3925](https://github.com/wailsapp/wails/pull/3925) - Fixed cross-platform cleanup for .syso files during Windows build by [ansxuman](https://github.com/ansxuman) in [#3924](https://github.com/wailsapp/wails/pull/3924) - Fixed amd64 appimage compile by @atterpac in [#3898](https://github.com/wailsapp/wails/pull/3898) - Fixed build assets update by @ansxuman in [#3901](https://github.com/wailsapp/wails/pull/3901)