From 8a5287794ede81bfeb596660a64f02a424ab0986 Mon Sep 17 00:00:00 2001 From: Steve Chung Date: Wed, 21 Jul 2021 17:22:07 -0400 Subject: [PATCH] handle inline javascript in assetbundle.go --- v2/internal/html/assetbundle.go | 2 +- v2/internal/html/assetbundle_test.go | 11 +++++++++++ v2/internal/html/testdata/inline_javascript.html | 15 +++++++++++++++ 3 files changed, 27 insertions(+), 1 deletion(-) create mode 100644 v2/internal/html/testdata/inline_javascript.html diff --git a/v2/internal/html/assetbundle.go b/v2/internal/html/assetbundle.go index 0079f2b85..6ec098c7e 100644 --- a/v2/internal/html/assetbundle.go +++ b/v2/internal/html/assetbundle.go @@ -137,7 +137,7 @@ func (a *AssetBundle) processHTML(htmldata string) error { break } } - if !paths.Contains(asset.Path) { + if !paths.Contains(asset.Path) && asset.Path != "" { err := asset.Load(a.basedirectory) if err != nil { return err diff --git a/v2/internal/html/assetbundle_test.go b/v2/internal/html/assetbundle_test.go index bbd70eaa4..d1009d7ac 100644 --- a/v2/internal/html/assetbundle_test.go +++ b/v2/internal/html/assetbundle_test.go @@ -44,6 +44,17 @@ func TestNewAssetBundle(t *testing.T) { }, wantErr: false, }, + { + name: "inline javascript", + pathToHTML: "testdata/inline_javascript.html", + wantAssets: []string{ + AssetTypes.HTML, + AssetTypes.FAVICON, + AssetTypes.JS, + AssetTypes.CSS, + }, + wantErr: false, + }, } for _, tt := range tests { t.Run(tt.name, func(t *testing.T) { diff --git a/v2/internal/html/testdata/inline_javascript.html b/v2/internal/html/testdata/inline_javascript.html new file mode 100644 index 000000000..4f97b75a9 --- /dev/null +++ b/v2/internal/html/testdata/inline_javascript.html @@ -0,0 +1,15 @@ + + + + + + + + + Vite App + + + +
+ +