From b37cdf5ba9ddedb614733cb474a40b2278742bcb Mon Sep 17 00:00:00 2001 From: Anshuman <43794060+ansxuman@users.noreply.github.com> Date: Mon, 2 Dec 2024 15:09:00 +0530 Subject: [PATCH] [v3] fix: Add cross-platform cleanup for .syso files during Windows build (#3924) * fix: Add cross-platform cleanup for .syso files during Windows build * Updated changelog --- mkdocs-website/docs/en/changelog.md | 1 + v3/internal/commands/build_assets/Taskfile.windows.yml | 5 ++++- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/mkdocs-website/docs/en/changelog.md b/mkdocs-website/docs/en/changelog.md index 166f4a09a..55106f401 100644 --- a/mkdocs-website/docs/en/changelog.md +++ b/mkdocs-website/docs/en/changelog.md @@ -45,6 +45,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 - Consolidated dev config into `config.yml` by [leaanthony](https://github.com/leaanthony) ### Fixed +- Fixed cross-platform cleanup for .syso files during Windows build by [ansxuman](https://github.com/ansxuman) in [#3924](https://github.com/wailsapp/wails/pull/3924) - Fixed amd64 appimage compile by @atterpac in [#3898](https://github.com/wailsapp/wails/pull/3898) - Fixed build assets update by @ansxuman in [#3901](https://github.com/wailsapp/wails/pull/3901) - Fixed Linux systray `OnClick` and `OnRightClick` implementation by @atterpac in [#3886](https://github.com/wailsapp/wails/pull/3886) diff --git a/v3/internal/commands/build_assets/Taskfile.windows.yml b/v3/internal/commands/build_assets/Taskfile.windows.yml index c893f1cc1..23f64fb91 100644 --- a/v3/internal/commands/build_assets/Taskfile.windows.yml +++ b/v3/internal/commands/build_assets/Taskfile.windows.yml @@ -13,7 +13,10 @@ tasks: - task: generate:syso cmds: - go build {{.BUILD_FLAGS}} -o {{.BIN_DIR}}/{{.APP_NAME}}.exe - - powershell Remove-item *.syso + - cmd: powershell Remove-item *.syso + platforms: [windows] + - cmd: rm -f *.syso + platforms: [linux, darwin] vars: BUILD_FLAGS: '{{if eq .PRODUCTION "true"}}-tags production -trimpath -ldflags="-w -s -H windowsgui"{{else}}-gcflags=all="-l"{{end}}' env: