mirror of
https://github.com/wailsapp/wails.git
synced 2026-03-16 07:35:51 +01:00
25 commits
| Author | SHA1 | Message | Date | |
|---|---|---|---|---|
Lea Anthony
|
5dc3e21699 |
feat(linux): GTK4 + WebKitGTK 6.0 support (opt-in via -tags gtk4) (#4958)
* chore: add WebKitGTK 6.0/GTK4 epic and beads issue tracking
Initialize beads (bd) issue tracker with comprehensive epic for
WebKitGTK 6.0 / GTK4 support as the new default for Wails v3 Linux.
Epic: wails-webview2gtk6-t4e (40 tasks)
- GTK4/WebKit6 as default (no build tag needed)
- GTK3/WebKit4.1 via -tags gtk3 for legacy
- Docker container with both library sets for cross-compilation
- Comprehensive test strategy including benchmarks
- task build:linux (GTK4) and task build:linux:gtk3 (legacy)
* feat(linux): add WebKitGTK 6.0 / GTK4 support infrastructure [WIP]
Architecture change for modern Linux desktop support:
- GTK4/WebKitGTK 6.0 is the new DEFAULT (no build tag)
- GTK3/WebKit2GTK 4.1 is LEGACY (requires -tags gtk3)
Changes:
- Add gtk3 build constraint to existing GTK3 CGO files
- Create GTK4 stub implementations (linux_cgo_gtk4.go, application_linux_gtk4.go)
- Create WebKitGTK 6.0 asset server stubs (webkit6.go, request/responsewriter)
Known limitations (documented):
- Window positioning is NO-OP on GTK4/Wayland (protocol limitation)
- Menu system needs GMenu/GAction rewrite (stub only)
- Some methods have TODO markers for full implementation
This establishes the build infrastructure for GTK4 support.
Full implementation requires GTK4 dev environment for testing.
* docs: add implementation tracker for WebKitGTK 6.0/GTK4 work
- Create IMPLEMENTATION.md to track progress, decisions, and API differences
- Update AGENTS.md with instructions to maintain IMPLEMENTATION.md
- Document Phase 1 completion and remaining phases
* feat(linux): update doctor and capabilities for GTK4/WebKitGTK 6.0 support
- Update all 7 package managers (apt, dnf, pacman, zypper, emerge, eopkg, nixpkgs)
to check for GTK4/WebKitGTK 6.0 as primary dependencies
- Mark GTK3/WebKit2GTK packages as optional/legacy
- Add GTKVersion and WebKitVersion fields to Capabilities struct
- Create capabilities_linux_gtk3.go for legacy build path
- Update IMPLEMENTATION.md to mark Phase 2 complete
GTK4 packages are now checked by default. Legacy GTK3 packages
are marked optional and only needed when building with -tags gtk3.
* feat(linux): implement GTK4 window management and event handling
- Add GtkEventController-based event handling for GTK4:
- GtkEventControllerFocus for focus in/out
- GtkGestureClick for button press/release
- GtkEventControllerKey for keyboard events
- Implement window drag/resize using GdkToplevel API
- Add complete drag-and-drop support with GtkDropTarget
- Fix window state detection (minimized, maximized, fullscreen)
- Fix size() to properly return window dimensions in GTK4
- Update IMPLEMENTATION.md to mark Phase 3 complete
GTK4 uses a fundamentally different event model with controllers
instead of direct signal handlers. This commit implements all the
necessary event handling for window management.
* feat(linux): implement GTK4 menu system with GMenu/GAction
Phase 4 of WebKitGTK 6.0/GTK4 implementation.
GTK4 completely replaces the menu system. GTK3's GtkMenu/GtkMenuItem
are replaced by:
- GMenu: Menu model (data structure, not a widget)
- GMenuItem: Individual menu item in the model
- GSimpleAction: Action triggered when menu item is activated
- GSimpleActionGroup: Container for actions, attached to widgets
- GtkPopoverMenuBar: Menu bar widget created from GMenu model
Key changes:
- linux_cgo_gtk4.go: Added C helpers and Go functions for GMenu/GAction
- menuActionActivated() callback for action triggers
- menuItemNewWithId/menuCheckItemNewWithId/menuRadioItemNewWithId
- set_action_enabled/set_action_state for state management
- menu_linux_gtk4.go: GTK4 menu processing (processMenu, addMenuItem)
- menuitem_linux_gtk4.go: GTK4 menu item handling and role menus
- menu_linux.go: Added gtk3 build tag
- menuitem_linux.go: Added gtk3 build tag
Deferred to future work:
- Context menus with GtkPopoverMenu
- Keyboard accelerators with GtkShortcut
* feat(linux): add missing CGO exports for GTK4 asset server
Phase 5 of WebKitGTK 6.0/GTK4 implementation.
The GTK4 CGO file was missing two critical exports that existed in the
GTK3 version:
1. onProcessRequest - Handles WebKit URI scheme requests. This callback
is registered with webkit_web_context_register_uri_scheme and routes
asset requests to the webviewRequests channel for processing.
2. sendMessageToBackend - Handles JavaScript to Go communication. This
is called when JavaScript sends messages via the webkit user content
manager, enabling the IPC bridge.
The asset server files (webkit6.go, request_linux_gtk4.go,
responsewriter_linux_gtk4.go) were already complete from Phase 1.
WebKitGTK 6.0 uses the same URI scheme handler API as WebKitGTK 4.1.
* build(linux): add GTK4 support to Docker and Taskfile
Phase 6 of WebKitGTK 6.0/GTK4 implementation.
Docker containers (Ubuntu 24.04):
- Install both GTK4/WebKitGTK 6.0 (default) and GTK3/WebKit2GTK 4.1 (legacy)
- Build scripts support BUILD_TAGS environment variable
- Default build uses GTK4, BUILD_TAGS=gtk3 uses legacy GTK3
Taskfile targets:
- test:example:linux - Build with GTK4 (default)
- test:example:linux:gtk3 - Build with GTK3 (legacy)
- test:examples:linux:docker:x86_64 - Docker build with GTK4
- test:examples:linux:docker:x86_64:gtk3 - Docker build with GTK3
- test:examples:linux:docker:arm64 - Docker build with GTK4 (ARM64)
- test:examples:linux:docker:arm64:gtk3 - Docker build with GTK3 (ARM64)
This allows testing both the new GTK4 default and legacy GTK3 builds.
* feat(linux): implement GTK4 dialog system with GtkFileDialog and GtkAlertDialog
Phase 8 of WebKitGTK 6.0/GTK4 implementation.
GTK4 completely replaced the dialog APIs. GTK3's GtkFileChooserDialog
and gtk_dialog_run() are deprecated/removed in GTK4.
File Dialogs (GtkFileDialog):
- gtk_file_dialog_open() for single file selection
- gtk_file_dialog_open_multiple() for multiple files
- gtk_file_dialog_select_folder() for folder selection
- gtk_file_dialog_save() for save dialogs
- Filters use GListStore of GtkFileFilter objects
- All operations are async with GAsyncResult callbacks
Message Dialogs (GtkAlertDialog):
- gtk_alert_dialog_choose() with button array
- Configurable default and cancel button indices
- Async response via callback
Implementation:
- Request ID tracking for async callback matching
- fileDialogCallback/alertDialogCallback C exports
- runChooserDialog/runQuestionDialog Go wrappers
- runOpenFileDialog/runSaveFileDialog convenience functions
* feat(linux): implement GTK4 keyboard accelerators for menu items
Add keyboard accelerator support using gtk_application_set_accels_for_action():
- Add namedKeysToGTK map with GDK keysym values for special keys
- Add parseKeyGTK() to convert key names to GDK keysyms
- Add parseModifiersGTK() to convert Wails modifiers to GDK modifier masks
- Add acceleratorToGTK() for full accelerator conversion
- Add setMenuItemAccelerator() Go wrapper calling C helpers
- Integrate accelerator setting in newMenuItemImpl, newCheckMenuItemImpl,
and newRadioMenuItemImpl during menu item creation
- Update setAccelerator() method on linuxMenuItem to use new function
Completes Phase 9 of GTK4 implementation.
* refactor(linux): extract GTK4 C code to separate files and fix WebKitGTK 6.0 API
Extract C code from linux_cgo_gtk4.go to dedicated C files for better
IDE support and maintainability:
- linux_cgo_gtk4.h: Function declarations and type definitions
- linux_cgo_gtk4.c: C implementations for GTK4/WebKitGTK 6.0
WebKitGTK 6.0 API fixes:
- webkit_web_view_new_with_user_content_manager() removed
-> Use create_webview_with_user_content_manager() with g_object_new()
- WEBKIT_HARDWARE_ACCELERATION_POLICY_ON_DEMAND removed
-> Default to ALWAYS (only ALWAYS/NEVER available in 6.0)
- WebKitJavascriptResult replaced with JSCValue in callbacks
-> sendMessageToBackend now receives JSCValue* directly
Also:
- Remove duplicate show()/hide() methods (use shared file)
- Remove duplicate startResize() (wrong signature)
- Add set_app_menu_model() setter for C global variable access
- Fix webview.Scheme reference to use hardcoded 'wails' string
Note: Some pre-existing compilation errors remain in the codebase
that are unrelated to this refactoring.
* fix(linux): resolve GTK4 compilation errors and add missing platform methods
- Add missing App methods: logPlatformInfo, platformEnvironment, fatalHandler
- Add missing linuxApp methods: hide, show, on, isOnMainThread, getAccentColor
- Add missing CGO functions: getPrimaryScreen, openDevTools, enableDevTools, handleLoadChanged
- Fix options.Linux nil check (struct not pointer)
- Fix runSaveFileDialog return type to match interface
- Fix registerWindow signature to accept pointer type
- Fix GdkRGBA to use float instead of double
- Add webview import for asset request handling
- Add sanity check task to Taskfile for quick compilation verification
* fix(linux): resolve GTK3/GTK4 symbol conflict in operatingsystem package
- Add gtk3 build tag to webkit_linux.go to prevent GTK3 linking in GTK4 builds
- Create webkit_linux_gtk4.go with GTK4/WebKitGTK 6.0 pkg-config
- Move app initialization from init() to newPlatformApp() for cleaner setup
- Fixes runtime crash: 'GTK 2/3 symbols detected in GTK 4 process'
* docs: update implementation tracker for GTK3/GTK4 symbol conflict fix
* fix(linux): add GTK4 activation gate to prevent window creation before app activation
GTK4 requires the application to be 'activated' before gtk_application_window_new()
can be called. This adds a synchronization mechanism:
- Add activated channel and sync.Once to linuxApp struct
- Mark application as activated in activateLinux callback
- Wait for activation in WebviewWindow.Run() before creating windows
Fixes SIGSEGV crash when creating windows on GTK4.
* feat(linux): add primary menu style option and fix GTK4 menu issues
- Add LinuxMenuStyle option for MenuBar vs PrimaryMenu (hamburger) display
- Fix menu separators using GMenu sections instead of separator items
- Fix radio button styling with proper string-valued stateful actions
- Fix app not terminating when last window closed
- Fix Window→Zoom to toggle maximize instead of webview zoom
- Add build constraints to .c/.h files for GTK3 compatibility
- Document MenuStyle option in window reference docs
- Update implementation tracker with session changes
* chore(examples): use PrimaryMenu style in menu example
* feat(linux): implement Systray API v2 with smart defaults and window options
- Add smart defaults for systray click behavior:
- Window only: left-click toggles window
- Menu only: right-click shows menu
- Window + Menu: left-click toggles, right-click shows menu
- Add HideOnEscape and HideOnFocusLost window options:
- HideOnEscape: hides window when Escape key pressed
- HideOnFocusLost: hides window on focus lost (auto-disabled on
focus-follows-mouse WMs like Hyprland, Sway, i3)
- Add WebviewWindow.RegisterKeyBinding() public method
- Fix Linux systray handlers:
- Activate() now calls clickHandler (was doubleClickHandler)
- SecondaryActivate() calls rightClickHandler or opens menu
- ItemIsMenu always false to let handlers control behavior
- Add environment_linux.go with compositor detection:
- detectCompositor(), detectFocusFollowsMouse(), isTilingWM()
- Cursor position detection for Hyprland/Sway
- Add comprehensive manual test suite in v3/test/manual/systray/
- window-only, menu-only, window-menu, custom-handlers, hide-options
- Builds for both GTK3 and GTK4
- README with test matrix for different environments
- Update systray-basic example to use new options
* feat: add doctor-ng package with modern TUI for system diagnostics
Introduces a new pkg/doctor-ng package with a clean public API designed
for reuse by both CLI and future GUI tools. Features include:
- Public API types (Report, SystemInfo, Dependency, DiagnosticResult)
- Platform-specific dependency detection (Linux, macOS, Windows)
- Package manager support (apt, dnf, pacman, emerge, eopkg, nixpkgs, zypper)
- Modern TUI using bubbletea/lipgloss with:
- Interactive dependency navigation (j/k keys)
- Install missing dependencies prompt (i key)
- Refresh/rescan capability (r key)
- Non-interactive mode for CI/scripts (-n flag)
The new command is available as 'wails3 doctor-ng' for testing while
the existing 'wails3 doctor' command remains unchanged.
* fix(doctor-ng): stabilize display order, conditional cursor, add copy to clipboard
- Sort platform extras alphabetically to prevent bouncing
- Only show dependency cursor when there are missing deps to act on
- Add 'c' key to copy sanitized report to clipboard
- Update help text to be contextual based on system state
* feat(doctor-ng): add package manager detection for macOS/Windows, remove unused code
- macOS: detect homebrew, macports, nix; show in platform extras
- Windows: detect winget, scoop, choco; show in platform extras
- Remove unused tui/install.go (replaced by tea.ExecProcess)
- Remove unused stateInstall/viewInstall from model.go
- Remove j/k navigation from help (cursor was already removed)
* feat(cli): add wails3 tool capabilities command
Checks system build capabilities via pkg-config:
- GTK4 and WebKitGTK 6.0 availability
- GTK3 and WebKit2GTK 4.1 availability
- Recommends gtk4 or gtk3 based on what's installed
Output is JSON for easy parsing by Taskfile/scripts.
* fix(linux/gtk4): avoid checkptr errors when building with -race
Go's race detector enables checkptr, which flags storing integers
as pointers (a common GLib/C pattern using GINT_TO_POINTER).
Changes:
- Change signal_connect to accept uintptr_t instead of void* for data
- Change enableDND/disableDND to accept uintptr_t instead of gpointer
- Replace unsafe.Pointer(uintptr(id)) with C.uintptr_t(id) in Go code
- Replace g_object_set/get_data for menu item IDs with Go-side map
- Pass 0 instead of nil for unused signal data parameters
This allows building with 'go build -race' for debugging without
triggering 'checkptr: pointer arithmetic computed bad pointer value'
fatal errors.
* fix(examples/dialogs): use window menu for GTK4 compatibility
GTK4 requires menus to be set on windows, not the application.
Use LinuxMenuStylePrimaryMenu to show menu in header bar.
* test(linux): add manual dialog test suite
Comprehensive test programs for GTK4 dialogs:
- message-info, message-question, message-warning, message-error
- file-open, file-open-multi, file-save, file-directory
Each test has multiple test cases accessible via menu.
Use 'go-task build:gtk4' or 'go-task build:gtk3' to build.
* fix(linux/gtk4): fix file dialog hang by not prematurely freeing dialog
GtkFileDialog is async - gtk_file_dialog_select_folder() returns
immediately and the callback fires later. The defer g_object_unref
was freeing the dialog before the user could interact with it.
GTK manages the dialog lifecycle internally for async operations.
* fix: add mutex to protect runtimeLoaded and pendingJS from races
Multiple goroutines access runtimeLoaded and pendingJS concurrently:
- ExecJS reads/writes from window event handlers
- HandleMessage writes when runtime becomes ready
- InitiateFrontendDropProcessing reads/writes during drag-drop
Added pendingJSMutex to synchronize access. Also changed HandleMessage
to copy pending slice before releasing lock to avoid holding it during
InvokeSync calls.
* fix(linux/gtk4): fix dialog deadlock and alert dialog lifecycle
- dialogs_linux.go: Change InvokeAsync to go func() to prevent deadlock
when show() is called - runQuestionDialog uses InvokeAsync internally
and blocks on channel, which deadlocks if caller is also using InvokeAsync
- linux_cgo_gtk4.c: Remove premature g_object_unref from show_alert_dialog
as GtkAlertDialog is async and GTK manages the lifecycle
- linux_cgo_gtk4.c: Add DEBUG_LOG macro for compile-time debug output
(CGO_CFLAGS="-DWAILS_GTK_DEBUG" go build ...)
- linux_cgo_gtk4.c: Handle cancelled-with-no-error case in file dialogs
- linux_cgo_gtk4.go: Fix runQuestionDialog to use options.Title as message
- linux_cgo_gtk4.go: Add default OK button when no buttons specified
* feat(linux/gtk4): implement custom message dialogs with proper styling
GTK4's GtkAlertDialog lacks icon support and visual differentiation.
This implements a custom GtkWindow-based dialog with:
- Escape key triggers cancel button via GtkEventControllerKey
- Enter key activates default button via gtk_window_set_default_widget
- Custom icons from bytes with gtk_image_set_pixel_size (64px max)
- Symbolic icons for info/warning/error/question dialogs
- 300px minimum width for better short message appearance
- Proper memory cleanup via message_dialog_cleanup()
- close-request returns cancel button index or -1
* fix(linux/gtk4): use native size for custom dialog icons
Custom icons now display at their native size.
Built-in symbolic icons remain at 32px as designed.
* fix(linux/gtk4): implement native file drag-and-drop
Use GtkDropControllerMotion and GtkDropTarget with GTK_PHASE_CAPTURE
to intercept file drops before WebKit's internal GtkDropTargetAsync
handler in the bubble phase.
- Add on_drop_accept to filter for GDK_TYPE_FILE_LIST
- Add motion controller for enter/leave/motion events
- Set capture phase so our handlers run before WebKit's
- Both controllers attached to WebKitWebView widget
* docs: update implementation tracker and dialog docs
- Update IMPLEMENTATION.md with GTK4 dialog progress
- Add GTK4 dialog documentation to reference docs
- Fix RLock -> Lock in cleanup to allow window modification
- Simplify manual dialog test menus (remove nested submenus)
* fix(linux/gtk4): parse runtime call params from query string
WebKitGTK 6.0 sends POST data as URL query parameters for custom URI
schemes instead of in the request body. Add fallback to parse object,
method, and args from query params when body is empty.
* fix(linux): fallback to application menu when no window menu set
Windows without an explicit Linux.Menu option now inherit the
application-level menu set via app.Menu.Set().
* fix(linux/gtk4): implement sync clipboard API
GTK4 uses async clipboard operations. Implement clipboard_get_text_sync
which iterates the GLib main context until the async read completes.
This avoids deadlock when called from the main thread (e.g., menu handlers).
* fix(linux/gtk4): DPI scaling and menu duplication fixes
- Implement proper DPI scaling using gdk_monitor_get_scale (GTK 4.14+)
for fractional scaling support on Linux/GTK4
- Calculate PhysicalBounds correctly by multiplying logical coords by scale
- Fix menu items duplicating when creating new windows by adding
processed flag to prevent re-processing menus
- Add safe type assertion helpers in screen example to prevent crashes
- Add CSS to prevent text selection during drag in screen example
- Document tiling WM limitations (Hyprland, Sway, i3) in official docs
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
* feat(tests): add GTK3 vs GTK4 benchmark suite
Add comprehensive benchmark suite for comparing GTK3 and GTK4 performance
in Wails applications. Benchmarks cover:
- Screen enumeration and primary screen query
- Window create/destroy, resize, show/hide operations
- Menu creation (simple, complex, with accelerators)
- Event emit and receive timing
- Dialog setup
Includes comparison tool for side-by-side analysis of results.
Usage:
go build -tags gtk3 -o benchmark-gtk3 .
go build -tags gtk4 -o benchmark-gtk4 .
./benchmark-gtk3 && ./benchmark-gtk4
go run compare.go benchmark-GTK3-*.json benchmark-GTK4-*.json
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
* feat(examples): add WebView API compatibility checker
Cross-platform example that tests and reports which Web APIs are
available in the current WebView engine. Tests 200+ APIs across
categories:
- Storage (localStorage, IndexedDB, Cache API, File System)
- Network (Fetch, WebSocket, WebTransport, SSE)
- Media (Web Audio, MediaRecorder, Speech APIs)
- Graphics (Canvas, WebGL, WebGL2, WebGPU)
- Device (Geolocation, Sensors, Bluetooth, USB, Serial)
- Workers (Web Workers, Service Workers, Shared Workers)
- Performance (Observers, Timing APIs)
- Security (Web Crypto, WebAuthn, Credentials)
- UI/DOM (Custom Elements, Shadow DOM, Clipboard)
- CSS (CSSOM, Container Queries, Modern Selectors)
- JavaScript (ES Modules, BigInt, Private Fields)
Useful for understanding API availability differences between:
- WebKitGTK (Linux) vs WebView2 (Windows) vs WKWebView (macOS)
- GTK3/WebKit2GTK 4.1 vs GTK4/WebKitGTK 6.0
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
* feat(examples): add Web API examples demonstrating browser capabilities
Add 15 interactive Web API examples in v3/examples/web-apis/:
- Storage: localStorage, IndexedDB
- Network: Fetch API, WebSocket
- Media: Canvas 2D, WebGL, Web Audio
- Device: Geolocation, Clipboard, Fullscreen
- Security: WebCrypto
- Notifications API
- Workers: Web Workers
- Observers: Intersection Observer, Resize Observer
Each example includes an interactive demo with API documentation
and feature detection to help developers understand what's
available in WebView environments.
Also updates webview-api-check with autorun support for
automated API compatibility testing.
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
* feat(examples): add 26 more Web API examples
Expand web-apis examples from 15 to 41 total, covering:
Storage: sessionStorage, Cache API, Page Visibility
Network: XMLHttpRequest, EventSource (SSE), Beacon API
Media: MediaDevices, MediaRecorder, Speech Synthesis
Device: Device Orientation, Vibration, Gamepad
Performance: Performance API, Mutation Observer
UI/DOM: Web Components, Pointer Events, Selection, Dialog
Messaging: Drag and Drop, Broadcast Channel, History API
Data: Streams, File API, Blob, Share, Permissions
Each example includes interactive demos, API detection,
and follows the consistent dark-themed styling pattern.
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
* docs: update changelog with full web-api examples count
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
* refactor(examples): simplify beacon demo with local server
Replace the complex beacon demo with a simpler version that includes:
- Local HTTP server on port 9999 that receives beacon data
- Go service to retrieve and display received beacons
- Quick buttons for common beacon types (pageview, click, error, timing)
- Live display of received beacon data with auto-refresh
- Clear explanation of how the demo works
This makes the demo more educational by showing both the sending
and receiving sides of the Beacon API.
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
* refactor(examples): streamline beacon demo UI
Revert to original standalone implementation with httpbin.org endpoint
but with a compact two-column layout that fits without scrolling:
- Left: endpoint config, data type selector, data input, example buttons
- Right: stats (sent/queued/failed/bytes), auto-unload option, event log
Features retained: String/JSON/FormData/Blob data types, analytics/error/
timing examples, auto-beacon on page unload.
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
* refactor(examples): streamline blob demo with tabbed layout
Redesign blob demo to fit without scrolling using:
- Three-column layout: Create | Stored Blobs | Output
- Tabbed interface for blob creation (Text/JSON/Binary/SVG)
- Compact blob list with download and delete actions
- Operations panel for conversions and slicing
- Feature badges showing API support status
Reduced from 846 lines to 349 lines while keeping core functionality.
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
* fix(examples): fix dropdown styling in blob demo
Style select option elements with dark background to match theme.
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
* feat(examples): add MDN links to demo titles
Link API names in titles to their MDN documentation pages.
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
* refactor(examples): streamline broadcast-channel with Wails windows
Redesign broadcast-channel demo for Wails environment:
- Replace browser tabs with Wails windows via WindowService
- Compact two-column layout: Channel/Send | Messages
- "Open New Window" button creates new Wails window
- Each window gets unique ID for message tracking
- Join/leave notifications when windows open/close
- Quick message buttons, ping all, stats display
- MDN link in title
Reduced from 737 lines to 245 lines.
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
* fix(examples): simplify broadcast-channel to use multiple app instances
Remove WindowService that required generated bindings. Instead, instruct
users to run multiple instances of the app to test cross-window messaging.
BroadcastChannel API works across windows of the same origin.
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
* feat(examples): add API feature badges to broadcast-channel demo
Show supported features: BroadcastChannel, postMessage, close,
onmessage, onmessageerror, MessageChannel - consistent with other demos.
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
* feat(examples): add multi-window support to broadcast-channel demo
Use Wails runtime.js and WindowService to open new windows for
cross-window BroadcastChannel API testing. Streamlined UI with
feature detection badges and MDN link.
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
* feat(linux): make GTK4 opt-in via -tags gtk4, keep GTK3 as default
This change inverts the build tag logic so that:
- GTK3/WebKit2GTK 4.1 is the stable default (no tag required)
- GTK4/WebKitGTK 6.0 is experimental opt-in via `-tags gtk4`
This allows the branch to be merged into v3-alpha without breaking
existing apps, while enabling early adopters to test GTK4 support.
Changes:
- Updated 20 Go files: `gtk3` → `!gtk4`, `!gtk3` → `gtk4`
- Updated IMPLEMENTATION.md to reflect new build strategy
- Updated benchmark README with correct build commands
- Added GTK4_FEEDBACK_ISSUE.md template for community testing
- Added Armaan's signing guide link to docs
Build commands after this change:
go build ./v3/... # GTK3 (default)
go build -tags gtk4 ./v3/... # GTK4 (experimental)
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
* refactor(linux): rename capabilities files to follow naming convention
Renamed for consistency with other GTK3/GTK4 file pairs:
- capabilities_linux.go (default, GTK3)
- capabilities_linux_gtk4.go (opt-in, GTK4)
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
* feat(linux/gtk4): add experimental notice with feedback issue link
When building with -tags gtk4, the app now displays a notice at startup
directing users to the feedback issue for reporting problems.
Issue: https://github.com/wailsapp/wails/issues/4957
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
* ci(linux): add GTK4 testing for webkit-gtk6-support branch
- Fix box alignment in experimental notice
- Add GTK4 dependency installation for this branch only
- Run Go tests with both default (GTK3) and -tags gtk4
- Build examples with both GTK versions
- Build templates with both GTK versions
The GTK4 tests only run when PR source branch is feature/webkit-gtk6-support.
This ensures existing PRs are not affected while enabling full GTK4 CI coverage.
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
* fix(doctor): make GTK3 primary, GTK4 experimental in package checks
Updated all 7 package managers to match new build tag strategy:
- GTK3/WebKit2GTK 4.1 → primary (required for default builds)
- GTK4/WebKitGTK 6.0 → optional/experimental (for -tags gtk4)
Affected: apt, dnf, pacman, zypper, emerge, eopkg, nixpkgs
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
* docs(dialogs): fix GTK3/GTK4 documentation to reflect default behavior
GTK3 is the default, GTK4 is opt-in via -tags gtk4. Updated the dialogs
documentation to clarify this instead of suggesting GTK3 is opt-in.
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
* fix(examples): escape HTML in web-apis examples to prevent DOM XSS
Add escapeHtml() helper function and escape all user-controlled or
dynamic values before inserting them into innerHTML to address CodeQL
security alerts.
Files fixed:
- beacon: escape log type, message, and class names
- eventsource: escape time and type in log entries
- file-api: escape file name, size, and type
- mediadevices: escape time, type, and message in log entries
- selection: escape text content before applying highlight regex
- share: escape file name, size, and type in file list
- speech-synthesis: escape time, type, and message in log entries
- web-components: escape title and color in shadow DOM template
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
* fix(linux): correct GTK4 build tags and Taskfile for GTK3 default
- Fix build tags in linux_cgo_gtk4.c and linux_cgo_gtk4.h from
`!gtk3` to `gtk4` to match the Go file constraints
- Update Taskfile.yaml to reflect GTK3 as default, GTK4 as opt-in
- Rename test:example:linux:gtk3 to test:example:linux:gtk4
- Comment out GTK4 tests in test:examples since CI doesn't have GTK4 deps
This fixes the CI failure where GTK4 C files were being compiled
by default due to incorrect build constraints.
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
* fix(systemtray): add missing defaultClickHandler method
Add the defaultClickHandler method that was in v3-alpha but not
properly merged. This method is called from systemtray_darwin.go
when handling tray icon clicks.
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
* fix(tests): add linux build constraint to gtk4-benchmark
The gtk4-benchmark test is Linux-only but was missing a build
constraint on main.go, causing build failures on macOS/Windows.
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
* ci(linux): skip hanging GTK4 service tests in CI
The service startup/shutdown tests hang in GTK4 CI environment due to
display initialization issues with xvfb. Skip these specific tests for
now while keeping other GTK4 tests running.
Skipped tests:
- TestServiceStartup
- TestServiceShutdown
- TestServiceStartupShutdown
The *Error variants of these tests still run as they fail fast before
the hang occurs.
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
* ci(linux): skip all service tests for GTK4 in CI
All service tests hang in GTK4 CI because they require a fully
functional GTK4 display that xvfb cannot provide. Skip all tests
matching "TestService" pattern.
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
* ci(linux): remove unsupported GTK4 template build test
The wails build command doesn't support the -tags flag yet.
GTK4 compilation is already verified by Go tests, so this
additional template build step is not necessary.
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
* Fix Copilot review feedback on PR #4958
- Use JSON.stringify() for onclick handlers in storage examples to safely
handle keys with quotes (sessionstorage, localstorage)
- Guard DeviceOrientationEvent check to prevent ReferenceError on
unsupported browsers (device-orientation)
- Add type assertion check for Bounds to prevent panic on malformed
JSON (screens.go)
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
---------
Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
|
||
|
Lea Anthony
|
37e57f679d |
fix(v3/windows): Move browser flags to application-level options (#4559) (#4946)
* fix(v3/windows): Move browser flags to application-level options (#4559) WebView2 shares a single browser environment per user data path, so browser flags (EnabledFeatures, DisabledFeatures, AdditionalBrowserArgs) must be set at application level, not per-window. Changes: - Add EnabledFeatures, DisabledFeatures, AdditionalBrowserArgs to application.Options.Windows - Mark per-window equivalents in WindowsWindow as deprecated - Update webview_window_windows.go to read from app-level options This fixes the crash when opening a second window with different browser flags. Fixes #4559 Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * fix: address PR review comments - Remove incorrectly added WebviewGpuPolicy field from WindowsOptions (it's a Linux-specific option that already exists in LinuxWindow) - Clarify changelog: AdditionalLaunchArgs was renamed to AdditionalBrowserArgs Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * refactor!: remove per-window browser flags (breaking change) BREAKING CHANGE: Remove EnabledFeatures, DisabledFeatures, and AdditionalLaunchArgs from per-window WindowsWindow options. Use application-level options instead: - Options.Windows.EnabledFeatures - Options.Windows.DisabledFeatures - Options.Windows.AdditionalBrowserArgs These flags apply globally to the shared WebView2 environment, so per-window configuration was never actually supported. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * docs: add documentation for application-level browser flags - Document EnabledFeatures, DisabledFeatures, AdditionalBrowserArgs - Add examples showing how to configure WebView2 browser flags - Explain that these flags apply globally to all windows - Update application API reference with platform-specific options Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * chore: simplify browser flags documentation Remove unnecessary warnings and overly prescriptive comments. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * docs: clarify that AdditionalBrowserArgs requires -- prefix Chromium command-line switches require the -- prefix. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com> |
||
|
Lea Anthony
|
fa06d48497 |
feat(v3): Add UseApplicationMenu option for cross-platform menu support (#4944)
* feat(v3): Add UseApplicationMenu option for cross-platform menu support Add `UseApplicationMenu` option to `WebviewWindowOptions` that allows windows on Windows and Linux to inherit the application menu set via `app.Menu.Set()`. This provides a simpler cross-platform approach: - On macOS: No effect (app menu is always global) - On Windows/Linux: Window displays the application menu Benefits: - Eliminates need for platform-specific menu code - Per-window opt-in maintains backwards compatibility - Explicit window menus still take priority Updated: - webview_window_options.go: Added UseApplicationMenu bool field - webview_window_windows.go: Check UseApplicationMenu when no window menu set - webview_window_linux.go: Check UseApplicationMenu when no window menu set - examples/dialogs: Use UseApplicationMenu instead of conditional SetMenu - examples/menu: Use UseApplicationMenu instead of explicit SetMenu - docs: Updated menu and window options documentation Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * docs: Remove incorrect 'Menu Options' section header --------- Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com> |
||
|
Lea Anthony
|
53c2275fea |
fix(v3): overhaul drag-and-drop for Linux reliability and simplify Windows implementation (#4848)
* fix(v3): overhaul drag-and-drop for Linux reliability and simplify Windows This commit fixes drag-and-drop reliability on Linux and simplifies the Windows implementation. ## Linux - Rewrite GTK drag handlers to properly intercept external file drops - Fix HTML5 internal drag-and-drop being broken when file drop enabled - Add hover effects during file drag operations - Fix multiple app instances interfering with each other ## Windows - Remove native IDropTarget in favor of JavaScript approach (matches v2) - File drops now handled via chrome.webview.postMessageWithAdditionalObjects ## All Platforms - Rename EnableDragAndDrop to EnableFileDrop - Rename data-wails-drop-target to data-file-drop-target - Rename wails-drop-target-active to file-drop-target-active - Add comprehensive drag-and-drop documentation ## Breaking Changes - EnableDragAndDrop -> EnableFileDrop - data-wails-dropzone -> data-file-drop-target - wails-dropzone-hover -> file-drop-target-active - DropZoneDetails -> DropTargetDetails - Remove WindowDropZoneFilesDropped event (use WindowFilesDropped) * feat(macos): optimize drag event performance with debouncing and caching - Add 50ms debouncing to limit drag events to 20/sec (was 120/sec) - Implement window implementation caching to avoid repeated lookups - Maintain existing 5-pixel threshold for immediate response - Keep zero-allocation path with pre-allocated buffers - Rename linuxDragActive to nativeDragActive for clarity - Update IMPLEMENTATION.md with optimization details and Windows guidance Performance improvements: - 83% reduction in event frequency - ~6x reduction in CPU/memory usage during drag operations - Maintains smooth visual feedback with InvokeSync for timer callbacks * fix(windows): implement proper file drop support for Windows - Remove incorrect AllowExternalDrag(false) call that was blocking file drops - Fix message prefix from 'FilesDropped' to 'file:drop:' to match JS runtime - Fix coordinate parsing for 'file:drop:x:y' format (indices 2,3 not 1,2) - Add enableFileDrop flag injection to JS runtime during navigation - Update JS runtime to check enableFileDrop flag before processing drops - Always call preventDefault() to stop browser navigation on file drags - Show 'no drop' cursor when file drops are disabled - Update example to filter file drags from HTML drop zone handlers - Add documentation for combining file drop with HTML drag-and-drop * fix(v3): block file drops on Linux when EnableFileDrop is false - Add disableDND() to intercept and reject external file drags at GTK level - Show 'no drop' cursor when files are dragged over window - Allow internal HTML5 drag-and-drop to work normally - Initialize _wails.flags object in runtime core to prevent undefined errors - Inject enableFileDrop flag on Linux and macOS (matching Windows) - Fix bare _wails reference to use window._wails - Update docs with info about blocked drops and combining with HTML DnD * fix(darwin): add missing fmt import in webview_window_darwin.go * fix(macOS): implement hover effects for file drag-and-drop with optimizations - Added draggingUpdated: handler to track mouse movement during drag operations - Implemented macosOnDragEnter/Exit/Over export functions for real-time hover state - Fixed JS function call from '_wails.handlePlatformFileDrop' to correct 'wails.Window.HandlePlatformFileDrop' - Added EnableFileDrop flag checks to prevent hover effects when file drops are disabled - Renamed linuxDragActive to nativeDragActive for cross-platform consistency Performance optimizations: - Added 50ms debounce to reduce event frequency from ~120/sec to ~20/sec - Implemented 5-pixel movement threshold for immediate response - Added window caching with sync.Map to avoid repeated lookups - Zero-allocation JavaScript calls with pre-allocated 128-byte buffer - Reduced memory usage to ~18 bytes per event (6x reduction) Build improvements: - Updated runtime Taskfile to include documentation generation - Added docs:build task to runtime build process - Fixed build order: events → docs → runtime Documentation: - Added IMPLEMENTATION.md with optimization details - Included guidance for Windows implementation * chore(v3/examples): remove html-dnd-api example The drag-n-drop example now demonstrates both external file drops and internal HTML5 drag-and-drop, making this separate example redundant. * docs(v3): move drag-and-drop implementation details to runtime-internals - Add drag-and-drop section to contributing/runtime-internals.mdx - Remove IMPLEMENTATION.md from example (content now in proper docs) - Covers platform differences, debugging tips, and key files * fix(v3): remove html-dnd-api from example build list * fix(v3): remove duplicate json import in application_darwin.go * fix(v3): address CodeRabbit review feedback - Fix docs to use app.Window.NewWithOptions() instead of deprecated API - Add mutex protection to dragOverJSBuffer to prevent race conditions - Add mutex protection to dragThrottleState fields for thread safety * docs: add coderabbit pre-push requirement to AGENTS.md * fix(v3/test): use correct CSS class name file-drop-target-active * chore(v3/test): remove dnd-test directory This was a development test file that shouldn't be in the PR. The drag-n-drop example serves as the proper test case. * docs(v3): update Windows file drop comment to reflect implemented fix Remove stale TODO - enableFileDrop flag is now injected in navigationCompleted * refactor(v3): make handleDragAndDropMessage unexported Internal method only called by application event loop, not part of public API. |
||
|
Lea Anthony
|
0de429b8fc |
feat(macos): add CollectionBehavior option to MacWindow (#4799)
* feat(macos): add CollectionBehavior option to MacWindow (#4756) Add configurable NSWindowCollectionBehavior support for macOS windows, allowing control over window behavior across Spaces and fullscreen. New options include: - MacWindowCollectionBehaviorCanJoinAllSpaces - MacWindowCollectionBehaviorFullScreenAuxiliary - MacWindowCollectionBehaviorMoveToActiveSpace - And more... This enables building Spotlight-like apps that appear on all Spaces or overlay fullscreen applications. Closes #4756 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com> * Potential fix for code scanning alert no. 140: Workflow does not contain permissions Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com> * Potential fix for code scanning alert no. 139: Workflow does not contain permissions Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com> * feat(examples): add spotlight example for CollectionBehavior Demonstrates creating a Spotlight-like launcher window that: - Appears on all macOS Spaces - Floats above other windows - Uses accessory activation policy (no Dock icon) - Has frameless translucent design 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com> * feat(macos): support bitwise OR for CollectionBehavior options Update CollectionBehavior to use actual NSWindowCollectionBehavior bitmask values, allowing multiple behaviors to be combined: ```go CollectionBehavior: application.MacWindowCollectionBehaviorCanJoinAllSpaces | application.MacWindowCollectionBehaviorFullScreenAuxiliary, ``` Changes: - Update Go constants to use actual bitmask values (1<<0, 1<<1, etc.) - Simplify C function to pass through combined bitmask directly - Add ParticipatesInCycle, IgnoresCycle, FullScreenDisallowsTiling options - Update documentation with combined behavior examples - Update spotlight example to demonstrate combining behaviors 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com> --------- Co-authored-by: Claude <noreply@anthropic.com> Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com> |
||
|
Lea Anthony
|
4bfc52f0b5 |
Add native Liquid Glass effect support for macOS (#4534)
* feat: Implement native Liquid Glass effect for macOS feat: Add platform check for Liquid Glass demo Show informative dialog on Windows/Linux explaining that the Liquid Glass effect is a macOS-specific feature. The demo will exit gracefully on non-macOS platforms. docs: Add Liquid Glass feature to unreleased changelog feat: Enhanced Liquid Glass effect with NSVisualEffectMaterial support Major improvements to the Liquid Glass implementation for macOS: - Added comprehensive NSVisualEffectMaterial support with 15+ material options - Removed debug NSLog statements for cleaner production code - Created multi-window demo showcasing 7 different glass effects: * Light Style - Clean light appearance * Dark Style - Dark themed glass * Vibrant Style - Enhanced transparency * Blue Tint - Custom RGBA tint color example * Sheet Material - NSVisualEffectMaterialSheet * HUD Window - Ultra-light HUD material * Content Background - With warm tint color - Added Material field to MacLiquidGlass struct for fine-grained control - Improved demo design with proper Title Case and cleaner layout - Fixed logo sizing to prevent blur - All windows fully draggable with InvisibleTitleBarHeight - Added comprehensive README documentation The implementation now provides developers with complete control over the glass effect appearance, supporting both native NSGlassEffectView (macOS 15.0+) and NSVisualEffectView fallback for older systems. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com> feat: Implement native Liquid Glass effect for macOS - Add support for NSGlassEffectView on macOS 15.0+ - Implement runtime detection of native glass APIs - Add fallback to enhanced NSVisualEffectView for older systems - Update liquid glass demo with frameless windows for better visibility - Support all NSGlassEffectView properties (cornerRadius, tintColor, style) - Properly handle webview layering with glass effect - Remove binary from version control 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com> * fix: Address CodeRabbit review feedback - Comment out unimplemented ReduceMotion and StaticMode fields - Remove overly broad draggable CSS properties - Add corner radius validation - Improve CSS with proper pointer-events and user-select - Add clarifying comments about future features * fix: Remove unimplemented ReduceMotion and StaticMode fields Completely remove the commented-out performance optimization fields as they are not implemented and have no timeline for implementation. * fix: Update windowRemoveVisualEffects to also remove NSGlassEffectView instances The cleanup function now properly removes both NSVisualEffectView and NSGlassEffectView instances to prevent orphaned effect layers. Uses NSClassFromString to avoid hard references to NSGlassEffectView which is only available on macOS 15.0+. * fix changelog * Update v3/pkg/application/webview_window_darwin.m Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update v3/pkg/application/webview_window_darwin.m Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * fix: Fix compilation errors in windowSetLiquidGlass - Add missing NSGlassEffectViewStyle enum definition - Fix undefined tintColor variable by creating NSColor before use - Add autorelease to prevent memory leaks for allocated views These issues were causing CI build failures while working locally due to different compiler settings. * Update Taskfile.yaml * feat: Implement groupID and groupSpacing for NSGlassEffectView - Add runtime detection for groupIdentifier/groupName selectors - Apply groupID via performSelector if supported - Apply groupSpacing via KVC if supported - Parameters are now functional when NSGlassEffectView supports them - Maintains backward compatibility by checking selector availability * test: Add liquid-glass example to test suite - Add liquid-glass to EXAMPLEDIRS in Taskfile.yaml - Ensures the example is tested during CI builds - Validates compilation on different platforms Addresses review comment about missing test coverage * fix: Correct NSGlassEffectView availability to macOS 26.0 - Update @available checks from macOS 15.0 to 26.0 for NSGlassEffectView - NSGlassEffectView is a private API introduced in macOS 26.0 - Update README to reflect correct version requirement - Keep NSVisualEffectMaterial checks at 15.0 as those are different APIs * fix: Prevent exceptions from unsafe WebView reparenting - Remove early WebView addition to glassView.contentView - Consolidate all WebView reparenting in one safe location - Always call removeFromSuperview before adding to new parent - Set frame and autoresizing mask after safe reparenting - Prevents NSInternalInconsistencyException from multiple parents * fix: Make WebView reparenting more robust and thread-safe - Always call removeFromSuperview before adding to new parent - Remove brittle superview check, always detach and reattach - Check both webView and glassContentView are non-nil before operations - Ensure all UI operations run on main thread with dispatch_sync - Set frame and autoresizing mask after safe reparenting * Tidy up * Update changelog --------- Co-authored-by: Claude <noreply@anthropic.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> |
||
|
Lea Anthony
|
3f11d4e3fa |
feat: Add Content Protection for Windows and macOS (#4485)
* feat: Add Content Protection for Windows and macOS - Prevents window contents from being captured by screen recording/sharing software - Windows: Uses WDA_EXCLUDEFROMCAPTURE on Windows 10 2004+, falls back to WDA_MONITOR - macOS: Uses NSWindowSharingType to set window as read-only for screen sharing - Added ContentProtectionEnabled option to WebviewWindowOptions - Added SetContentProtection() method for runtime control - Added comprehensive documentation and example usage * fix changelog.mdx * Misc fixes * Misc fixes * Update v3/pkg/w32/user32.go Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * Remove debug line --------- Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> |
||
|
Lea Anthony
|
fe717c42b5 |
Refactor to using Window interface (#4471)
Refactor window interface to eliminate type assertions and improve code maintainability |
||
Hudolus
|
4c70d4501e |
Custom Windows Webview2 Args (#4467)
* Adding the ability to pass custom args to windows webview2 --------- Co-authored-by: Jason Gibson <jason@harbingerinteractive.com> Co-authored-by: Lea Anthony <lea.anthony@gmail.com> |
||
|
Lea Anthony
|
ed81ab01e7 |
Support allowsBackForwardNavigationGestures (#4453)
* ## Summary
I have successfully implemented support for `allowsBackForwardNavigationGestures` in Wails v3. Here's what I accomplished:
### Investigation Results
- **Issue Status**: The feature was **NOT** previously implemented in Wails v3
- **go-webview2**: This library is Windows-only and doesn't provide macOS WKWebView features
- **Need**: A native implementation was required specifically for macOS WKWebView
### Implementation Details
1. **Added new option**: `AllowsBackForwardNavigationGestures u.Bool` to `MacWebviewPreferences`
2. **Extended C bridge**: Updated the C struct to pass the preference to Objective-C code
3. **Implemented WKWebView setting**: Added code to set `webView.allowsBackForwardNavigationGestures` during initialization
4. **Updated preference processing**: Extended the Go code to handle the new preference
### Key Files Modified
- `v3/pkg/application/webview_window_options.go`: Added the preference option
- `v3/pkg/application/webview_window_darwin.go`: Implemented the C bridge and WKWebView configuration
### Usage Example
```go
window.SetOptions(application.WebviewWindowOptions{
Mac: application.MacWindow{
WebviewPreferences: application.MacWebviewPreferences{
AllowsBackForwardNavigationGestures: u.True(),
},
},
})
```
### Testing
- ✅ Code compiles successfully
- ✅ Created working example demonstrating the feature
- ✅ Follows existing Wails v3 patterns and conventions
### Benefits
- Provides native macOS two-finger swipe navigation
- Better performance than JavaScript alternatives
- Maintains accessibility features
- Seamless integration with existing Wails v3 API
The implementation is ready for testing and could be submitted as a PR to the Wails repository. The feature addresses the exact requirements from GitHub issue #1857 and provides both specific and API-consistent access to WKWebView's navigation gesture functionality.
* Perfect! I have:
1. ✅ Removed the `NAVIGATION_GESTURES_FEATURE.md` file
2. ✅ Removed the `example_navigation_gestures.go` file
3. ✅ Updated the `UNRELEASED_CHANGELOG.md` with a FIX entry
The changelog entry properly documents that this fix adds support for `allowsBackForwardNavigationGestures` in macOS WKWebView to enable two-finger swipe navigation gestures, referencing issue #1857.
The implementation is now clean and ready, with only the essential code changes remaining and the changelog properly updated to reflect the fix.
|
||
|
Lea Anthony
|
a29b4f0861 |
feat: Add full dark mode support for Windows menus | ||
|
Lea Anthony
|
2db902ef82 |
Add menu option for Linux | ||
|
Lea Anthony
|
36a1b71f93 |
The application menu is now macOS only.
Fixed a `Parameter incorrect` error in Windows. Updated Window example for mica/acrylic/tabbed windows. |
||
|
Lea Anthony
|
86f5049d29 |
Improve move & resize debouncer.
Fix double event. Fix shutdown issue with webview2. |
||
|
Lea Anthony
|
11cdbd8b83 |
Add in resize debounce as an option | ||
|
Lea Anthony
|
65f95b0380 |
Removed OnShouldClose: Create single way of handling conditional and unconditional close. | ||
|
Lea Anthony
|
459b5e1036 |
Added EnabledFeatures and DisabledFeatures options
|
||
|
Lea Anthony
|
1c34c252cc |
Remove resize debounce setting for windows.
Optimise resizing performance on windows automatically. |
||
|
Lea Anthony
|
99d538ea97 |
V3 alpha feature/3659 support webview options (#3766)
* [windows] Add GeneralAutofillEnabled and PasswordAutosaveEnabled options * Use latest go-webview2 * Updates * Fix changelog |
||
|
Lea Anthony
|
3e00b390c1 |
V3 alpha feature/start window position (#3885)
* New InitialPosition setting * Fix mac inverted Y issue. Fix mac centering issue. * Change position text in example * Update changelog.md |
||
Mohamed Gharib
|
efe0c8d534 |
[v3-Windows] New DIP system for Enhanced High DPI Monitor Support (#3665)
* [v3-Windows] New DIP system for Enhanced High DPI Monitor Support * Update changelog * Remove asset middleware * Remove SetThreadDpiAwarenessContext() * Fix macOS build. * Fill missing screens fields (linux, darwin) * Skip DPI transformation on unsupported platforms * Simplify distanceFromRectSquared() * Update v3/pkg/application/screenmanager.go Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> --------- Co-authored-by: Lea Anthony <lea.anthony@gmail.com> Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> |
||
Oleg Gulevskyy
|
b756bce67f |
Set MacOS window levels (NSWindow) (#3674)
* set nswindow levels via mac options * add changelog description * update changelog to conform with others |
||
|
Lea Anthony
|
bf9e17a6c8 |
[WEP] Customise Window Titlebars (#3508)
* Add proposal. Reference Mac implementation * Add windows support. Update proposal. * Update example * Rename Active->Enable,Inactive->Disabled. Ensure window can get controls back after hiding close on windows. Added guide. Updated example. * Add ExStyle option for setting titlebar style. * Fix linux builds * Tidy up |
||
|
Lea Anthony
|
98aff7778e | Support ProgramName on linux | ||
|
Lea Anthony
|
e9a9420e5c |
Refactor options.
Update deps |