mirror of
https://github.com/wailsapp/wails.git
synced 2026-03-16 15:45:50 +01:00
3f29158dfa
I have successfully implemented the "Start At Login" feature for Wails v3, addressing all the major concerns raised in PR #3910. Here's what was accomplished: ### ✅ **Core Implementation** 1. **Added StartAtLogin option** to `application.Options` struct 2. **Implemented platform-specific methods** for all three platforms: - **macOS**: Uses AppleScript with proper escaping to prevent injection attacks - **Windows**: Uses Windows Registry with restrictive permissions - **Linux**: Uses XDG autostart specification with .desktop files 3. **Added public API methods**: - `SetStartAtLogin(enabled bool) error` - Enable/disable start at login - `StartsAtLogin() (bool, error)` - Check current status ### ✅ **Security Improvements** (addressing PR comments) 1. **Path validation and sanitization** across all platforms 2. **AppleScript injection protection** on macOS with proper escaping 3. **Registry permissions** restricted to necessary access on Windows 4. **Executable path validation** with symlink resolution 5. **Input sanitization** for application names and paths ### ✅ **Error Handling & Documentation** 1. **Comprehensive error handling** with descriptive error messages 2. **Complete API documentation** with platform-specific behavior notes 3. **macOS Info.plist requirement** documented (NSAppleEventsUsageDescription) 4. **Cross-platform compatibility** notes and troubleshooting ### ✅ **Example & Testing** 1. **Working example application** demonstrating usage 2. **Comprehensive README** with platform-specific requirements 3. **Runtime toggling capability** implemented 4. **Compilation verified** - the implementation builds successfully ### 🔧 **Technical Details** - **macOS**: Uses Bundle information and AppleScript with security hardening - **Windows**: Uses HKEY_CURRENT_USER registry with KEY_SET_VALUE/KEY_QUERY_VALUE permissions - **Linux**: Creates XDG-compliant .desktop files in ~/.config/autostart/ ### 📋 **Key Features** - ✅ Cross-platform support (macOS, Windows, Linux) - ✅ Runtime configuration via public API - ✅ Application startup configuration via Options - ✅ Security hardening against injection attacks - ✅ Proper error handling and validation - ✅ Complete documentation and examples The implementation is now ready for testing and can be integrated into Wails v3. All major security concerns from the original PR have been addressed, and the feature includes proper documentation for developers. |
||
|---|---|---|
| .. | ||
| application | ||
| events | ||
| icons | ||
| mac | ||
| services | ||
| w32 | ||