wails/v3/pkg/application/messageprocessor.go
Lea Anthony 3650439b6e fix: prevent crash when closing window with pending async calls
- Add messageProcessor field to App struct to store MessageProcessor instance
- Implement CancelWindowCalls method to cancel pending async calls for a window
- Track window calls in MessageProcessor with windowCalls map
- Call CancelWindowCalls in window destroy() method to prevent crashes
- Add safety checks for destroyed windows in CallError and CallResponse
- Update issue-4353 test and example to use correct Wails v3 APIs

Fixes #4353

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>
2025-07-21 22:43:45 +10:00

210 lines
5.8 KiB
Go

package application
import (
"context"
"encoding/json"
"errors"
"fmt"
"log/slog"
"net/http"
"strconv"
"sync"
"math"
)
// TODO maybe we could use a new struct that has the targetWindow as an attribute so we could get rid of passing the targetWindow
// as parameter through every function call.
const (
callRequest = 0
clipboardRequest = 1
applicationRequest = 2
eventsRequest = 3
contextMenuRequest = 4
dialogRequest = 5
windowRequest = 6
screensRequest = 7
systemRequest = 8
browserRequest = 9
cancelCallRequesst = 10
)
type MessageProcessor struct {
logger *slog.Logger
runningCalls map[string]context.CancelFunc
windowCalls map[uint]map[string]bool // Track which calls belong to which window
l sync.Mutex
}
func NewMessageProcessor(logger *slog.Logger) *MessageProcessor {
return &MessageProcessor{
logger: logger,
runningCalls: map[string]context.CancelFunc{},
windowCalls: map[uint]map[string]bool{},
}
}
func (m *MessageProcessor) httpError(rw http.ResponseWriter, message string, err error) {
m.Error(message, "error", err)
rw.WriteHeader(http.StatusUnprocessableEntity)
_, err = rw.Write([]byte(err.Error()))
if err != nil {
m.Error("Unable to write error response:", "error", err)
}
}
func (m *MessageProcessor) getTargetWindow(r *http.Request) (Window, string) {
windowName := r.Header.Get(webViewRequestHeaderWindowName)
if windowName != "" {
window, _ := globalApplication.Window.GetByName(windowName)
return window, windowName
}
windowID := r.Header.Get(webViewRequestHeaderWindowId)
if windowID == "" {
return nil, windowID
}
wID, err := strconv.ParseUint(windowID, 10, 64)
if err != nil {
m.Error("Window ID not parsable:", "id", windowID, "error", err)
return nil, windowID
}
// Check if wID is within the valid range for uint
if wID > math.MaxUint32 {
m.Error("Window ID out of range for uint:", "id", wID)
return nil, windowID
}
targetWindow, _ := globalApplication.Window.GetByID(uint(wID))
if targetWindow == nil {
m.Error("Window ID not found:", "id", wID)
return nil, windowID
}
return targetWindow, windowID
}
func (m *MessageProcessor) ServeHTTP(rw http.ResponseWriter, r *http.Request) {
object := r.URL.Query().Get("object")
if object == "" {
m.httpError(rw, "Invalid runtime call:", errors.New("missing object value"))
return
}
m.HandleRuntimeCallWithIDs(rw, r)
}
func (m *MessageProcessor) HandleRuntimeCallWithIDs(rw http.ResponseWriter, r *http.Request) {
defer func() {
if handlePanic() {
rw.WriteHeader(http.StatusInternalServerError)
}
}()
object, err := strconv.Atoi(r.URL.Query().Get("object"))
if err != nil {
m.httpError(rw, "Invalid runtime call:", fmt.Errorf("error decoding object value: %w", err))
return
}
method, err := strconv.Atoi(r.URL.Query().Get("method"))
if err != nil {
m.httpError(rw, "Invalid runtime call:", fmt.Errorf("error decoding method value: %w", err))
return
}
params := QueryParams(r.URL.Query())
targetWindow, nameOrID := m.getTargetWindow(r)
if targetWindow == nil {
m.httpError(rw, "Invalid runtime call:", fmt.Errorf("window '%s' not found", nameOrID))
return
}
switch object {
case windowRequest:
m.processWindowMethod(method, rw, r, targetWindow, params)
case clipboardRequest:
m.processClipboardMethod(method, rw, r, targetWindow, params)
case dialogRequest:
m.processDialogMethod(method, rw, r, targetWindow, params)
case eventsRequest:
m.processEventsMethod(method, rw, r, targetWindow, params)
case applicationRequest:
m.processApplicationMethod(method, rw, r, targetWindow, params)
case contextMenuRequest:
m.processContextMenuMethod(method, rw, r, targetWindow, params)
case screensRequest:
m.processScreensMethod(method, rw, r, targetWindow, params)
case callRequest:
m.processCallMethod(method, rw, r, targetWindow, params)
case systemRequest:
m.processSystemMethod(method, rw, r, targetWindow, params)
case browserRequest:
m.processBrowserMethod(method, rw, r, targetWindow, params)
case cancelCallRequesst:
m.processCallCancelMethod(method, rw, r, targetWindow, params)
default:
m.httpError(rw, "Invalid runtime call:", fmt.Errorf("unknown object %d", object))
}
}
func (m *MessageProcessor) Error(message string, args ...any) {
m.logger.Error(message, args...)
}
func (m *MessageProcessor) Info(message string, args ...any) {
m.logger.Info(message, args...)
}
func (m *MessageProcessor) json(rw http.ResponseWriter, data any) {
rw.Header().Set("Content-Type", "application/json")
// convert data to json
var jsonPayload = []byte("{}")
var err error
if data != nil {
jsonPayload, err = json.Marshal(data)
if err != nil {
m.Error("Unable to convert data to JSON. Please report this to the Wails team!", "error", err)
return
}
}
_, err = rw.Write(jsonPayload)
if err != nil {
m.Error("Unable to write json payload. Please report this to the Wails team!", "error", err)
return
}
m.ok(rw)
}
func (m *MessageProcessor) text(rw http.ResponseWriter, data string) {
_, err := rw.Write([]byte(data))
if err != nil {
m.Error("Unable to write json payload. Please report this to the Wails team!", "error", err)
return
}
rw.Header().Set("Content-Type", "text/plain")
rw.WriteHeader(http.StatusOK)
}
func (m *MessageProcessor) ok(rw http.ResponseWriter) {
rw.WriteHeader(http.StatusOK)
}
// CancelWindowCalls cancels all pending calls for a specific window
func (m *MessageProcessor) CancelWindowCalls(windowID uint) {
m.l.Lock()
defer m.l.Unlock()
// Get all call IDs for this window
callIDs, exists := m.windowCalls[windowID]
if !exists {
return
}
// Cancel each call
for callID := range callIDs {
if cancel, ok := m.runningCalls[callID]; ok {
cancel()
delete(m.runningCalls, callID)
}
}
// Remove the window's call tracking
delete(m.windowCalls, windowID)
}