mirror of
https://github.com/wailsapp/wails.git
synced 2026-03-14 22:55:48 +01:00
* Refactor Manager API to use singular naming convention This is a RENAME-ONLY exercise that converts the Wails v3 Manager API from plural to singular naming for better consistency and clarity. ## Changes Applied ### API Transformations: - `app.Windows.*` → `app.Window.*` - `app.Events.*` → `app.Event.*` - `app.ContextMenus.*` → `app.ContextMenu.*` - `app.KeyBindings.*` → `app.KeyBinding.*` - `app.Dialogs.*` → `app.Dialog.*` - `app.Menus.*` → `app.Menu.*` - `app.Screens.*` → `app.Screen.*` ### Files Updated: - **Core Application**: 22 files in `v3/pkg/application/` - **Examples**: 43+ files in `v3/examples/` - **Documentation**: 13 files in `docs/src/content/docs/` - **CLI Tests**: 1 file in `v3/internal/commands/` ### Critical Constraints Preserved: - ✅ Event string constants unchanged (e.g., "windows:WindowShow") - ✅ Platform event names preserved (events.Windows, events.Mac, etc.) - ✅ TypeScript API remains compatible - ✅ All functionality intact ### Verification: - ✅ All examples build successfully (`task test:examples` passes) - ✅ Application package compiles without errors - ✅ Documentation reflects new API patterns ## Benefits - **Improved Clarity**: Singular names are more intuitive (`app.Window` vs `app.Windows`) - **Better Consistency**: Aligns with Go naming conventions - **Enhanced Developer Experience**: Clearer autocomplete and API discovery 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com> * Fix generator testcases and add cross-platform test cleanup - Update 28 generator testcase files to use singular API (app.Window.New() vs app.Windows.New()) - Add cross-platform cleanup system with Go script to remove test artifacts - Add test:all task with comprehensive testing and automatic cleanup - Fix cleanup to target files vs directories correctly (preserves source directories) 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com> * Fix remaining Windows CI failures by updating all plural API usage to singular Fixed the last remaining instances of old plural Manager API usage: - tests/window-visibility-test/main.go: Updated all app.Windows -> app.Window and app.Menus -> app.Menu - internal/templates/_common/main.go.tmpl: Updated app.Windows -> app.Window and app.Events -> app.Event - pkg/services/badge/badge_windows.go: Updated app.Windows -> app.Window (Windows-specific fix) These fixes address the Windows CI failures where platform-specific files still used the old API. The tests didn't catch this locally because Windows-specific files only compile on Windows. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com> --------- Co-authored-by: Claude <noreply@anthropic.com>
233 lines
4.5 KiB
Go
233 lines
4.5 KiB
Go
package application
|
|
|
|
type menuImpl interface {
|
|
update()
|
|
}
|
|
|
|
type ContextMenu struct {
|
|
*Menu
|
|
name string
|
|
}
|
|
|
|
func NewContextMenu(name string) *ContextMenu {
|
|
result := &ContextMenu{
|
|
Menu: NewMenu(),
|
|
name: name,
|
|
}
|
|
result.Update()
|
|
return result
|
|
}
|
|
|
|
func (m *ContextMenu) Update() {
|
|
m.Menu.Update()
|
|
globalApplication.ContextMenu.Add(m.name, m)
|
|
}
|
|
|
|
func (m *ContextMenu) Destroy() {
|
|
globalApplication.ContextMenu.Remove(m.name)
|
|
}
|
|
|
|
type Menu struct {
|
|
items []*MenuItem
|
|
label string
|
|
|
|
impl menuImpl
|
|
}
|
|
|
|
func NewMenu() *Menu {
|
|
return &Menu{}
|
|
}
|
|
|
|
func (m *Menu) Add(label string) *MenuItem {
|
|
result := NewMenuItem(label)
|
|
m.items = append(m.items, result)
|
|
return result
|
|
}
|
|
|
|
func (m *Menu) AddSeparator() {
|
|
result := NewMenuItemSeparator()
|
|
m.items = append(m.items, result)
|
|
}
|
|
|
|
func (m *Menu) AddCheckbox(label string, enabled bool) *MenuItem {
|
|
result := NewMenuItemCheckbox(label, enabled)
|
|
m.items = append(m.items, result)
|
|
return result
|
|
}
|
|
|
|
func (m *Menu) AddRadio(label string, enabled bool) *MenuItem {
|
|
result := NewMenuItemRadio(label, enabled)
|
|
m.items = append(m.items, result)
|
|
return result
|
|
}
|
|
|
|
func (m *Menu) Update() {
|
|
m.processRadioGroups()
|
|
if m.impl == nil {
|
|
m.impl = newMenuImpl(m)
|
|
}
|
|
m.impl.update()
|
|
}
|
|
|
|
// Clear all menu items
|
|
func (m *Menu) Clear() {
|
|
for _, item := range m.items {
|
|
removeMenuItemByID(item.id)
|
|
}
|
|
m.items = nil
|
|
}
|
|
|
|
func (m *Menu) Destroy() {
|
|
for _, item := range m.items {
|
|
item.Destroy()
|
|
}
|
|
m.items = nil
|
|
}
|
|
|
|
func (m *Menu) AddSubmenu(s string) *Menu {
|
|
result := NewSubMenuItem(s)
|
|
m.items = append(m.items, result)
|
|
return result.submenu
|
|
}
|
|
|
|
func (m *Menu) AddRole(role Role) *Menu {
|
|
result := NewRole(role)
|
|
if result != nil {
|
|
m.items = append(m.items, result)
|
|
}
|
|
return m
|
|
}
|
|
|
|
func (m *Menu) processRadioGroups() {
|
|
var radioGroup []*MenuItem
|
|
|
|
closeOutRadioGroups := func() {
|
|
if len(radioGroup) > 0 {
|
|
for _, item := range radioGroup {
|
|
item.radioGroupMembers = radioGroup
|
|
}
|
|
radioGroup = []*MenuItem{}
|
|
}
|
|
}
|
|
|
|
for _, item := range m.items {
|
|
if item.itemType != radio {
|
|
closeOutRadioGroups()
|
|
}
|
|
if item.itemType == submenu {
|
|
item.submenu.processRadioGroups()
|
|
continue
|
|
}
|
|
if item.itemType == radio {
|
|
radioGroup = append(radioGroup, item)
|
|
}
|
|
}
|
|
closeOutRadioGroups()
|
|
}
|
|
|
|
func (m *Menu) SetLabel(label string) {
|
|
m.label = label
|
|
}
|
|
|
|
func (m *Menu) setContextData(data *ContextMenuData) {
|
|
for _, item := range m.items {
|
|
item.setContextData(data)
|
|
}
|
|
}
|
|
|
|
// FindByLabel recursively searches for a menu item with the given label
|
|
// and returns the first match, or nil if not found.
|
|
func (m *Menu) FindByLabel(label string) *MenuItem {
|
|
for _, item := range m.items {
|
|
if item.label == label {
|
|
return item
|
|
}
|
|
if item.submenu != nil {
|
|
found := item.submenu.FindByLabel(label)
|
|
if found != nil {
|
|
return found
|
|
}
|
|
}
|
|
}
|
|
return nil
|
|
}
|
|
|
|
// FindByRole recursively searches for a menu item with the given role
|
|
// and returns the first match, or nil if not found.
|
|
func (m *Menu) FindByRole(role Role) *MenuItem {
|
|
for _, item := range m.items {
|
|
if item.role == role {
|
|
return item
|
|
}
|
|
if item.submenu != nil {
|
|
found := item.submenu.FindByRole(role)
|
|
if found != nil {
|
|
return found
|
|
}
|
|
}
|
|
}
|
|
return nil
|
|
}
|
|
|
|
func (m *Menu) RemoveMenuItem(target *MenuItem) {
|
|
for i, item := range m.items {
|
|
if item == target {
|
|
// Remove the item from the slice
|
|
m.items = append(m.items[:i], m.items[i+1:]...)
|
|
break
|
|
}
|
|
if item.submenu != nil {
|
|
item.submenu.RemoveMenuItem(target)
|
|
}
|
|
}
|
|
}
|
|
|
|
// ItemAt returns the menu item at the given index, or nil if the index is out of bounds.
|
|
func (m *Menu) ItemAt(index int) *MenuItem {
|
|
if index < 0 || index >= len(m.items) {
|
|
return nil
|
|
}
|
|
return m.items[index]
|
|
}
|
|
|
|
// Clone recursively clones the menu and all its submenus.
|
|
func (m *Menu) Clone() *Menu {
|
|
result := &Menu{
|
|
label: m.label,
|
|
}
|
|
for _, item := range m.items {
|
|
result.items = append(result.items, item.Clone())
|
|
}
|
|
return result
|
|
}
|
|
|
|
// Append menu to an existing menu
|
|
func (m *Menu) Append(in *Menu) {
|
|
if in == nil {
|
|
return
|
|
}
|
|
m.items = append(m.items, in.items...)
|
|
}
|
|
|
|
// Prepend menu before an existing menu
|
|
func (m *Menu) Prepend(in *Menu) {
|
|
m.items = append(in.items, m.items...)
|
|
}
|
|
|
|
func (a *App) NewMenu() *Menu {
|
|
return a.Menu.New()
|
|
}
|
|
|
|
func NewMenuFromItems(item *MenuItem, items ...*MenuItem) *Menu {
|
|
result := &Menu{
|
|
items: []*MenuItem{item},
|
|
}
|
|
result.items = append(result.items, items...)
|
|
return result
|
|
}
|
|
|
|
func NewSubmenu(s string, items *Menu) *MenuItem {
|
|
result := NewSubMenuItem(s)
|
|
result.submenu = items
|
|
return result
|
|
}
|