From a6711aeb63e6ea0d18c34832ea183f80c1b2271e Mon Sep 17 00:00:00 2001
From: Alicia Sykes <alicia@omg.lol>
Date: Thu, 14 Sep 2023 20:59:09 +0100
Subject: [PATCH] Update Dockerfile (#43)

Updates the Dockerfile with changes suggested by @GWnbsp  in https://github.com/Lissy93/web-check/issues/43#issuecomment-1719212234

### Summary of Changes
1. **ARG Statements:** Introduced `ARG` statements for Node.js and Debian versions, making the Dockerfile more customizable.
2. **SHELL Command:** Changed the default shell to Bash with certain options enabled, improving robustness.
3. **Chromium Installation:** Updated Chromium installation to use Google's signing keys and repositories, aiming for more secure and up-to-date packages.
4. **Chromium Version:** Added a step to save Chromium's version into `/etc/chromium-version` for reference.
5. **Directory Creation:** Added a new directory /app/data in the container's filesystem.
6. **CMD Change:** Changed the CMD to start Node.js server (server.js) instead of using yarn serve.
7. **General Cleanup and Comments:** Code has been refactored for better readability and detailed comments have been added for clarity.
8. **Dependency Installation:** Kept yarn install and the removal of the Yarn cache, but the command is more streamlined.
9. **Other Minor Changes:**
  - Added flags like `-qq` and `--no-install-recommends` for quieter and optimized installation.
  - Enhanced cleanup with `rm -rf /var/lib/apt/lists/*.`
---
 Dockerfile | 41 +++++++++++++++++++++++++++++++++--------
 1 file changed, 33 insertions(+), 8 deletions(-)

diff --git a/Dockerfile b/Dockerfile
index 3951f55..5b0e15d 100644
--- a/Dockerfile
+++ b/Dockerfile
@@ -1,23 +1,48 @@
-FROM node:16-buster-slim
+# Specify the Node.js version to use
+ARG NODE_VERSION=16
 
-RUN apt-get update && \
-    apt-get install -y chromium traceroute && \
-    chmod 755 /usr/bin/chromium && \
-    rm -rf /var/lib/apt/lists/*
+# Specify the Debian version to use, the default is "bullseye"
+ARG DEBIAN_VERSION=bullseye
 
+# Use Node.js Docker image as the base image, with specific Node and Debian versions
+FROM docker.io/library/node:${NODE_VERSION}-${DEBIAN_VERSION}
+
+# Set the container's default shell to Bash and enable some options
+SHELL ["/bin/bash", "-euo", "pipefail", "-c"]
+
+# Install Chromium browser and Download and verify Google Chrome’s signing key
+RUN apt-get update -qq --fix-missing && \
+    apt-get -qqy install --allow-unauthenticated gnupg wget && \
+    wget --quiet --output-document=- https://dl-ssl.google.com/linux/linux_signing_key.pub | gpg --dearmor > /etc/apt/trusted.gpg.d/google-archive.gpg && \
+    echo "deb [arch=amd64] http://dl.google.com/linux/chrome/deb/ stable main" > /etc/apt/sources.list.d/google.list && \
+    apt-get update -qq && \
+    apt-get -qqy --no-install-recommends install chromium traceroute && \
+    rm -rf /var/lib/apt/lists/* 
+
+# Run the Chromium browser's version command and redirect its output to the /etc/chromium-version file
+RUN /usr/bin/chromium --no-sandbox --version > /etc/chromium-version
+
+# Set the working directory to /app
 WORKDIR /app
 
+# Copy package.json and yarn.lock to the working directory
 COPY package.json yarn.lock ./
 
-RUN yarn install && \
-    rm -rf /app/node_modules/.cache
+# Run yarn install to install dependencies and clear yarn cache
+RUN yarn install && rm -rf /app/node_modules/.cache
 
+# Copy all files to working directory
 COPY . .
+RUN mkdir /app/data
 
+# Run yarn build to build the application
 RUN yarn build
 
+# Exposed container port, the default is 3000, which can be modified through the environment variable PORT
 EXPOSE ${PORT:-3000}
 
+# Set the environment variable CHROME_PATH to specify the path to the Chromium binaries
 ENV CHROME_PATH='/usr/bin/chromium'
 
-CMD ["yarn", "serve"]
\ No newline at end of file
+# Define the command executed when the container starts and start the server.js of the Node.js application
+CMD [ "node", "server.js" ]