Browse Source

Resolve vulnerabilities + fix tests (#668)

* Remove GPR Github action (for now)

* Update test badge

* Remove stale.yml

* Upgrade cypress + fix failing tests

* Upgrade postcss-cli

* Update postcss command

* Remove space

* Add slight delay between scrolling animations

* Update test descriptions

* Remove signed commits/tagging (for now)

* chore(release): 🔖 version 7.0.5

* Update commit message

* Revert "Upgrade cypress + fix failing tests"

This reverts commit b6fbd0f51a.
pull/671/head
Josh Johnson 2 years ago
committed by GitHub
parent
commit
ffc32df462
No known key found for this signature in database GPG Key ID: 4AEE18F83AFDEB23
  1. 21
      .github/stale.yml
  2. 32
      .github/workflows/npmpublish.yml
  3. 6
      .npmrc
  4. 2
      README.md
  5. 6
      cypress/integration/select-multiple.spec.js
  6. 2
      cypress/integration/select-one.spec.js
  7. 1127
      package-lock.json
  8. 8
      package.json

21
.github/stale.yml

@ -1,21 +0,0 @@
# Number of days of inactivity before an issue becomes stale
daysUntilStale: 100
# Number of days of inactivity before a stale issue is closed
daysUntilClose: 10
# Issues with these labels will never be considered stale
exemptLabels:
- pinned
- security
- feature request
# Label to use when marking an issue as stale
staleLabel: stale
# Comment to post when marking an issue as stale. Set to `false` to disable
markComment: >
Thanks for contributing to this issue. As it has been 60 days since the last
activity, this issue is being automatically closed. This is often because the
request was already solved in some way and it just wasn't updated or it's no
longer applicable. If that's not the case, please do feel free to either
reopen this issue or open a new one. We'll gladly take a look again!
# Comment to post when closing a stale issue. Set to `false` to disable
closeComment: false
only: issues

32
.github/workflows/npmpublish.yml

@ -19,11 +19,11 @@ jobs:
node-version: 10
# run all tests
- run: |
npm ci
npm run build
npx bundlesize
npm run coverage
npm run test:e2e
npm ci
npm run build
npx bundlesize
npm run coverage
npm run test:e2e
env:
CI: true
CI_REPO_NAME: ${{ github.event.repository.name }}
@ -63,24 +63,4 @@ jobs:
HUSKY_SKIP_INSTALL: true
- run: npm publish
env:
NODE_AUTH_TOKEN: ${{secrets.NPM_TOKEN}}
publish-gpr:
needs: build
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v1
with:
fetch-depth: 1
- uses: actions/setup-node@v1
with:
node-version: 10
registry-url: https://npm.pkg.github.com/
scope: "@jshjohnson"
- run: npm ci
env:
CYPRESS_INSTALL_BINARY: 0
HUSKY_SKIP_INSTALL: true
- run: npm publish --access public
env:
NODE_AUTH_TOKEN: ${{secrets.GITHUB_TOKEN}}
NODE_AUTH_TOKEN: ${{secrets.NPM_TOKEN}}

6
.npmrc

@ -1,4 +1,2 @@
message="chore(release): :bookmark: version %s"
git-tag-version=true
sign-git-tag=true
sign-git-commit=true
message=":bookmark: Version %s"
git-tag-version=true

2
README.md

@ -1,4 +1,4 @@
# Choices.js ![Build Status](https://travis-ci.org/jshjohnson/Choices.svg?branch=master) [![](https://data.jsdelivr.com/v1/package/npm/choices.js/badge?style=rounded)](https://www.jsdelivr.com/package/npm/choices.js) [![npm](https://img.shields.io/npm/v/choices.js.svg)](https://www.npmjs.com/package/choices.js) [![codebeat badge](https://codebeat.co/badges/55120150-5866-42d8-8010-6aaaff5d3fa1)](https://codebeat.co/projects/github-com-jshjohnson-choices-master)
# Choices.js [![Actions Status](https://github.com/jshjohnson/Choices/workflows/Unit%20Tests/badge.svg)](https://github.com/jshjohnson/Choices/actions) [![npm](https://img.shields.io/npm/v/choices.js.svg)](https://www.npmjs.com/package/choices.js) [![codebeat badge](https://codebeat.co/badges/55120150-5866-42d8-8010-6aaaff5d3fa1)](https://codebeat.co/projects/github-com-jshjohnson-choices-master)
A vanilla, lightweight (~22kb gzipped 🎉), configurable select box/text input plugin. Similar to Select2 and Selectize but without the jQuery dependency.
[Demo](https://joshuajohnson.co.uk/Choices/)

6
cypress/integration/select-multiple.spec.js

@ -334,7 +334,7 @@ describe('Choices - select multiple', () => {
});
describe('on click', () => {
it('does not opens choice dropdown', () => {
it('does not open choice dropdown', () => {
cy.get('[data-test-hook=disabled-via-attr]')
.find('.choices')
.click()
@ -515,7 +515,7 @@ describe('Choices - select multiple', () => {
});
describe('on click', () => {
it('does not opens choice dropdown', () => {
it('does not open choice dropdown', () => {
cy.get('[data-test-hook=remote-data]')
.find('.choices')
.click()
@ -567,6 +567,8 @@ describe('Choices - select multiple', () => {
it('scrolls to next choice on down arrow', () => {
for (let index = 0; index < choicesCount; index++) {
cy.wait(100);
cy.get('[data-test-hook=scrolling-dropdown]')
.find('.choices__list--dropdown .choices__list .is-highlighted')
.should($choice => {

2
cypress/integration/select-one.spec.js

@ -466,7 +466,7 @@ describe('Choices - select one', () => {
});
describe('on click', () => {
it('does not opens choice dropdown', () => {
it('does not open choice dropdown', () => {
cy.get('[data-test-hook=remote-data]')
.find('.choices')
.click()

1127
package-lock.json
File diff suppressed because it is too large
View File

8
package.json

@ -1,6 +1,6 @@
{
"name": "choices.js",
"version": "7.0.4",
"version": "7.0.5",
"description": "A vanilla JS customisable text input/select box plugin",
"main": "./public/assets/scripts/choices.min.js",
"types": "./types/index.d.ts",
@ -21,7 +21,7 @@
"css:watch": "nodemon -e scss -x \"npm run css:build\"",
"css:build": "run-p css:sass css:prefix css:min",
"css:sass": "node-sass --output-style expanded --include-path scss src/styles/base.scss public/assets/styles/base.css && node-sass --output-style expanded --include-path scss src/styles/choices.scss public/assets/styles/choices.css",
"css:prefix": "postcss --use autoprefixer -b 'last 2 versions' public/assets/styles/*.css -d public/assets/styles",
"css:prefix": "postcss public/assets/styles/*.css --use autoprefixer --env prod --dir public/assets/styles",
"css:min": "csso public/assets/styles/base.css public/assets/styles/base.min.css && csso public/assets/styles/choices.css public/assets/styles/choices.min.css",
"deploy": "git subtree push --prefix public origin gh-pages",
"prepush": "run-p lint test:unit && npm run bundlesize",
@ -61,7 +61,7 @@
"@babel/plugin-transform-spread": "^7.2.2",
"@babel/preset-env": "^7.3.1",
"@babel/register": "^7.0.0",
"autoprefixer": "^6.3.3",
"autoprefixer": "^9.6.5",
"babel-loader": "^8.0.5",
"bundlesize": "^0.18.0",
"chai": "^4.2.0",
@ -83,7 +83,7 @@
"npm-run-all": "^4.1.5",
"nyc": "^14.1.1",
"opn": "^5.4.0",
"postcss-cli": "^2.5.1",
"postcss-cli": "^6.1.3",
"prettier": "^1.16.4",
"sinon": "^7.5.0",
"unminified-webpack-plugin": "^2.0.0",

Loading…
Cancel
Save