deblan/FOSElasticaBundle
1
0
Fork 0
Code Issues Pull requests Releases Wiki Activity

Ignore failed deletions in ObjectPersister

Browse source 
This probably isn't the best way to solve my problem,
but the issue is this.

Step 1:  Create a new doctrine entity for which it's `is_indexable_callback`
returns false.  When doctrine flushes this entity to the database,
elastia will not index it with elastic search.  (Correct)

Step 2:  Update your doctrine entity and change some fields so
that `is_indexable_callback` _still_ returns false.  Persist and flush
to the database.

At this point, the postUpdate listener on ElastiaBundle is called
and since the `is_indexable_callback` returns false, it believes
it needs to remove it from the elastic search index and queues it
for deletion.  The deletion of course fails because it was never there
in the first place.

This solution simply ignores failures from deletions in the index.

Perhaps a better solution would be to have a smarter listener
that could determine if the entity was previously present in the
elastic search index or not, but that would require significant
refactoring.

Addresses issues discuseed in #284

Credit to @bbeaulant for simple solution.  Opening a PR to
discuss more generally.
This commit is contained in:
Richard Fullmer 2013-06-04 11:45:45 -07:00
parent 94ab3b1d3c
commit 1fc94b2213
1 changed files with 10 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

13
Persister/ObjectPersister.php
View file

@ -2,6 +2,7 @@
namespace FOS\ElasticaBundle\Persister;
use Elastica\Exception\NotFoundException;
use FOS\ElasticaBundle\Transformer\ModelToElasticaTransformerInterface;
use Elastica\Type;
use Elastica\Document;
@ -48,7 +49,9 @@ class ObjectPersister implements ObjectPersisterInterface
public function replaceOne($object)
{
$document = $this->transformToElasticaDocument($object);
$this->type->deleteById($document->getId());
try {
$this->type->deleteById($document->getId());
} catch (NotFoundException $e) {}
$this->type->addDocument($document);
}
@ -61,7 +64,9 @@ class ObjectPersister implements ObjectPersisterInterface
public function deleteOne($object)
{
$document = $this->transformToElasticaDocument($object);
$this->type->deleteById($document->getId());
try {
$this->type->deleteById($document->getId());
} catch (NotFoundException $e) {}
}
/**
@ -73,7 +78,9 @@ class ObjectPersister implements ObjectPersisterInterface
**/
public function deleteById($id)
{
$this->type->deleteById($id);
try {
$this->type->deleteById($id);
} catch (NotFoundException $e) {}
}