deblan/FOSElasticaBundle
1
0
Fork 0
Code Issues Pull requests Releases Wiki Activity

Removed exception catching in Doctrine listeners

Browse source
This commit is contained in:
Richard Miller 2012-01-12 19:38:56 +00:00
parent ce82e8f591
commit 851c461fa8
5 changed files with 7 additions and 47 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

16
Doctrine/AbstractListener.php
View file

@ -28,17 +28,14 @@ abstract class AbstractListener
*/
protected $events;
protected $logger;
/**
* Constructor
**/
public function __construct(ObjectPersisterInterface $objectPersister, $objectClass, array $events, LoggerInterface $logger = null)
public function __construct(ObjectPersisterInterface $objectPersister, $objectClass, array $events)
{
$this->objectPersister = $objectPersister;
$this->objectClass = $objectClass;
$this->events = $events;
$this->logger = $logger;
}
/**
@ -49,15 +46,4 @@ abstract class AbstractListener
return $this->events;
}
/**
* Log the failure message if a logger is available
*
* $param string $message
*/
protected function logFailure($message)
{
if (null !== $this->logger) {
$this->logger->warn(sprintf('%s: %s', get_class($this), $message));
}
}
}

18
Doctrine/MongoDB/Listener.php
View file

@ -13,11 +13,7 @@ class Listener extends AbstractListener implements EventSubscriber
$document = $eventArgs->getDocument();
if ($document instanceof $this->objectClass) {
try {
$this->objectPersister->insertOne($document);
} catch (\Exception $e) {
$this->logFailure($e->getMessage());
}
$this->objectPersister->insertOne($document);
}
}
@ -26,11 +22,7 @@ class Listener extends AbstractListener implements EventSubscriber
$document = $eventArgs->getDocument();
if ($document instanceof $this->objectClass) {
try {
$this->objectPersister->replaceOne($document);
} catch (\Exception $e) {
$this->logFailure($e->getMessage());
}
$this->objectPersister->replaceOne($document);
}
}
@ -39,11 +31,7 @@ class Listener extends AbstractListener implements EventSubscriber
$document = $eventArgs->getDocument();
if ($document instanceof $this->objectClass) {
try {
$this->objectPersister->deleteOne($document);
} catch (\Exception $e) {
$this->logFailure($e->getMessage());
}
$this->objectPersister->deleteOne($document);
}
}
}

18
Doctrine/ORM/Listener.php
View file

@ -13,11 +13,7 @@ class Listener extends AbstractListener implements EventSubscriber
$entity = $eventArgs->getEntity();
if ($entity instanceof $this->objectClass) {
try {
$this->objectPersister->insertOne($entity);
} catch (\Exception $e) {
$this->logFailure($e->getMessage());
}
$this->objectPersister->insertOne($entity);
}
}
@ -26,11 +22,7 @@ class Listener extends AbstractListener implements EventSubscriber
$entity = $eventArgs->getEntity();
if ($entity instanceof $this->objectClass) {
try {
$this->objectPersister->replaceOne($entity);
} catch (\Exception $e) {
$this->logFailure($e->getMessage());
}
$this->objectPersister->replaceOne($entity);
}
}
@ -39,11 +31,7 @@ class Listener extends AbstractListener implements EventSubscriber
$entity = $eventArgs->getEntity();
if ($entity instanceof $this->objectClass) {
try {
$this->objectPersister->deleteOne($entity);
} catch (\Exception $e) {
$this->logFailure($e->getMessage());
}
$this->objectPersister->deleteOne($entity);
}
}
}

1
Resources/config/mongodb.xml
View file

@ -18,7 +18,6 @@
<argument /> <!-- object persister -->
<argument /> <!-- model -->
<argument type="collection" /> <!-- events -->
<argument type="service" id="logger" on-invalid="null" />
</service>
<service id="foq_elastica.elastica_to_model_transformer.prototype.mongodb" class="FOQ\ElasticaBundle\Doctrine\MongoDB\ElasticaToModelTransformer" public="false">

1
Resources/config/orm.xml
View file

@ -18,7 +18,6 @@
<argument /> <!-- object persister -->
<argument /> <!-- model -->
<argument type="collection" /> <!-- events -->
<argument type="service" id="logger" on-invalid="null" />
</service>
<service id="foq_elastica.elastica_to_model_transformer.prototype.orm" class="FOQ\ElasticaBundle\Doctrine\ORM\ElasticaToModelTransformer" public="false">