From 1fc94b22133e5803123c6b5a8523756b585e6d99 Mon Sep 17 00:00:00 2001
From: Richard Fullmer <richardfullmer@gmail.com>
Date: Tue, 4 Jun 2013 11:45:45 -0700
Subject: [PATCH] Ignore failed deletions in ObjectPersister

This probably isn't the best way to solve my problem,
but the issue is this.

Step 1:  Create a new doctrine entity for which it's `is_indexable_callback`
returns false.  When doctrine flushes this entity to the database,
elastia will not index it with elastic search.  (Correct)

Step 2:  Update your doctrine entity and change some fields so
that `is_indexable_callback` _still_ returns false.  Persist and flush
to the database.

At this point, the postUpdate listener on ElastiaBundle is called
and since the `is_indexable_callback` returns false, it believes
it needs to remove it from the elastic search index and queues it
for deletion.  The deletion of course fails because it was never there
in the first place.

This solution simply ignores failures from deletions in the index.

Perhaps a better solution would be to have a smarter listener
that could determine if the entity was previously present in the
elastic search index or not, but that would require significant
refactoring.

Addresses issues discuseed in #284

Credit to @bbeaulant for simple solution.  Opening a PR to
discuss more generally.
---
 Persister/ObjectPersister.php | 13 ++++++++++---
 1 file changed, 10 insertions(+), 3 deletions(-)

diff --git a/Persister/ObjectPersister.php b/Persister/ObjectPersister.php
index 643b817..450e43b 100644
--- a/Persister/ObjectPersister.php
+++ b/Persister/ObjectPersister.php
@@ -2,6 +2,7 @@
 
 namespace FOS\ElasticaBundle\Persister;
 
+use Elastica\Exception\NotFoundException;
 use FOS\ElasticaBundle\Transformer\ModelToElasticaTransformerInterface;
 use Elastica\Type;
 use Elastica\Document;
@@ -48,7 +49,9 @@ class ObjectPersister implements ObjectPersisterInterface
     public function replaceOne($object)
     {
         $document = $this->transformToElasticaDocument($object);
-        $this->type->deleteById($document->getId());
+        try {
+            $this->type->deleteById($document->getId());
+        } catch (NotFoundException $e) {}
         $this->type->addDocument($document);
     }
 
@@ -61,7 +64,9 @@ class ObjectPersister implements ObjectPersisterInterface
     public function deleteOne($object)
     {
         $document = $this->transformToElasticaDocument($object);
-        $this->type->deleteById($document->getId());
+        try {
+            $this->type->deleteById($document->getId());
+        } catch (NotFoundException $e) {}
     }
 
     /**
@@ -73,7 +78,9 @@ class ObjectPersister implements ObjectPersisterInterface
      **/
     public function deleteById($id)
     {
-        $this->type->deleteById($id);
+        try {
+            $this->type->deleteById($id);
+        } catch (NotFoundException $e) {}
     }