PR feedback

This commit is contained in:
koalyptus 2018-01-08 21:38:55 +11:00
parent 2deeb5d57a
commit 74cea36219
1 changed files with 30 additions and 1 deletions

View File

@ -36,7 +36,7 @@ test('Should not initialize if already initialized', function() {
});
module('Behaviour');
test('Can update', function() {
test('Can update filters state', function() {
// setup
state.state = {};
@ -236,6 +236,13 @@ test('Can sync state', function() {
test('Can override state', function() {
// setup
var hit = 0;
var initialEmit = state.emitter.emit;
var args = null;
state.emitter.emit = function() {
args = arguments;
hit++;
};
state.state = {};
// act
@ -244,6 +251,12 @@ test('Can override state', function() {
// assert
deepEqual(state.state, { 'col_1': { 'flt': 'Ade' } },
'State field overriden');
deepEqual(hit, 1, 'event emitted');
deepEqual(args[0], 'state-changed', 'event name');
deepEqual(args[1], tf, 'tf parameter');
deepEqual(args[2], state.state, 'state parameter');
state.emitter.emit = initialEmit;
});
test('Can override and sync state', function() {
@ -327,6 +340,22 @@ test('Can update filters visibility', function() {
'Filters visibility updated');
});
test('sync filters can clear filters before applying state', function() {
// setup
state.state = {'col_0': { 'flt': 'Ade' }};
tf.setFilterValue(1, 'Can');
tf.setFilterValue(2, '1412');
// act
state._syncFilters();
// assert
deepEqual(tf.getFilterValue(1), '', 'filter 1 cleared');
deepEqual(tf.getFilterValue(2), '', 'filter 2 cleared');
deepEqual(tf.getFilterValue(0), 'Ade', 'filter 0 state value applied');
deepEqual(tf.getValidRows(), [6, 7, 8], 'Filtered rows');
});
module('Tear-down');
test('Can destroy TF', function() {
// setup