deblan-mirror/abraunegg-onedrive
deblan-mirror/abraunegg-onedrive
1
0
Fork 0
mirror of https://github.com/abraunegg/onedrive synced 2024-04-27 11:51:59 +02:00
Code Issues Projects Releases Wiki Activity

Handle OneDrive API response when cTag key is missing (Issue #512) (#513)

Browse source 
* Handle response from OneDrive where cTag JSON elements are missing when uploading a locally modified file
* Update bug_report.md to fix up spelling errors
This commit is contained in:
abraunegg 2019-05-30 12:41:26 +10:00 committed by GitHub
parent bac9ab41ae
commit 8d4a35e34d
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 8 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
.github/ISSUE_TEMPLATE/bug_report.md vendored
View file

@ -19,7 +19,7 @@ A clear and concise description of what the bug is.
**Note:** If curl version is >= 7.62.0 please generate a full debug log as per [https://github.com/abraunegg/onedrive/wiki/Generate-debug-log-for-support](https://github.com/abraunegg/onedrive/wiki/Generate-debug-log-for-support) and email to support@mynas.com.au
Once the full degug log has been generated & emailed, please retry your sync by adding `--force-http-1.1`. If this is successful, please advise in issue ticket that `--force-http-1.1` was sucessful in resolving your issue.
Once the full debug log has been generated & emailed, please retry your sync by adding `--force-http-1.1`. If this is successful, please advise in issue ticket that `--force-http-1.1` was successful in resolving your issue.
**To Reproduce**
Steps to reproduce the behavior if not causing an application crash:

9
src/sync.d
View file

@ -1531,8 +1531,13 @@ final class SyncEngine
writeln("done.");
}
log.fileOnly("Uploading modified file ", path, " ... done.");
// use the cTag instead of the eTag because OneDrive may update the metadata of files AFTER they have been uploaded via simple upload
eTag = response["cTag"].str;
if ("cTag" in response) {
// use the cTag instead of the eTag because OneDrive may update the metadata of files AFTER they have been uploaded via simple upload
eTag = response["cTag"].str;
} else {
// cTag missing in response, use the original item.etag
eTag = item.eTag;
}
} else {
// we are --dry-run - simulate the file upload
writeln("done.");