deblan/forms
1
0
Fork 0
Code Issues Pull requests Releases Wiki Activity

Pimp entities and models

Browse source 
* Strict
* Extend proper class
* Typehint
* Return types

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
This commit is contained in:
Roeland Jago Douma 2019-08-30 13:58:25 +02:00
commit 45e5e1f3b5
No known key found for this signature in database
GPG key ID: F941078878347C0C
11 changed files with 48 additions and 69 deletions
Download patch file Download diff file Expand all files Collapse all files

10
lib/Db/AnswerMapper.php
View file

@ -1,4 +1,6 @@
<?php
declare(strict_types=1);
/**
* @copyright Copyright (c) 2019 Inigo Jiron <ijiron@terpmail.umd.edu>
*
@ -35,7 +37,7 @@ class AnswerMapper extends QBMapper {
* @param IDBConnection $db
*/
public function __construct(IDBConnection $db) {
parent::__construct($db, 'forms_answers', '\OCA\Forms\Db\Answer');
parent::__construct($db, 'forms_answers', Answer::class);
}
// TODO: Change below functions to search by form and question id
@ -47,7 +49,7 @@ class AnswerMapper extends QBMapper {
* @return Answer[]
*/
public function findByForm($formId, $questionId) {
public function findByForm(int $formId, int $questionId): array {
$qb = $this->db->getQueryBuilder();
$qb->select('*')
@ -66,7 +68,7 @@ class AnswerMapper extends QBMapper {
* @param int $formId
* @param int $questionId
*/
public function deleteByFormAndQuestion($formId, $questionId) {
public function deleteByFormAndQuestion(int $formId, int $questionId): void {
$qb = $this->db->getQueryBuilder();
$qb->delete($this->getTableName())
@ -83,7 +85,7 @@ class AnswerMapper extends QBMapper {
/**
* @param int $formId
*/
public function deleteByForm($formId) {
public function deleteByForm(int $formId): void {
$qb = $this->db->getQueryBuilder();
$qb->delete($this->getTableName())