Pimp entities and models

* Strict
* Extend proper class
* Typehint
* Return types

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
This commit is contained in:
Roeland Jago Douma 2019-08-30 13:58:25 +02:00
commit 45e5e1f3b5
No known key found for this signature in database
GPG key ID: F941078878347C0C
11 changed files with 48 additions and 69 deletions

View file

@ -35,7 +35,7 @@ class EventMapper extends QBMapper {
* @param IDBConnection $db
*/
public function __construct(IDBConnection $db) {
parent::__construct($db, 'forms_events', '\OCA\Forms\Db\Event');
parent::__construct($db, 'forms_events', Event::class);
}
/**
@ -44,7 +44,7 @@ class EventMapper extends QBMapper {
* @throws \OCP\AppFramework\Db\MultipleObjectsReturnedException if more than one result
* @return Event
*/
public function find($id) {
public function find(int $id): Event {
$qb = $this->db->getQueryBuilder();
$qb->select('*')
@ -62,7 +62,7 @@ class EventMapper extends QBMapper {
* @throws \OCP\AppFramework\Db\MultipleObjectsReturnedException if more than one result
* @return Event
*/
public function findByHash($hash) {
public function findByHash(string $hash): Event {
$qb = $this->db->getQueryBuilder();
$qb->select('*')
@ -78,7 +78,7 @@ class EventMapper extends QBMapper {
* @throws \OCP\AppFramework\Db\DoesNotExistException if not found
* @return Event[]
*/
public function findAll() {
public function findAll(): array {
$qb = $this->db->getQueryBuilder();
$qb->select('*')