deblan/forms
1
0
Fork 0
Code Issues Pull requests Releases Wiki Activity

Pimp entities and models

Browse source 
* Strict
* Extend proper class
* Typehint
* Return types

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
This commit is contained in:
Roeland Jago Douma 2019-08-30 13:58:25 +02:00
commit 45e5e1f3b5
No known key found for this signature in database
GPG key ID: F941078878347C0C
11 changed files with 48 additions and 69 deletions
Download patch file Download diff file Expand all files Collapse all files

11
lib/Db/NotificationMapper.php
View file

@ -1,4 +1,5 @@
<?php
declare(strict_types=1);
/**
* @copyright Copyright (c) 2017 Vinzenz Rosenkranz <vinzenz.rosenkranz@gmail.com>
*
@ -31,7 +32,7 @@ use OCP\AppFramework\Db\QBMapper;
class NotificationMapper extends QBMapper {
public function __construct(IDBConnection $db) {
parent::__construct($db, 'forms_notif', '\OCA\Forms\Db\Notification');
parent::__construct($db, 'forms_notif', Notification::class);
}
/**
@ -41,7 +42,7 @@ class NotificationMapper extends QBMapper {
* @return Notification[]
*/
public function findAllByForm($formId) {
public function findAllByForm(int $formId): array {
$qb = $this->db->getQueryBuilder();
$qb->select('*')
@ -59,9 +60,9 @@ class NotificationMapper extends QBMapper {
* @param string $userId
* @throws \OCP\AppFramework\Db\DoesNotExistException if not found
* @throws \OCP\AppFramework\Db\MultipleObjectsReturnedException if more than one result
* @return Notification
* @return Notification[]
*/
public function findByUserAndForm($formId, $userId) {
public function findByUserAndForm(int $formId, string $userId): array {
$qb = $this->db->getQueryBuilder();
$qb->select('*')
@ -79,7 +80,7 @@ class NotificationMapper extends QBMapper {
/**
* @param int $formId
*/
public function deleteByForm($formId) {
public function deleteByForm(int $formId): void {
$qb = $this->db->getQueryBuilder();
$qb->delete($this->getTableName())