deblan/forms
1
0
Fork 0
Code Issues Pull requests Releases Wiki Activity

Pimp entities and models

Browse source 
* Strict
* Extend proper class
* Typehint
* Return types

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
This commit is contained in:
Roeland Jago Douma 2019-08-30 13:58:25 +02:00
commit 45e5e1f3b5
No known key found for this signature in database
GPG key ID: F941078878347C0C
11 changed files with 48 additions and 69 deletions
Download patch file Download diff file Expand all files Collapse all files

12
lib/Db/VoteMapper.php
View file

@ -35,7 +35,7 @@ class VoteMapper extends QBMapper {
* @param IDBConnection $db
*/
public function __construct(IDBConnection $db) {
parent::__construct($db, 'forms_votes', '\OCA\Forms\Db\Vote');
parent::__construct($db, 'forms_votes', VoteMapper::class);
}
/**
@ -44,7 +44,7 @@ class VoteMapper extends QBMapper {
* @return Comment[]
*/
public function findByForm($formId) {
public function findByForm(int $formId): array {
$qb = $this->db->getQueryBuilder();
$qb->select('*')
@ -59,9 +59,9 @@ class VoteMapper extends QBMapper {
/**
* @param int $formId
* @throws \OCP\AppFramework\Db\DoesNotExistException if not found
* @return Array
* @return array
*/
public function findParticipantsByForm($formId, $limit = null, $offset = null) {
public function findParticipantsByForm(int $formId, $limit = null, $offset = null): array {
$qb = $this->db->getQueryBuilder();
$qb->select('user_id')
@ -77,7 +77,7 @@ class VoteMapper extends QBMapper {
* @param int $formId
* @param string $userId
*/
public function deleteByFormAndUser($formId, $userId) {
public function deleteByFormAndUser(int $formId, string $userId): void {
$qb = $this->db->getQueryBuilder();
$qb->delete($this->getTableName())
@ -94,7 +94,7 @@ class VoteMapper extends QBMapper {
/**
* @param int $formId
*/
public function deleteByForm($formId) {
public function deleteByForm(int $formId): void {
$qb = $this->db->getQueryBuilder();
$qb->delete($this->getTableName())