From 648cbbd987460a7e50cbe88742b84fb0f37d78cd Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?John=20Molakvo=C3=A6=20=28skjnldsv=29?=
 <skjnldsv@protonmail.com>
Date: Tue, 28 Apr 2020 17:34:50 +0200
Subject: [PATCH] Fix checkbox validity check
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
---
 src/components/Questions/QuestionMultiple.vue | 31 +++++++++++++++----
 1 file changed, 25 insertions(+), 6 deletions(-)

diff --git a/src/components/Questions/QuestionMultiple.vue b/src/components/Questions/QuestionMultiple.vue
index 56069b9..837115d 100644
--- a/src/components/Questions/QuestionMultiple.vue
+++ b/src/components/Questions/QuestionMultiple.vue
@@ -42,7 +42,7 @@
 							'checkbox question__checkbox': !isUnique,
 						}"
 						:name="`${id}-answer`"
-						:required="true /* TODO: implement required option */"
+						:required="isRequired(answer.id)"
 						:type="isUnique ? 'radio' : 'checkbox'"
 						@change="onChange($event, answer.id)">
 					<label v-if="!edit"
@@ -115,6 +115,10 @@ export default {
 		hasNoAnswer() {
 			return this.options.length === 0
 		},
+
+		areNoneChecked() {
+			return this.values.length === 0
+		},
 	},
 
 	watch: {
@@ -149,13 +153,28 @@ export default {
 		},
 
 		/**
-		 * Is the provided index checked
-		 * @param {number} index the option index
+		 * Is the provided answer checked ?
+		 * @param {number} id the answer id
 		 * @returns {boolean}
 		 */
-		isChecked(index) {
-			// TODO implement based on answers
-			return false
+		isChecked(id) {
+			return this.values.indexOf(id) > -1
+		},
+
+		/**
+		 * Is the provided answer required ?
+		 * This is needed for checkboxes as html5
+		 * doesn't allow to require at least ONE checked.
+		 * So we require the one that are checked or all
+		 * if none are checked yet.
+		 * @param {number} id the answer id
+		 * @returns {boolean}
+		 */
+		isRequired(id) {
+			if (this.isUnique) {
+				return true
+			}
+			return this.areNoneChecked || this.isChecked(id)
 		},
 
 		/**