From e9d84d87f5497f38ab9d5b7e4d050db5ce434e3c Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?John=20Molakvo=C3=A6=20=28skjnldsv=29?=
 <skjnldsv@protonmail.com>
Date: Wed, 6 May 2020 12:39:52 +0200
Subject: [PATCH] Use ShareWith and filter shares on the fly
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
---
 lib/Controller/ApiController.php              |  4 +-
 lib/Service/FormsService.php                  |  4 +-
 src/components/{shareDiv.vue => ShareDiv.vue} | 46 +++++++++----------
 src/components/UserDiv.vue                    |  4 +-
 src/views/Sidebar.vue                         |  2 +-
 5 files changed, 28 insertions(+), 32 deletions(-)
 rename src/components/{shareDiv.vue => ShareDiv.vue} (87%)

diff --git a/lib/Controller/ApiController.php b/lib/Controller/ApiController.php
index b402aa6..c82fa1b 100644
--- a/lib/Controller/ApiController.php
+++ b/lib/Controller/ApiController.php
@@ -216,10 +216,10 @@ class ApiController extends Controller {
 		try {
 			if ($keyValuePairs['access']) {
 				$keyValuePairs['access']['users'] = array_map(function (array $user): string {
-					return $user['id'];
+					return $user['shareWith'];
 				}, $keyValuePairs['access']['users']);
 				$keyValuePairs['access']['groups'] = array_map(function (array $group): string {
-					return $group['id'];
+					return $group['shareWith'];
 				}, $keyValuePairs['access']['groups']);
 			}
 		} catch (Exception $e) {
diff --git a/lib/Service/FormsService.php b/lib/Service/FormsService.php
index d1ab379..ee16c69 100644
--- a/lib/Service/FormsService.php
+++ b/lib/Service/FormsService.php
@@ -234,7 +234,7 @@ class FormsService {
 		$user  = $this->userManager->get($userId);
 		if ($user instanceof IUser) {
 			return [
-				'id' => $userId,
+				'shareWith' => $userId,
 				'displayName' => $user->getDisplayName(),
 				'shareType' => IShare::TYPE_USER
 			];
@@ -252,7 +252,7 @@ class FormsService {
 		$group  = $this->groupManager->get($groupId);
 		if ($group instanceof IGroup) {
 			return [
-				'id' => $groupId,
+				'shareWith' => $groupId,
 				'displayName' => $group->getDisplayName(),
 				'shareType' => IShare::TYPE_GROUP
 			];
diff --git a/src/components/shareDiv.vue b/src/components/ShareDiv.vue
similarity index 87%
rename from src/components/shareDiv.vue
rename to src/components/ShareDiv.vue
index 0cea5fd..5d6cf4c 100644
--- a/src/components/shareDiv.vue
+++ b/src/components/ShareDiv.vue
@@ -35,7 +35,7 @@
 			:searchable="true"
 			:user-select="true"
 			label="displayName"
-			track-by="id"
+			track-by="shareWith"
 			@search-change="asyncFind"
 			@select="addShare">
 			<template #noOptions>
@@ -48,7 +48,7 @@
 
 		<TransitionGroup :css="false" tag="ul" class="shared-list">
 			<!-- TODO: Iterate two times, will be cleaner, one for users, one for groups -->
-			<li v-for="(item, index) in sortedShares" :key="item.id + '-' + item.shareType" :data-index="index">
+			<li v-for="(item, index) in sortedShares" :key="item.shareWith + '-' + item.shareType" :data-index="index">
 				<UserDiv v-bind="item" />
 				<div class="options">
 					<a class="icon icon-delete svg delete-form" @click="removeShare(item)" />
@@ -120,13 +120,17 @@ export default {
 		/**
 		 * Multiseelct options. Recommendations by default,
 		 * direct search when search query is valid.
+		 * Filter out existing shares
 		 * @returns {Array}
 		 */
 		options() {
+			const shares = [...this.userShares, ...this.groupShares]
 			if (this.isValidQuery) {
-				return this.suggestions
+				// Filter out existing shares
+				return this.suggestions.filter(item => !shares.find(share => share.shareWith === item.shareWith && share.shareType === item.shareType))
 			}
-			return this.recommendations
+			// Filter out existing shares
+			return this.recommendations.filter(item => !shares.find(share => share.shareWith === item.shareWith && share.shareType === item.shareType))
 		},
 
 		noResultText() {
@@ -144,8 +148,8 @@ export default {
 	methods: {
 		removeShare(item) {
 			// Filter out the removed item
-			const users = this.userShares.filter(user => !(user.id === item.id && !item.isGroup))
-			const groups = this.groupShares.filter(group => !(group.id === item.id && item.isGroup))
+			const users = this.userShares.filter(user => !(user.shareWith === item.shareWith && item.shareType === this.SHARE_TYPES.SHARE_TYPE_USER))
+			const groups = this.groupShares.filter(group => !(group.shareWith === item.shareWith && item.shareType === this.SHARE_TYPES.SHARE_TYPE_GROUP))
 			this.$emit('update:shares', { users, groups })
 		},
 
@@ -157,11 +161,13 @@ export default {
 			const users = this.userShares.slice()
 			const groups = this.groupShares.slice()
 			const newShare = {
-				id: share.shareWith,
+				shareWith: share.shareWith,
 				displayName: share.displayName,
 				shareType: share.shareType,
 			}
 
+			// TODO: detect if already present
+
 			if (share.shareType === this.SHARE_TYPES.SHARE_TYPE_USER) {
 				users.push(newShare)
 			} else if (share.shareType === this.SHARE_TYPES.SHARE_TYPE_GROUP) {
@@ -178,7 +184,7 @@ export default {
 			return 0
 		},
 
-		async asyncFind(query, id) {
+		async asyncFind(query) {
 			// save current query to check if we display
 			// recommendations or search results
 			this.query = query.trim()
@@ -227,11 +233,11 @@ export default {
 			const rawSuggestions = Object.values(data).reduce((arr, elem) => arr.concat(elem), [])
 
 			// remove invalid data and format to user-select layout
-			const exactSuggestions = this.filterOutExistingShares(rawExactSuggestions)
+			const exactSuggestions = this.filterOutUnwantedShares(rawExactSuggestions)
 				.map(share => this.formatForMultiselect(share))
 				// sort by type so we can get user&groups first...
 				.sort((a, b) => a.shareType - b.shareType)
-			const suggestions = this.filterOutExistingShares(rawSuggestions)
+			const suggestions = this.filterOutUnwantedShares(rawSuggestions)
 				.map(share => this.formatForMultiselect(share))
 				// sort by type so we can get user&groups first...
 				.sort((a, b) => a.shareType - b.shareType)
@@ -275,7 +281,7 @@ export default {
 			const rawRecommendations = Object.values(exact).reduce((arr, elem) => arr.concat(elem), [])
 
 			// remove invalid data and format to user-select layout
-			this.recommendations = this.filterOutExistingShares(rawRecommendations)
+			this.recommendations = this.filterOutUnwantedShares(rawRecommendations)
 				.map(share => this.formatForMultiselect(share))
 
 			this.loading = false
@@ -283,13 +289,12 @@ export default {
 		},
 
 		/**
-		 * Filter out existing shares from
-		 * the provided shares search results
+		 * Filter out unwated shares
 		 *
 		 * @param {Object[]} shares the array of shares object
 		 * @returns {Object[]}
 		 */
-		filterOutExistingShares(shares) {
+		filterOutUnwantedShares(shares) {
 			return shares.reduce((arr, share) => {
 				// only check proper objects
 				if (typeof share !== 'object') {
@@ -303,17 +308,6 @@ export default {
 						return arr
 					}
 
-					// Filter out existing shares
-					if (share.value.shareType === this.SHARE_TYPES.SHARE_TYPE_USER) {
-						if (this.userShares.find(user => user.id === share.value.shareWith)) {
-							return arr
-						}
-					} else if (share.value.shareType === this.SHARE_TYPES.SHARE_TYPE_GROUP) {
-						if (this.groupShares.find(group => group.id === share.value.shareWith)) {
-							return arr
-						}
-					}
-
 					// ALL GOOD
 					// let's add the suggestion
 					arr.push(share)
@@ -337,6 +331,8 @@ export default {
 				isNoUser: result.value.shareType !== this.SHARE_TYPES.SHARE_TYPE_USER,
 				displayName: result.name || result.label,
 				icon: this.shareTypeToIcon(result.value.shareType),
+				// Vue unique binding to render within Multiselect's AvatarSelectOption
+				key: result.uuid || result.value.shareWith + '-' + result.value.shareType + '-' + result.name || result.label,
 			}
 		},
 
diff --git a/src/components/UserDiv.vue b/src/components/UserDiv.vue
index 3abcc25..aa46ca5 100644
--- a/src/components/UserDiv.vue
+++ b/src/components/UserDiv.vue
@@ -22,7 +22,7 @@
 
 <template>
 	<div class="user-row">
-		<Avatar :user="id" :display-name="computedDisplayName" :is-no-user="isNoUser" />
+		<Avatar :user="shareWith" :display-name="computedDisplayName" :is-no-user="isNoUser" />
 	</div>
 </template>
 
@@ -37,7 +37,7 @@ export default {
 	mixins: [ShareTypes],
 
 	props: {
-		id: {
+		shareWith: {
 			type: String,
 			required: true,
 		},
diff --git a/src/views/Sidebar.vue b/src/views/Sidebar.vue
index 6857806..593bce6 100644
--- a/src/views/Sidebar.vue
+++ b/src/views/Sidebar.vue
@@ -128,7 +128,7 @@ import moment from '@nextcloud/moment'
 import { subscribe, unsubscribe } from '@nextcloud/event-bus'
 import { getLocale, getDayNamesShort, getMonthNamesShort } from '@nextcloud/l10n'
 
-import ShareDiv from '../components/shareDiv'
+import ShareDiv from '../components/ShareDiv'
 import ViewsMixin from '../mixins/ViewsMixin'
 
 export default {