From b899ed26eb6d09deb333c7d405d92824341909d6 Mon Sep 17 00:00:00 2001 From: Jonas Rittershofer Date: Sat, 20 Jun 2020 17:24:28 +0200 Subject: [PATCH 01/61] Include version on feature-request template Signed-off-by: Jonas Rittershofer --- .github/ISSUE_TEMPLATE/bug_report.md | 10 +++------- .github/ISSUE_TEMPLATE/feature_request.md | 4 ++++ 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/.github/ISSUE_TEMPLATE/bug_report.md b/.github/ISSUE_TEMPLATE/bug_report.md index 889261a..38a75e0 100644 --- a/.github/ISSUE_TEMPLATE/bug_report.md +++ b/.github/ISSUE_TEMPLATE/bug_report.md @@ -6,11 +6,7 @@ labels: 0. Needs triage, bug assignees: '' --- -### How to use GitHub - -* Please use the 👍 [reaction](https://blog.github.com/2016-03-10-add-reactions-to-pull-requests-issues-and-comments/) to show that you are affected by the same issue. -* Please don't comment if you have no relevant information to add. It's just extra noise for everyone subscribed to this issue. -* Subscribe to receive notifications on status change and new comments. +**Please use the 👍 [reaction](https://blog.github.com/2016-03-10-add-reactions-to-pull-requests-issues-and-comments/) to show that you are affected by the same issue. Please don't comment if you have no relevant information to add!** **Describe the bug** A clear and concise description of what the bug is. @@ -29,8 +25,8 @@ A clear and concise description of what you expected to happen. If applicable, add screenshots to help explain your problem. **Nextcloud (please complete the following information):** -- Nextcloud-Version: [e.g. 18.0.4] -- Forms-Version: [e.g. 1.1.1] +- Nextcloud-Version: [e.g. 19.0.0] +- Forms-Version: [e.g. 2.0.0-beta4] **Desktop (please complete the following information):** - OS: [e.g. iOS] diff --git a/.github/ISSUE_TEMPLATE/feature_request.md b/.github/ISSUE_TEMPLATE/feature_request.md index 1253040..31dd5a3 100644 --- a/.github/ISSUE_TEMPLATE/feature_request.md +++ b/.github/ISSUE_TEMPLATE/feature_request.md @@ -7,6 +7,10 @@ assignees: '' --- +**Nextcloud (please complete the following information):** +- Nextcloud-Version: [e.g. 19.0.0] +- Forms-Version: [e.g. 2.0.0-beta4] + **Is your feature request related to a problem? Please describe.** A clear and concise description of what the problem is. Ex. I'm always frustrated when [...] From 704abc930f207646d16e808d14e2fb5544b572ca Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?John=20Molakvo=C3=A6?= Date: Mon, 22 Jun 2020 15:28:21 +0200 Subject: [PATCH 02/61] Revert "Allow navigation through edit via Tab-Key" --- src/components/Questions/Question.vue | 50 +------------------ src/components/Questions/QuestionMultiple.vue | 16 +----- 2 files changed, 4 insertions(+), 62 deletions(-) diff --git a/src/components/Questions/Question.vue b/src/components/Questions/Question.vue index cb64cbc..999ce2a 100644 --- a/src/components/Questions/Question.vue +++ b/src/components/Questions/Question.vue @@ -25,9 +25,7 @@ :class="{ 'question--edit': edit }" :aria-label="t('forms', 'Question number {index}', {index})" class="question" - @click="enableEdit" - @focusin="onFocusIn" - @focusout="onFocusOut"> + @click="enableEdit">
-

+

{ - this.$refs.titleInput.focus() - }) - } - }, - - /** - * Enable & disable resp. edit, if focus jumps to next question (e.g. by tab-navigation) - * @param {Object} event The triggered focusIn/focusOut event - */ - onFocusIn(event) { - if (event.target.closest('.question') !== event.relatedTarget?.closest('.question')) { - this.enableEdit() - } - }, - - onFocusOut(event) { - if (event.target.closest('.question') !== event.relatedTarget?.closest('.question')) { - this.disableEdit() - } - }, - /** * Enable the edit mode */ diff --git a/src/components/Questions/QuestionMultiple.vue b/src/components/Questions/QuestionMultiple.vue index 423d682..abdfa3a 100644 --- a/src/components/Questions/QuestionMultiple.vue +++ b/src/components/Questions/QuestionMultiple.vue @@ -37,10 +37,7 @@ @delete="onDelete">