deblan/gitea-sonarqube-bot
1
0
Fork 0
Code Issues Pull requests Packages Projects Releases Wiki Activity

Remove generics from code

Browse source 
https://jira.sonarsource.com/browse/SONARSLANG-552

Signed-off-by: Steven Kriegler <sk.bunsenbrenner@gmail.com>
This commit is contained in:
justusbunsi 2022-06-12 18:39:47 +02:00
parent cd54dade5f
commit 3e159f9ab8
No known key found for this signature in database
GPG key ID: 82B29BF2507F9F8B
1 changed files with 10 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

18
internal/clients/sonarqube/sonarqube.go
View file

@ -38,15 +38,15 @@ func GetRenderedQualityGate(qg string) string {
return fmt.Sprintf("**Quality Gate**: %s", status)
}
func retrieveDataFromApi[T PullsResponse | MeasuresResponse](sdk *SonarQubeSdk, request *http.Request, wrapper *T) (*T, error) {
func retrieveDataFromApi(sdk *SonarQubeSdk, request *http.Request, wrapper interface{}) error {
request.Header.Add("Authorization", sdk.basicAuth())
rawResponse, err := sdk.client.Do(request)
if err != nil {
return nil, err
return err
}
if rawResponse.StatusCode == http.StatusUnauthorized {
return nil, fmt.Errorf("missing or invalid API token")
return fmt.Errorf("missing or invalid API token")
}
if rawResponse.Body != nil {
@ -55,14 +55,14 @@ func retrieveDataFromApi[T PullsResponse | MeasuresResponse](sdk *SonarQubeSdk,
body, err := io.ReadAll(rawResponse.Body)
if err != nil {
return nil, err
return err
}
err = json.Unmarshal(body, wrapper)
if err != nil {
return nil, err
return err
}
return wrapper, nil
return nil
}
type Error struct {
@ -100,7 +100,8 @@ func (sdk *SonarQubeSdk) fetchPullRequests(project string) (*PullsResponse, erro
return nil, err
}
response, err := retrieveDataFromApi(sdk, request, &PullsResponse{})
response := &PullsResponse{}
err = retrieveDataFromApi(sdk, request, response)
if err != nil {
return nil, err
}
@ -134,7 +135,8 @@ func (sdk *SonarQubeSdk) GetMeasures(project string, branch string) (*MeasuresRe
return nil, err
}
response, err := retrieveDataFromApi(sdk, request, &MeasuresResponse{})
response := &MeasuresResponse{}
err = retrieveDataFromApi(sdk, request, response)
if err != nil {
return nil, err
}