From d9551d3e9cb1ededd43bde3ada23a027dce4a06d Mon Sep 17 00:00:00 2001
From: justusbunsi <sk.bunsenbrenner@gmail.com>
Date: Sun, 12 Jun 2022 14:36:31 +0200
Subject: [PATCH] Handle errors inside SonarQube client

Signed-off-by: Steven Kriegler <sk.bunsenbrenner@gmail.com>
---
 internal/clients/sonarqube/sonarqube.go | 22 ++++++++++++++++++----
 1 file changed, 18 insertions(+), 4 deletions(-)

diff --git a/internal/clients/sonarqube/sonarqube.go b/internal/clients/sonarqube/sonarqube.go
index c834345..adc62ae 100644
--- a/internal/clients/sonarqube/sonarqube.go
+++ b/internal/clients/sonarqube/sonarqube.go
@@ -70,12 +70,20 @@ func (sdk *SonarQubeSdk) fetchPullRequests(project string) *PullsResponse {
 		return nil
 	}
 	req.Header.Add("Authorization", sdk.basicAuth())
-	rawResp, _ := sdk.client.Do(req)
+	rawResp, err := sdk.client.Do(req)
+	if err != nil {
+		log.Printf("Error fetching pull requests from SonarQube: %s", err.Error())
+		return nil
+	}
 	if rawResp.Body != nil {
 		defer rawResp.Body.Close()
 	}
 
-	body, _ := io.ReadAll(rawResp.Body)
+	body, err := io.ReadAll(rawResp.Body)
+	if err != nil {
+		log.Printf("Error reading response data from SonarQube: %s", err.Error())
+		return nil
+	}
 	response := &PullsResponse{}
 	err = json.Unmarshal(body, &response)
 	if err != nil {
@@ -108,12 +116,18 @@ func (sdk *SonarQubeSdk) GetMeasures(project string, branch string) (*MeasuresRe
 		return nil, fmt.Errorf("cannot initialize Request: %w", err)
 	}
 	req.Header.Add("Authorization", sdk.basicAuth())
-	rawResp, _ := sdk.client.Do(req)
+	rawResp, err := sdk.client.Do(req)
+	if err != nil {
+		return nil, fmt.Errorf("error requesting measures from SonarQube: %w", err)
+	}
 	if rawResp.Body != nil {
 		defer rawResp.Body.Close()
 	}
 
-	body, _ := io.ReadAll(rawResp.Body)
+	body, err := io.ReadAll(rawResp.Body)
+	if err != nil {
+		return nil, fmt.Errorf("error reading measures response from SonarQube: %w", err)
+	}
 	response := &MeasuresResponse{}
 	err = json.Unmarshal(body, &response)
 	if err != nil {