Commit graph

59 commits

Author SHA1 Message Date
justusbunsi 5cb3daab60
Add webhook secret validation
Resolves: #4

Signed-off-by: Steven Kriegler <sk.bunsenbrenner@gmail.com>
2022-05-21 19:05:09 +02:00
justusbunsi e203034228 Rewrite API entrypoint to be testable (#22)
The current code base regarding API entrypoint is not testable as it
directly connects to Gitea when creating the API endpoints. This
prevented my from writing tests in the past for that part.

As the SonarQube quality gate broke due to changes in the API entrypoint
logic, tests are now required to satisfy the quality gate.

Therefore, the instantiation of the API handlers is now decoupled from
building the bot API endpoints and follows the same interface wrapper
strategy as used for the Gitea API client. This makes it testable.

Now, tests are written for the most parts of the API entrypoint. I've
also noticed that there was much overhead within the tests for a
non-implemented function `fetchDetails`. So I dropped that function for
now.

Signed-off-by: Steven Kriegler <sk.bunsenbrenner@gmail.com>

Co-authored-by: justusbunsi <sk.bunsenbrenner@gmail.com>
Reviewed-on: https://codeberg.org/justusbunsi/gitea-sonarqube-bot/pulls/22
2022-05-21 18:21:05 +02:00
justusbunsi 7f5c3390c4
Add tests for Gitea API
Signed-off-by: Steven Kriegler <sk.bunsenbrenner@gmail.com>
2022-05-21 13:50:58 +02:00
justusbunsi 4d28133b12
Extract test api test helpers
Signed-off-by: Steven Kriegler <sk.bunsenbrenner@gmail.com>
2022-05-21 12:23:57 +02:00
justusbunsi 34e2783cb1
Skip logging non-api routes
Signed-off-by: Steven Kriegler <sk.bunsenbrenner@gmail.com>
2022-05-15 16:03:19 +02:00
justusbunsi 21837f9b25
Export webhook and token struct
Signed-off-by: Steven Kriegler <sk.bunsenbrenner@gmail.com>
2021-10-17 16:01:15 +02:00
justusbunsi e01096a7fe
Eliminate viper references from token and webhook
Signed-off-by: Steven Kriegler <sk.bunsenbrenner@gmail.com>
2021-10-17 15:57:45 +02:00
justusbunsi 021d01b5fb
Remove useless types
Signed-off-by: Steven Kriegler <sk.bunsenbrenner@gmail.com>
2021-10-17 15:43:25 +02:00
justusbunsi 8a7e9f83fa
Refactor action validation
Signed-off-by: Steven Kriegler <sk.bunsenbrenner@gmail.com>
2021-10-17 11:12:50 +02:00
justusbunsi 90581744ff
Set analysis status on PR creation
Signed-off-by: Steven Kriegler <sk.bunsenbrenner@gmail.com>
2021-10-13 08:54:21 +02:00
justusbunsi dfffd17223
Open comment link in new tab
Signed-off-by: Steven Kriegler <sk.bunsenbrenner@gmail.com>
2021-10-12 14:09:24 +02:00
justusbunsi f187d4f8c6
Allow customizing metrics fetch from SonarQube
Signed-off-by: Steven Kriegler <sk.bunsenbrenner@gmail.com>
2021-10-12 13:14:17 +02:00
justusbunsi 0bd65d8a1d
Allow override the provided revision
Signed-off-by: Steven Kriegler <61625851+justusbunsi@users.noreply.github.com>
2021-10-11 14:21:17 +02:00
justusbunsi bb156f95bf
Log response code for non-working status update
Signed-off-by: Steven Kriegler <61625851+justusbunsi@users.noreply.github.com>
2021-10-11 11:28:32 +02:00
justusbunsi 48cb8a0ede
Handle favicon requests
Signed-off-by: Steven Kriegler <61625851+justusbunsi@users.noreply.github.com>
2021-10-11 08:50:50 +02:00
justusbunsi ae55eaf97c
Prevent bot from interpreting unknown actions
Signed-off-by: Steven Kriegler <61625851+justusbunsi@users.noreply.github.com>
2021-10-10 19:45:57 +02:00
justusbunsi e28e524456
Post analysis details on bot action comment
Signed-off-by: Steven Kriegler <61625851+justusbunsi@users.noreply.github.com>
2021-10-10 19:39:33 +02:00
justusbunsi 369edfcfae
Fetch actual quality gate status on bot comment
Signed-off-by: Steven Kriegler <61625851+justusbunsi@users.noreply.github.com>
2021-10-10 19:01:48 +02:00
justusbunsi 895dfe92e0
Add pending status on PR synchronize event
Signed-off-by: Steven Kriegler <61625851+justusbunsi@users.noreply.github.com>
2021-10-10 17:59:28 +02:00
justusbunsi 56f7a1081b
Implement skeleton for different webhook handler
Signed-off-by: Steven Kriegler <61625851+justusbunsi@users.noreply.github.com>
2021-10-10 17:32:25 +02:00
justusbunsi 5b72ee7bc0
Differ between several gitea events
Signed-off-by: Steven Kriegler <61625851+justusbunsi@users.noreply.github.com>
2021-10-10 17:17:29 +02:00
justusbunsi de575605f9
Move sonarqube sdk files
Signed-off-by: Steven Kriegler <61625851+justusbunsi@users.noreply.github.com>
2021-10-10 16:43:37 +02:00
justusbunsi bf453c6c43
Centralize bot actions
Signed-off-by: Steven Kriegler <61625851+justusbunsi@users.noreply.github.com>
2021-10-10 16:39:26 +02:00
justusbunsi c99925abb3
Fix URL for status
Signed-off-by: Steven Kriegler <61625851+justusbunsi@users.noreply.github.com>
2021-10-10 16:29:29 +02:00
justusbunsi c6bc0d71ff
Move gitea sdk files
Signed-off-by: Steven Kriegler <61625851+justusbunsi@users.noreply.github.com>
2021-10-10 16:28:59 +02:00
justusbunsi 46c5ab2aec
Rename webhook_handler to api
Signed-off-by: Steven Kriegler <61625851+justusbunsi@users.noreply.github.com>
2021-10-10 16:18:14 +02:00
justusbunsi e20b1469d3
Reduce UpdateStatus parameter mess
Signed-off-by: Steven Kriegler <61625851+justusbunsi@users.noreply.github.com>
2021-10-10 16:14:09 +02:00
justusbunsi 57fc8054b2
Bot listens to actions via Gitea comments
Signed-off-by: Steven Kriegler <61625851+justusbunsi@users.noreply.github.com>
2021-10-10 15:58:03 +02:00
justusbunsi 3bab05bb71
Fix required header for SonarQube endpoint
Signed-off-by: Steven Kriegler <61625851+justusbunsi@users.noreply.github.com>
2021-10-10 13:07:10 +02:00
justusbunsi 2873eb5159
Switch to gin-gonic as server
Signed-off-by: Steven Kriegler <61625851+justusbunsi@users.noreply.github.com>
2021-10-09 21:48:51 +02:00
justusbunsi 758e3c75cc
Switch to another default port
Signed-off-by: Steven Kriegler <61625851+justusbunsi@users.noreply.github.com>
2021-10-09 21:23:40 +02:00
justusbunsi 45fbfed51b
Split settings structs into separate files
Signed-off-by: Steven Kriegler <61625851+justusbunsi@users.noreply.github.com>
2021-10-09 21:10:30 +02:00
justusbunsi aac7f5743d
Fix tests
Signed-off-by: Steven Kriegler <61625851+justusbunsi@users.noreply.github.com>
2021-10-09 21:09:23 +02:00
justusbunsi 34dbd4f609
Add status-check to PR/commit
Signed-off-by: Steven Kriegler <61625851+justusbunsi@users.noreply.github.com>
2021-10-09 20:45:21 +02:00
justusbunsi d24bfdad4f
Replace violations with code_smells
Signed-off-by: Steven Kriegler <61625851+justusbunsi@users.noreply.github.com>
2021-10-09 20:44:09 +02:00
justusbunsi e608a8f969
Retrieve actual data from SonarQube for comment
Signed-off-by: Steven Kriegler <61625851+justusbunsi@users.noreply.github.com>
2021-10-09 18:09:54 +02:00
justusbunsi a1990a60f4
Format code
Signed-off-by: Steven Kriegler <61625851+justusbunsi@users.noreply.github.com>
2021-10-03 17:57:22 +02:00
justusbunsi 16f545f179
Fix failing tests
Signed-off-by: Steven Kriegler <61625851+justusbunsi@users.noreply.github.com>
2021-10-03 17:49:23 +02:00
justusbunsi 1dab92385f
Fetch raw measures from SonarQube
Signed-off-by: Steven Kriegler <61625851+justusbunsi@users.noreply.github.com>
2021-07-12 16:58:48 +02:00
justusbunsi a0f2684029
Add Gitea SDK to actually post a comment
Signed-off-by: Steven Kriegler <61625851+justusbunsi@users.noreply.github.com>
2021-07-12 12:58:06 +02:00
justusbunsi 2af7ba3da1
Make application runnable
Signed-off-by: Steven Kriegler <61625851+justusbunsi@users.noreply.github.com>
2021-07-11 15:17:03 +02:00
justusbunsi 230e85875b
Parse pull request index from SQ branch name
Signed-off-by: Steven Kriegler <61625851+justusbunsi@users.noreply.github.com>
2021-07-11 14:44:10 +02:00
justusbunsi b7fa2b77f9
Add tests for PR-only handling
Signed-off-by: Steven Kriegler <61625851+justusbunsi@users.noreply.github.com>
2021-07-11 12:28:00 +02:00
justusbunsi 5082e5d3f3
Use OOP-ish style for SonarQube webhook handling
Signed-off-by: Steven Kriegler <61625851+justusbunsi@users.noreply.github.com>
2021-06-29 12:27:01 +02:00
justusbunsi 86a644f31f
Use OOP-ish style for configuration loading
Signed-off-by: Steven Kriegler <61625851+justusbunsi@users.noreply.github.com>
2021-06-29 10:29:20 +02:00
justusbunsi 4ba781d74f
Respect go package concepts
Signed-off-by: Steven Kriegler <61625851+justusbunsi@users.noreply.github.com>
2021-06-29 08:09:21 +02:00
justusbunsi 7bfe729b67
Skip non-PR SonarQube webhooks from processing
Signed-off-by: Steven Kriegler <61625851+justusbunsi@users.noreply.github.com>
2021-06-24 16:52:06 +02:00
justusbunsi c575542118
Add SonarQube endpoint
Signed-off-by: Steven Kriegler <61625851+justusbunsi@users.noreply.github.com>
2021-06-24 15:09:05 +02:00
justusbunsi 08eab186db
Let the bot panic if no project mapping provided
The bot cannot properly handle webhooks when no projects are configured.
So it is good to not let the bot run with such an invalid configuration.

Signed-off-by: Steven Kriegler <61625851+justusbunsi@users.noreply.github.com>
2021-06-24 10:36:52 +02:00
justusbunsi 6dfb2dd846
Properly map projects from SQ and Gitea in config
Signed-off-by: Steven Kriegler <61625851+justusbunsi@users.noreply.github.com>
2021-06-22 11:27:53 +02:00