From 9e0e2a9fcfae4336958dc3e93d4beacfc7a2f642 Mon Sep 17 00:00:00 2001 From: silverwind Date: Wed, 20 May 2020 06:06:04 +0200 Subject: [PATCH] Enable stylelint's shorthand-property-no-redundant-values (#11436) Enabled the rule and --fix'ed issues. Co-authored-by: techknowlogick --- .stylelintrc | 1 + web_src/less/_base.less | 4 ++-- web_src/less/_markdown.less | 2 +- web_src/less/_repository.less | 14 +++++++------- web_src/less/_review.less | 4 ++-- 5 files changed, 13 insertions(+), 12 deletions(-) diff --git a/.stylelintrc b/.stylelintrc index be1c15bfa..102b90f1f 100644 --- a/.stylelintrc +++ b/.stylelintrc @@ -14,3 +14,4 @@ rules: number-leading-zero: never rule-empty-line-before: null selector-pseudo-element-colon-notation: null + shorthand-property-no-redundant-values: true diff --git a/web_src/less/_base.less b/web_src/less/_base.less index 03dc61a98..962bd03b2 100644 --- a/web_src/less/_base.less +++ b/web_src/less/_base.less @@ -323,7 +323,7 @@ code, &.container { &.fluid { &.padded { - padding: 0 10px 0 10px; + padding: 0 10px; } } } @@ -582,7 +582,7 @@ code, .sha.label { font-family: @monospaced-fonts, monospace; font-size: 13px; - padding: 6px 10px 4px 10px; + padding: 6px 10px 4px; font-weight: normal; margin: 0 6px; } diff --git a/web_src/less/_markdown.less b/web_src/less/_markdown.less index 651edb572..420f24cbb 100644 --- a/web_src/less/_markdown.less +++ b/web_src/less/_markdown.less @@ -9,7 +9,7 @@ } &.file-view { - padding: 2em 2em 2em !important; + padding: 2em !important; } > *:first-child { diff --git a/web_src/less/_repository.less b/web_src/less/_repository.less index 38f9e115c..16ccd3744 100644 --- a/web_src/less/_repository.less +++ b/web_src/less/_repository.less @@ -426,12 +426,12 @@ } img { - padding: 5px 5px 0 5px; + padding: 5px 5px 0; } } .plain-text { - padding: 1em 2em 1em 2em; + padding: 1em 2em; pre { word-break: break-word; @@ -1486,7 +1486,7 @@ height: 12px; width: 40px; display: inline-block; - margin: 2px 4px 0 4px; + margin: 2px 4px 0; vertical-align: text-top; .add { @@ -1638,7 +1638,7 @@ &.file-content { img { max-width: 100%; - padding: 5px 5px 0 5px; + padding: 5px 5px 0; } img.emoji { padding: 0; @@ -2181,7 +2181,7 @@ > .item { float: left; - padding: .5rem .5rem !important; + padding: .5rem !important; font-size: 1.5em; width: 45px; left: 13px; @@ -2498,7 +2498,7 @@ &:not(:first-child) { border-top: 1px solid #eaeaea; padding: 1rem; - margin: 15px -1rem -1rem -1rem; + margin: 15px -1rem -1rem; } > .svg { @@ -2581,7 +2581,7 @@ .precolors { padding-left: 0; padding-right: 0; - margin: 3px 10px auto 10px; + margin: 3px 10px auto; width: 120px; .color { diff --git a/web_src/less/_review.less b/web_src/less/_review.less index 38e5c6279..8904e3d3e 100644 --- a/web_src/less/_review.less +++ b/web_src/less/_review.less @@ -75,7 +75,7 @@ .ui.active.tab { border: 1px solid #d4d4d5; padding: .5em; - border-radius: 0 .28571429rem .28571429rem .28571429rem; + border-radius: 0 .28571429rem .28571429rem; } .ui.active.markdown.tab { @@ -93,7 +93,7 @@ .footer { border-top: 1px solid #f1f1f1; - padding: 10px 0 10px 0; + padding: 10px 0; .markdown-info { display: inline-block;