From b710f85797dd5c97b124631d4acc0a85cad7524f Mon Sep 17 00:00:00 2001 From: joshua stein Date: Wed, 3 Jul 2013 22:40:59 -0500 Subject: [PATCH] don't mail out deleted stories or comments --- script/mail_new_activity | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/script/mail_new_activity b/script/mail_new_activity index 803cfb9..c4de746 100755 --- a/script/mail_new_activity +++ b/script/mail_new_activity @@ -48,7 +48,7 @@ mailing_list_users = User.where(:mailing_list_enabled => true) last_story_id = (Keystore.value_for(LAST_STORY_KEY) || Story.last.id).to_i -Story.where("id > ?", last_story_id).order(:id).each do |s| +Story.where("id > ? AND is_expired = ?", last_story_id, false).order(:id).each do |s| s.fetch_story_cache! if s.story_cache.blank? @@ -118,7 +118,8 @@ Keystore.put(LAST_STORY_KEY, last_story_id) last_comment_id = (Keystore.value_for(LAST_COMMENT_KEY) || Comment.last.id).to_i -Comment.where("id > ?", last_comment_id).order(:id).each do |c| +Comment.where("id > ? AND (is_deleted = ? AND is_moderated = ?)", +last_comment_id, false, false).order(:id).each do |c| mailing_list_users.each do |u| if (c.story.tags.map{|t| t.id } & u.tag_filters.map{|t| t.tag_id }).any? next