deblan/journalduhacker
1
0
Fork 0
Code Issues Pull requests Releases Wiki Activity
398 commits 2 branches 0 tags 1.9 MiB
Commit graph

321 commits

Author SHA1 Message Date
joshua stein ad762d233a rss: comments link must be encoded as well 2012-11-28 15:18:41 -06:00
joshua stein 91b1255d96 story form: auto-apply video tag to vimeo links, too 2012-11-27 11:47:44 -06:00
joshua stein e5a0b671b8 story: simplify tags malarky and just use mark_for_destruction on associated objects 2012-11-26 13:39:16 -06:00
joshua stein 088084965c rss: only hide comments link when no url 
stories with a url but also a description were previously not
getting comments link shown
 2012-11-21 22:15:00 -06:00
joshua stein 3e689b1c35 check for show_story first 2012-11-21 22:13:50 -06:00
joshua stein cb8901473c add an #invite anchor to the settings url 2012-11-21 22:04:29 -06:00
joshua stein 70f9208a7b shorten top links to avoid running into each other on small screens 2012-11-21 22:04:29 -06:00
joshua stein 367982adef whitespace cleanup 2012-11-21 22:04:29 -06:00
wilkie e37053cea4 Removes link to reply on comment when not on a story page. 
The reply link does not work on any page that isn't a story page because
it replies on the fact that a comment_form div exists on a page. That
form is the base comment field present on a story page. Therefore,
removing the link when the story is displayed next to the comment
selects for that case easily.

Closes #36 by virtue of removing the link.
 2012-11-15 21:25:34 -05:00
joshua stein fd4a278d3b fix duplicate description= definition 2012-11-13 11:39:50 -06:00
joshua stein 6deadc731a designate certain tags as media types, require a tag other than those 
just tagging something "video" doesn't make it appropriate for
submission, it still requires a categorization tag
 2012-11-12 11:02:18 -06:00
joshua stein 9ece6666bf add stupid temporary hack to strip out utf8mb4 chars that are screwing up mysql 
4-byte utf8 chars like emoji are passed around in ruby fine, but
when they are put into mysql queries, strings get truncated at the
first mb4 character.  to prevent truncation, strip out mb4
characters in most user-controlled fields like comments, story
descriptions and titles, and messages.

to properly support utf8mb4, mysql server 5.5 is needed, the table
encodings need to be changed to utf8mb4, and the mysql2 gem needs to
be upgraded once it supports utf8mb4:

https://github.com/brianmario/mysql2/issues/249
 2012-11-07 21:58:10 -06:00
joshua stein 0eac1c375a show user count on user tree page 2012-10-26 17:08:19 -05:00
joshua stein 47f1c44fc9 do incremented_value_for in a transaction to make sure we get the right key back 
do sqlite checks based on Keystore.connection.adapter_name rather
than assuming one environment uses sqlite and the others don't
 2012-10-24 14:55:14 -05:00
joshua stein 5ee6c227a3 <> -> < />, add noarchive robots header 2012-10-24 11:53:43 -05:00
joshua stein d07c555595 comments can be deleted or moderated to be considered gone 2012-10-24 11:53:43 -05:00
joshua stein a2b034ea36 fix pulling vote for current story when showing a specific comment 2012-10-24 11:53:43 -05:00
Alan P. Laudicina 1ab6f592b6 Wrap long line 2012-10-24 07:03:25 -04:00
Alan P. Laudicina ba284f7f29 Add default description, which points to comments 2012-10-24 06:57:12 -04:00
joshua stein d495e9472a move hotness window back to 48 hours 2012-10-09 11:06:43 -05:00
joshua stein 24ed0e1f6f only count downvotes in downvote summary 2012-10-09 11:04:53 -05:00
joshua stein 468a0cbe60 no need to make a delta for seconds, just use created_at 2012-10-09 11:04:53 -05:00
joshua stein c4f1a5e756 we're not doing comment flagging, remove 2012-10-09 11:04:43 -05:00
joshua stein c0ba39834b only do new tag check for new stories 2012-10-07 01:44:33 -05:00
joshua stein b8ec2daabe only apply light link color to story list, not story detail page 2012-09-25 10:54:25 -05:00
joshua stein 8af36b2280 make visited story links a lighter blue 
closes #24
 2012-09-25 10:51:10 -05:00
Sam Hasler eb24304686 Highlight video tags like pdf tags 2012-09-25 17:18:34 +02:00
joshua stein b04f3dfe51 rss: set isPermaLink="false" on guid because google reader is stupid 
closes #25
 2012-09-20 19:00:14 -05:00
joshua stein 6cb466bc83 shrink story hotness window down to 24 hours as we are growing 2012-09-20 11:00:11 -05:00
joshua stein a05421082c don't set @heading, there's already a navbar link for filters 2012-09-20 10:56:54 -05:00
joshua stein 058cf16863 don't allow privileged tags to be filtered 2012-09-20 10:56:31 -05:00
joshua stein 39bb9b77de minor cleanup 2012-09-20 10:53:11 -05:00
joshua stein 78a000a0b8 bring back selected tags for editing existing stories 2012-09-20 10:50:19 -05:00
Robert J Samson 45d87069dd Check that user has appropriate permissions on tags before_save 2012-09-19 22:13:20 -04:00
Robert J Samson f3eb44972b Check to make sure a user isn't improperly using a privileged tag when saving a Story. 2012-09-19 20:57:45 -04:00
Robert J Samson 7fd75a7f3a More descriptive method and attribute names 2012-09-19 20:28:09 -04:00
Robert J Samson 5ada55f10d Add a 'private' attribute to tags to allow for admin / mod specific tags 
Private tags would allow admins to create tags that only admins could
use, and that regular users could not filter. The best example use case
for this is an 'announements' tag for site announements that all users
should see.
 2012-09-19 16:44:57 -04:00
joshua stein 64c6949edf paginate /comments 2012-09-19 13:40:02 -05:00
joshua stein 2c6eeeca1b link to /comments in the header 2012-09-19 13:32:52 -05:00
joshua stein d9bd724c1d button_to_function is deprecated 2012-09-19 12:37:42 -05:00
joshua stein 0663ea0fed show how many users are filtering each tag 2012-09-19 12:25:11 -05:00
joshua stein b2315a5728 add private rss feeds for logged-out users by passing a token 
create a random rss_token for each user and append it to the rss
urls.  when adding the user-specific feed url to a feed reader, the
user's tag filters will be applied before generating the rss view,
giving the same list of stories that the user sees while logged in.
 2012-09-18 10:43:05 -05:00
joshua stein 7c8db7269d wrap 2012-09-18 10:22:59 -05:00
joshua stein d5cf5bc4f5 use autofocus attribute for text boxes instead of javascript 2012-09-18 09:44:22 -05:00
joshua stein 42150c8a56 fix karma adjustment when not upvoting 2012-09-17 19:24:33 -05:00
joshua stein 40a5f3f8b8 fix back link to page 2, fixes #21 2012-09-17 14:30:41 -05:00
joshua stein b7e5447c1d allow embedded images in story text, but still not in comments 2012-09-17 13:24:29 -05:00
joshua stein cb5e05c461 minor cleanups after last merge 2012-09-16 15:51:25 -05:00
joshua stein 17d8213bc7 merge @username mentions and notifications from @rjsamson 2012-09-16 15:41:21 -05:00
joshua stein dae138cddd show in a user profile who the user was invited by 2012-09-16 15:16:32 -05:00
joshua stein 857f2964d7 issue#18: show admin/moderator status on user tree 2012-09-16 15:14:05 -05:00
joshua stein 7b1ec6fc3d some mobile css fixes 2012-09-16 15:05:48 -05:00
joshua stein ad1d925c61 prevent double clicking of the post comment button from creating two comments 2012-09-14 16:17:45 -05:00
joshua stein 45a498ea51 comments have an initial upvote of 1, which has a non-zero confidence 2012-09-14 15:54:45 -05:00
joshua stein a51ca8c533 set editor_user_id unconditionally in delete 2012-09-10 15:46:52 -05:00
joshua stein 66917339cc automatically assign the video tag for youtube.com urls 2012-09-10 13:57:08 -05:00
Robert J Samson ec1bcb9704 Added mentions in comments using @username convention. @username is linked to user profile in comment text, and notifications are available via email and pushover (with notification preferences) when a user is mention. 2012-09-10 13:40:33 -04:00
joshua stein 09508f3ad6 don't hardcode lobste.rs url (which wasn't using ssl anyway), use root_url 2012-09-09 11:56:10 -05:00
joshua stein 0abe41bd6d mention that profile e-mail addresses are gravatarized 2012-09-08 19:37:30 -05:00
joshua stein 729c38d4c7 how did those tabs get there 2012-09-08 19:37:21 -05:00
joshua stein e8d34910a6 put faces to names 2012-09-08 19:32:21 -05:00
joshua stein af5b00572c whenever a story/comment is moderated, send a message to the user 2012-09-08 18:32:56 -05:00
joshua stein ec7389d9a0 Merge pull request #15 from rjsamson/avg-karma 
show average karma in user profile
 2012-09-07 11:06:26 -07:00
Robert J Samson b15710d107 Show average karma in parentheses 2012-09-07 13:56:26 -04:00
joshua stein fb9c0228b0 remove red text from cancel button, make post button bold 2012-09-07 12:40:07 -05:00
joshua stein 96ee762fdf Merge pull request #3 from prezjordan/master 
add cancel button for comment form
 2012-09-07 10:37:45 -07:00
Robert J Samson 6554983fd7 Add average karma to user profiles 2012-09-07 13:25:59 -04:00
joshua stein ea143e6fbb reject email addresses with spaces 2012-09-07 09:25:00 -05:00
joshua stein f0bc4e7c8d reject email addresses with spaces, catch mailer delivery errors 2012-09-07 09:24:29 -05:00
joshua stein 1987a24a2a properly set @title/@heading everywhere 2012-09-07 09:18:15 -05:00
joshua stein c093431898 allow tags to be filtered by default for new and non-logged-in users 2012-09-06 13:44:42 -05:00
joshua stein d986952870 remove unused footer partial 2012-09-06 13:43:38 -05:00
joshua stein e61f8ea386 bail properly if the message isn't found 2012-09-06 12:43:51 -05:00
joshua stein 61f45092f8 cope with tag filters being on deleted tags 2012-09-06 12:07:35 -05:00
joshua stein 6be5150bb0 cleanup 2012-09-04 20:59:51 -05:00
joshua stein 913aa30827 Merge pull request #9 from maxpow4h/master 
properly implement Keystore.incremented_value_for for sqlite
 2012-09-04 18:42:17 -07:00
Maxwell Swadling 3c65a3332f Fixed the sqlite FIXME for keystore 2012-09-05 09:01:59 +10:00
joshua stein 17ce13d49e move previewed/posted comment outside of <form>, fixes duplicate comment problem 
a comment would get posted and then displayed inside the original
<form>.  when that comment would get edited, its <form> would be
nested inside the original one, and on webkit browsers, submitting
the inside form would submit the outside one.
 2012-09-04 11:33:49 -05:00
joshua stein 6ae36ea492 route /newest/:user to show all stories by that user 2012-09-03 17:29:10 -05:00
joshua stein e9e162167d route /threads/:user to show recent threads for that user 2012-09-03 17:11:53 -05:00
joshua stein 1b60604806 if a url looks like a pdf, select the pdf tag 2012-09-03 16:54:32 -05:00
joshua stein b91a637535 Story#url has a custom validator, remove duplicate 2012-09-03 16:53:58 -05:00
joshua stein 061f540506 remove stray line 2012-09-03 16:42:50 -05:00
joshua stein 621dde2dc5 show new messages in red so it's obvious 2012-09-03 13:08:31 -05:00
joshua stein 89a32886e1 warn users about inviting strangers 2012-09-03 12:56:06 -05:00
joshua stein 5a72a9d6a7 if a comment is downvoted, show the comment's user a summary of its downvote reasons 2012-09-03 12:42:32 -05:00
joshua stein 49feb9ba43 use the invitation's e-mail address as the default for the new user 2012-09-03 11:44:29 -05:00
joshua stein 9f0747a46b move score down 1 pixel, looks better in webkit 2012-09-03 11:30:42 -05:00
joshua stein 0691235882 suppress deleted messages from message list since they're not actually wiped out until both parties delete 2012-09-03 11:25:14 -05:00
joshua stein 9b5310a1eb Merge pull request #5 from kevinburke/responsive-for-all 
Use max-width instead of max-device-width
 2012-09-02 10:34:59 -07:00
joshua stein e6c74e8251 add moderation logging 
- add users.is_moderator and look at that for most things, not
is_admin

- make default user in readme be a moderator

- log moderator actions in story edits, comment
  deletions/undeletions (and later, user disabling).

- remove ability for moderators to edit comments, there's really no
  reason to.
 2012-09-02 12:18:52 -05:00
Jordan Scales d410f4f424 cancel link is now a button, js formatting consistency, removed extra styling 2012-09-02 12:51:32 -04:00
Kevin Burke 31f5c110fc Use max-width instead of max-device-width 
Max-device-width will only kick in on physical devices with width smaller than
480px. It makes sense though to trigger the responsive layout on any device
where the viewport is that narrow, not just ones where the device itself is
that narrow.

For an example of this in practice, visit barackobama.com on a desktop, resize
your browser window and watch the layout change responsively.
 2012-09-01 22:45:05 -07:00
joshua stein 3bd2e6b8a7 show traffic value in link title 2012-09-01 22:56:07 -05:00
joshua stein 88894a66fc catch sphinx errors 2012-09-01 22:56:07 -05:00
Jordan Scales 56e061db72 styling for comment reply cancel button 2012-08-30 16:50:01 -04:00
Jordan Scales 14fe4e6623 comment reply form now has a cancel button 2012-08-30 16:49:49 -04:00
joshua stein d6255916e8 fix story hiding when downvoted; don't count comment votes 2012-08-29 08:48:57 -05:00
joshua stein a921d3eeb5 add readme, do some cleanup before open sourcing 2012-08-24 11:42:23 -05:00
joshua stein 6fb3e5ebd8 only hide submission guidelines when the user has more than 2 submissions 2012-08-24 11:42:23 -05:00
joshua stein a016086b44 increase line-height of comments to match textarea, color links gray 2012-08-24 11:42:23 -05:00
joshua stein 41b6d7620a add some post guidelines 2012-08-24 11:42:23 -05:00
joshua stein fc1f7fe5ee move header into layout, no need for another file 2012-08-24 11:42:23 -05:00
joshua stein 3e7cdbe253 tweak traffic decay to be a little slower 2012-08-24 11:42:23 -05:00
joshua stein 43444f179b implement traffic counter that adjusts redness of lobsters logo 2012-08-24 11:42:23 -05:00
joshua stein 342ede4d4c reload user's tag filters after modifying, before showing again 2012-08-24 11:42:23 -05:00
joshua stein 9a51d7d1f8 raw the memo, we don't need xss protection here 2012-08-24 11:42:23 -05:00
joshua stein f34ad51891 log some more things on countinual 2012-08-24 11:42:23 -05:00
joshua stein 49c6e64aac count user creation on countinual 2012-08-24 11:42:20 -05:00
joshua stein 776bf89dea implement /comments.rss 2012-08-24 11:41:37 -05:00
joshua stein f6b252e456 a tiny bit taller textareas 2012-08-24 11:41:37 -05:00
joshua stein f541d4118c fix 2012-08-24 11:41:37 -05:00
joshua stein 0c0aa465bb make /comments show latest comments 2012-08-24 11:41:37 -05:00
joshua stein c34abddc3d pre overflow auto 2012-08-24 11:41:37 -05:00
joshua stein edcee1bddd << strikes again 2012-08-24 11:41:37 -05:00
joshua stein c945f29040 add similar-url check for www\d*\., rewrite checker to be simpler 2012-08-24 11:41:37 -05:00
joshua stein 70db7a5879 short ids in urls should be case insensitive, so make them that way anyway 2012-08-24 11:41:37 -05:00
joshua stein 33e6eee4e0 don't count deleted comments for stories, update comment counts after comment del/undel 2012-08-24 11:41:37 -05:00
joshua stein 3640e1e7a3 comment deleting and undeleting 2012-08-24 11:41:37 -05:00
joshua stein 7dd4b99ac2 escape slashes in search queries 2012-08-24 11:41:37 -05:00
joshua stein 208e1832d6 use @title 2012-08-24 11:41:37 -05:00
joshua stein fd8ec36608 story previews 2012-08-24 11:41:37 -05:00
joshua stein bc0d934d5e focus search box if there is no search yet 2012-08-24 11:41:37 -05:00
joshua stein abb8392c16 search engine! 2012-08-24 11:41:36 -05:00
joshua stein b01f9e9027 fixup header current page stuff 2012-08-24 11:41:36 -05:00
joshua stein dd9966c0a3 color pdf tags purpleish 2012-08-24 11:41:36 -05:00
joshua stein bd9d2aa3c4 put tags in alpha order, but put pdf first 2012-08-24 11:41:36 -05:00
joshua stein 82ae95f8ca disable trimming threads to our own reply for now, it's busted 2012-08-24 11:41:36 -05:00
joshua stein e0da3a7039 little spacing tweaks 2012-08-24 11:41:36 -05:00
joshua stein a51147b5d0 fix bug; don't show downvote reason for stories 2012-08-24 11:41:36 -05:00
joshua stein 389b4c61ec do better at finding near-similar urls already posted recently 
http -> https, trailing slash, etc.
 2012-08-24 11:41:36 -05:00
joshua stein 6f3f018598 fix back link to page 1 2012-08-24 11:41:36 -05:00
joshua stein da5c04504a fix voting on stories where the user previously commented on 2012-08-24 11:41:36 -05:00
joshua stein 88f01210d3 enable activerecord attribute whitelisting just in case 2012-08-24 11:41:36 -05:00
joshua stein 75f026b182 do some short caching for guest views of story indexes 2012-08-24 11:41:36 -05:00
joshua stein c2206f46cd fix appearance of other tags when viewing single tag 
don't just pull taggings where the tag id matches, pull all stories
where the id is in the list of stories tagged with that tag
 2012-08-24 11:41:36 -05:00
joshua stein 2ba78cc10e downcase vote reasons 2012-08-24 11:41:36 -05:00
joshua stein 361a689b13 link to invited user profile 2012-08-24 11:41:36 -05:00
joshua stein 43aa0047e9 simplify markdown help link 2012-08-24 11:41:36 -05:00
joshua stein 9f6a1a7e4a try to collect some about info from the new user 2012-08-24 11:41:36 -05:00
joshua stein c17ea7b638 while we're slow, allow upvoted stories to stick around longer 2012-08-24 11:41:36 -05:00
joshua stein b9c8f1d371 oops, confidence desc 2012-08-24 11:41:36 -05:00
joshua stein db10cd115f explain text field better 2012-08-24 11:41:36 -05:00
joshua stein f664734a40 fix markdown links that have trailing punctuation inside the url 2012-08-24 11:41:36 -05:00
joshua stein be578454a9 taller line-height too 2012-08-24 11:41:36 -05:00
joshua stein f8b1cc0443 tweak comment spacing a bit 2012-08-24 11:41:36 -05:00
joshua stein 10faafc8af no need to say that 2012-08-24 11:41:36 -05:00
joshua stein 2a5b60fbb1 color root too 2012-08-24 11:41:36 -05:00
joshua stein 758d62304a move l.png to data uri 2012-08-24 11:41:36 -05:00
joshua stein a407bad2d6 better tree style 2012-08-24 11:41:36 -05:00